amd64-generic-telemetry:14145 failed |
||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of oshima@google.com amd64-generic-telemetry:14145 failed Builders failed on: - amd64-generic-telemetry: https://luci-milo.appspot.com/buildbot/chromiumos.chromium/amd64-generic-telemetry/14145
,
Feb 27 2018
Actually, testSkpicturePrinter is failing too, and I wonder if that's the real cause of the bot failure. I'll disable the test on chromeos for now. testSkpicturePrinter test: https://cs.chromium.org/chromium/src/tools/perf/measurements/skpicture_printer_unittest.py?rcl=7b5868ec669060c022c42a8f02d5ab1b775aafd4&l=25 +ccameron@ who landed crrev.com/c/936431. I wonder if this CL is related. 02/26 19:07:11.545 INFO |run_chromeos_tests:0052| Taking screenshots upon failures disabled. 02/26 19:07:11.546 INFO |run_chromeos_tests:0052| Traceback (most recent call last): 02/26 19:07:11.547 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/measurements/multipage_skpicture_printer_unittest.py", line 33, in testSkpicturePrinter 02/26 19:07:11.548 INFO |run_chromeos_tests:0052| assert 'not supported' in results.failures[0].exc_info[1].message 02/26 19:07:11.550 INFO |run_chromeos_tests:0052| AttributeError: 'NoneType' object has no attribute 'exc_info' 02/26 19:07:27.047 INFO |run_chromeos_tests:0052| [231/260] measurements.skpicture_printer_unittest.SkpicturePrinterUnitTest.testSkpicturePrinter queued 02/26 19:07:27.050 INFO |run_chromeos_tests:0052| [232/260] measurements.skpicture_printer_unittest.SkpicturePrinterUnitTest.testSkpicturePrinter failed unexpectedly 15.4952s: 02/26 19:07:27.053 INFO |run_chromeos_tests:0052| Taking screenshots upon failures disabled. 02/26 19:07:27.055 INFO |run_chromeos_tests:0052| Traceback (most recent call last): 02/26 19:07:27.056 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/measurements/skpicture_printer_unittest.py", line 32, in testSkpicturePrinter 02/26 19:07:27.057 INFO |run_chromeos_tests:0052| assert 'not supported' in results.failures[0].exc_info[1].message 02/26 19:07:27.058 INFO |run_chromeos_tests:0052| AttributeError: 'NoneType' object has no attribute 'exc_info'
,
Feb 27 2018
,
Feb 27 2018
+ nednguyen@ from telemetry team.
,
Feb 27 2018
I think this is related to Ethan's work recently
,
Feb 27 2018
Hm, indeed it is. Ned, those skpicture_printer_unittests should run on the Chromium CQ, right? So why shouldn't this have blocked the Catapult roll? In any case, I've created a revert here: https://chromium-review.googlesource.com/c/catapult/+/939922
,
Feb 27 2018
,
Feb 27 2018
Yikes, answered my own question: there's a conditional assert in the test in question. https://cs.chromium.org/chromium/src/tools/perf/measurements/skpicture_printer_unittest.py?q=skpicture_printer_&sq=package:chromium&l=31 Anyway, this will be fixed once the revert lands and rolls.
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea3fa297a1515f03b7100026aaf2fc7a132694fd commit ea3fa297a1515f03b7100026aaf2fc7a132694fd Author: Ethan Kuefner <eakuefner@chromium.org> Date: Wed Feb 28 01:16:17 2018 [Perf] Disable another skpicture_printer unit test on Chrome OS Found another one of these; should be the last one. TBR=nednguyen Bug: 816962 Change-Id: Ib6f771027e58724673e0d4aa4b7e06a97d921748 Reviewed-on: https://chromium-review.googlesource.com/940263 Reviewed-by: Ethan Kuefner <eakuefner@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#539613} [modify] https://crrev.com/ea3fa297a1515f03b7100026aaf2fc7a132694fd/tools/perf/measurements/multipage_skpicture_printer_unittest.py
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bce487d69673cad477bbc3818ec567e8df1d8269 commit bce487d69673cad477bbc3818ec567e8df1d8269 Author: Ethan Kuefner <eakuefner@chromium.org> Date: Wed Feb 28 02:17:21 2018 [Perf] Disable skpicture_printer unit test on cros Refactoring to remove PageTestResults.failures revealed that this unit test does not and should not pass on ChromeOS. This CL updates the logic to just outright disable the test on ChromeOS rather than using a flaky assert. Bug: 816962 Change-Id: Ifa31007f14f4281568a6e74d73513711fee1587e Reviewed-on: https://chromium-review.googlesource.com/939728 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#539658} [modify] https://crrev.com/bce487d69673cad477bbc3818ec567e8df1d8269/tools/perf/measurements/skpicture_printer_unittest.py
,
Feb 28 2018
,
Feb 28 2018
This is fixed, and it looks like recent builds on this builder are green. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by osh...@chromium.org
, Feb 27 2018Components: Infra>Client>ChromeOS Tests>Telemetry
Labels: -Pri-2 OS-Chrome Pri-1