New issue
Advanced search Search tips

Issue 816951 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
weiliangc@chromium.org
enne@chromium.org
ccameron@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 816947
Blocking:
issue 822915



Sign in to add a comment

Clean up filter related code in direct renderers

Project Member Reported by weiliangc@chromium.org, Feb 27 2018 
Tasks includes:
- merge code path of background filter and filter
- share code of generating SkImageFilter between different renderers
- build map of SkImageFilter instead of map of cc::FilterOperations

Comment 1 by weiliangc@chromium.org, Feb 27 2018

Blockedon: 816947
Cc: ccameron@chromium.org
For trying to use SkImageFilter, one problem is that CA Layer Overlay processing takes into account the individual Filter Operations, which is hard to access with SkImageFilter.

For CA Layer overlay we could just use the list of render pass and the filters they own if all render passes are referenced by render pass draw quad, which is not guaranteed right now. So blocking this on that.

Comment 2 by weiliangc@chromium.org, Feb 27 2018 

We want to use SkImageFilter since in direct renderers that is how we apply filters, but we have duplicate code of "get FilterOperations from map, build into PaintFilter, get the private SkImageFilter"

Comment 3 by weiliangc@chromium.org, Mar 16 2018

Blocking: 822915
►

Sign in to add a comment