New issue
Advanced search Search tips

Issue 816935 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 715640



Sign in to add a comment

S13nServiceWorker: rename URLLoader classes for consistency

Project Member Reported by falken@chromium.org, Feb 27 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7514e441317c18910ef6cca47c7967a0b656bdaf

commit 7514e441317c18910ef6cca47c7967a0b656bdaf
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Feb 28 01:32:58 2018

service worker: Rename the URLLoader classes for consistency/accuracy.

ServiceWorkerURLLoaderJob -> ServiceWorkerNavigationLoader
ServiceWorkerSubresourceLoader -> ServiceWorkerSubresourceLoader
ServiceWorkerScriptURLLoader -> ServiceWorkerNewScriptLoader
ServiceWorkerInstalledScriptLoader -> ServiceWorkerInstalledScriptLoader

This change is largely mechanical but some documentation is modified
and some additional renames are made.

Bug:  816935 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia89dd1499cde4931c91e8c169ad594ebb19c5980
Reviewed-on: https://chromium-review.googlesource.com/939323
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539628}
[modify] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/BUILD.gn
[modify] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_installed_script_loader.h
[rename] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_navigation_loader.cc
[rename] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_navigation_loader.h
[rename] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[rename] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_new_script_loader.cc
[rename] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_new_script_loader.h
[rename] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_new_script_loader_unittest.cc
[modify] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_provider_host.cc
[rename] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_script_loader_factory.cc
[rename] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_script_loader_factory.h
[modify] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_url_job_wrapper.cc
[modify] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_url_job_wrapper.h
[modify] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/common/service_worker/service_worker_loader_helpers.h
[modify] https://crrev.com/7514e441317c18910ef6cca47c7967a0b656bdaf/content/test/BUILD.gn

Labels: M-66
Status: Fixed (was: Started)

Sign in to add a comment