New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 816923 link

Starred by 1 user
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Mar 2018
Cc:
█ sindhu.chelamcherla@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Buttons text not localized in "save as" GTK dialog

Reported by olivier....@canonical.com, Feb 27 2018 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/65.0.3325.88 Chrome/65.0.3325.88 Safari/537.36

Steps to reproduce the problem:
0. Run chrome with LANG ≠ en
1. Browse to e.g. https://www.kernel.org/
2. Right-click on a link to a tarball and choose "save as"
3. Notice the text of the "Cancel" and "Save" buttons is not localized, whereas the rest of the dialog is

What is the expected behavior?
The text on the Cancel and Save buttons is localized.

What went wrong?
The text is not localized, resulting in the dialog showing a mix of the user's preferred language, and English.

Did this work before? N/A 

Chrome version: 64.0.3282.186  Channel: stable
OS Version: Ubuntu 18.04
Flash Version: 

Other applications (e.g. gedit) are not affected, so this seems chrom{e,ium}-specific.
chrome-save-as-dialog.png
38.2 KB View Download

Comment 1 by susan.boorgula@chromium.org, Feb 27 2018

Labels: Needs-Triage-M64

Comment 2 by sindhu.chelamcherla@chromium.org, Mar 2 2018

Cc: sindhu.chelamcherla@chromium.org
Components: -UI UI>Accessibility
Labels: hasbisect-per-revision Triaged-ET M-64 FoundIn-65 FoundIn-64 Target-65 Target-64
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on reported version 64.0.3282.186 and on latest beta 65.0.3325.88 on Ubuntu 17.10 using steps mentioned in comment#0. But issue is fixed in latest canary 66.0.3358.0. Hence providing reverse bisect info.

Last Bad Build: 66.0.3335.0
First Good Build: 66.0.3336.0

You are probably looking for a change made after 533378 (known good), but no later than 533385 (first known bad).
CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/cc2d336ed7196d3351484a4e06a83208d5ec5ca6..8e82a32d4ce2c283e9e2007cdeb00b848af325db

Probably fixed by https://chromium-review.googlesource.com/895864.

@ thomasanderson: Could you please let us know that this require any merge to M-64 or M-65? Adding RB-Stable for M-64. Please remove if not the case.

Thanks!

Comment 3 by thomasanderson@chromium.org, Mar 2 2018

Status: Fixed (was: Assigned)
Yes, it was fixed by that CL.  However, this is a non-regression issue so I don't think a merge is necessary.
►

Sign in to add a comment