New issue
Advanced search Search tips

Issue 816866 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android System WebView filed

Reported by ahmedham...@gmail.com, Feb 27 2018 

THIS TEMPLATE IS FOR FILING BUGS ON THE ANDROID SYSTEM WEBVIEW. GENERAL WEB
BUGS SHOULD BE FILED USING A DIFFERENT TEMPLATE!

Device name:
Android version:
WebView version (from system settings -> Apps -> Android System WebView):
Application:
Application version:
Android System WebView)
URLs (if applicable):



Steps to reproduce:
(1)
(2)
(3)

Expected result:


Actual result:

Comment 1 by ntfschr@chromium.org, Feb 27 2018

Status: WontFix (was: Unconfirmed)
This isn't enough information for us to diagnose this. If you have a real bug, please file a new report completely filling out the template.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71c6ed584e76497182cb00cdb782d31bf09a5c00

commit 71c6ed584e76497182cb00cdb782d31bf09a5c00
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Mon Jul 16 11:41:43 2018

[Sync::USS] Commit local bookmark moves and reorders

This CL implement committing local bookmark moves and reorders.
It also adds the positions information to the update method
of the tracker.

Bug:  816866 
Change-Id: Ie8747aeedcba7ad06f15431b7cec7f3384331e62
Reviewed-on: https://chromium-review.googlesource.com/1136540
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575226}
[modify] https://crrev.com/71c6ed584e76497182cb00cdb782d31bf09a5c00/components/sync_bookmarks/bookmark_local_changes_builder.cc
[modify] https://crrev.com/71c6ed584e76497182cb00cdb782d31bf09a5c00/components/sync_bookmarks/bookmark_model_observer_impl.cc
[modify] https://crrev.com/71c6ed584e76497182cb00cdb782d31bf09a5c00/components/sync_bookmarks/bookmark_model_observer_impl_unittest.cc
[modify] https://crrev.com/71c6ed584e76497182cb00cdb782d31bf09a5c00/components/sync_bookmarks/bookmark_remote_updates_handler.cc
[modify] https://crrev.com/71c6ed584e76497182cb00cdb782d31bf09a5c00/components/sync_bookmarks/synced_bookmark_tracker.cc
[modify] https://crrev.com/71c6ed584e76497182cb00cdb782d31bf09a5c00/components/sync_bookmarks/synced_bookmark_tracker.h

Comment 3 by mamir@chromium.org, Jul 18 

Comment#2 is here by mistake.
The mentioned revision was supposed to refer to this bug instead crbug.com/516866
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d283c423c52425b7c9c2f49527e160f09afa4176

commit d283c423c52425b7c9c2f49527e160f09afa4176
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Wed Nov 28 15:43:32 2018

[Sync::USS] Fix Bookmarks PersistProgressMarkerOnRestart test for USS

The test PersistProgressMarkerOnRestart used to fail for USS Bookmarks
because the metadata weren't persisted properly.

This CL makes sure that the processor would outlive the bookmark model
such that the metadata is available at the time when the model is
getting destructed and persisted on disk.

Bug:  816866 
Change-Id: Ief259bd75ee66a6f9bb1dd70fc2ef6a446ebbd7a
Reviewed-on: https://chromium-review.googlesource.com/c/1349314
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611703}
[modify] https://crrev.com/d283c423c52425b7c9c2f49527e160f09afa4176/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc
[modify] https://crrev.com/d283c423c52425b7c9c2f49527e160f09afa4176/components/sync_bookmarks/bookmark_model_observer_impl.cc
[modify] https://crrev.com/d283c423c52425b7c9c2f49527e160f09afa4176/components/sync_bookmarks/bookmark_model_observer_impl.h
[modify] https://crrev.com/d283c423c52425b7c9c2f49527e160f09afa4176/components/sync_bookmarks/bookmark_model_observer_impl_unittest.cc
[modify] https://crrev.com/d283c423c52425b7c9c2f49527e160f09afa4176/components/sync_bookmarks/bookmark_model_type_processor.cc
[modify] https://crrev.com/d283c423c52425b7c9c2f49527e160f09afa4176/components/sync_bookmarks/bookmark_model_type_processor.h
[modify] https://crrev.com/d283c423c52425b7c9c2f49527e160f09afa4176/components/sync_bookmarks/bookmark_sync_service.cc
[modify] https://crrev.com/d283c423c52425b7c9c2f49527e160f09afa4176/components/sync_bookmarks/bookmark_sync_service.h
►

Sign in to add a comment