New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816851 link

Starred by 2 users

Issue metadata

Status: Assigned
Merged: issue 827953
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Focus indicator vanishes after clicking on 'Enter' when focus is on 'Show password' in 'Join Wi-Fi network'

Project Member Reported by mmanchala@chromium.org, Feb 27 2018

Issue description

Chrome Version:  66.0.3355.0/10441.0.0 dev-channel Daisy,Reks and Kip
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen click on 'Let's go' which navigates to 'Connect to network' screen
(2)Now select required Wi-Fi network -> 'Join Wi-Fi network' overlay is seen and observe for default cursor in 'Password' field -> Press 'Tab' button until focus reaches 'Show password' option -> click 'Enter'(Now 'Hide password' option is seen)
(3)Observe Tab focus vanishes and again on pressing 'Tab' focus is on 'CANCEL' 
(Please refer video)

Expected: Tab focus should not get vanish after clicking on 'Enter' when focus is on 'Show password' option i.e. Tab focus should be on 'Hide password' option
Actual: Instead Tab focus vanishes from 'Show password' option

This is Regression Issue as same is working fine in M-64

@stevenjb: Please confirm the issue

Note: Issue is also seen on M-65
 
Actual_TabFocus.mp4
11.1 MB View Download
Attaching Expected video for reference
Expected_TabFocus.mp4
15.5 MB Download
Labels: -Pri-1 Pri-2
Labels: -Pri-2 -M-66 M-67 Pri-3
Labels: -M-67 M-68
Labels: -M-68 M-69
Mergedinto: 827953
Status: Duplicate (was: Assigned)
Status: Assigned (was: Duplicate)
C#6>

Able to reproduce the Issue on latest M-69 69.0.3464.0/10800.0.0 dev-channel Kip.

Repro Steps:

(1)In 'Connect to network' screen select required Wi-Fi network
(2)Now 'Join Wi-Fi network' overlay is seen -> observe default cursor is at 'Password' field -> Press 'Tab' button until focus reaches 'Show password' option -> click 'Enter' from keyboard(Now 'Hide password' option is seen)
(3)Observe Tab focus vanishes on  'Hide password' option and again on pressing 'Tab' focus is on 'CANCEL' button
(Please refer 'Actual_NoFocusOn69.0.3464.0' video)

Note:  issue 827953  is seen fixed on latest M-69 69.0.3464.0/10800.0.0 
(Please refer '827953FixedOn69.0.3464.0' video )

Reopening Issue for confirmation

Thanks..!!
Actual_NoFocusOn69.0.3464.0.mp4
12.0 MB View Download
827953FixedOn69.0.3464.0.mp4
12.1 MB View Download
Summary: Focus indicator vanishes after clicking on 'Enter' when focus is on 'Show password' in 'Join Wi-Fi network' (was: Regression : Tab focus vanishes after clicking on 'Enter' when focus is on 'Show password' in 'Join Wi-Fi network' overlay)
Oh, I see. The description was confusing. The focus *indicator* disappears, but focus remains on the button.

This is new UI since 64 so it's not exactly a regression. It's a problem with paper-icon-button-light, it just isn't used this way very often.

Cc: steve...@chromium.org dpa...@chromium.org
Labels: -M-69
Owner: hcarmona@chromium.org
hcarmona@, any thoughts? Here is the html snippet for the cr-input with indicator:

    <cr-input id="input" label="[[label]]" value="{{value}}"
        disabled="[[disabled]]" type="[[getInputType_(showPassword)]]"
        on-keypress="onInputKeypress_">
      <paper-icon-button-light id="icon" slot="suffix"
          class$="[[getIconClass_(showPassword)]]">
        <button on-tap="onShowPasswordTap_"
            title="[[getShowPasswordTitle_(showPassword)]]">
        </button>
      </paper-icon-button-light>
    </cr-input>

Any interaction with the <button> causes the focus indicator to disappear. It looks like there is a ripple effect when the button is toggled, I suspect that may be the problem?

Labels: Hotlist-OOBE-polish

Sign in to add a comment