The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/385ed792cd8fc43478fdf7ff320daf24c6de5cc1

commit 385ed792cd8fc43478fdf7ff320daf24c6de5cc1
Author: Benoit Lize <lizeb@chromium.org>
Date: Thu Mar 01 18:49:05 2018

customtabs: Add a detached request mechanism for leapfrog.

This CL adds a new class DetachedResourceRequest intended to be used from
CustomTabs. When an intent is processed, a calling app can trigger a parallel
request proceeding in the background.

This is only the native implemenation, based on SimpleURLLoader. As such, since
this feature is only triggered from Java code, there is no caller in chrome/
yet, only tests.

Change-Id: I8a8d6bdca6ff65554769c3f0344e23dc2dcaf43b
Bug:  816837 
Reviewed-on: https://chromium-review.googlesource.com/934271
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540231}
[modify] https://crrev.com/385ed792cd8fc43478fdf7ff320daf24c6de5cc1/chrome/browser/BUILD.gn
[add] https://crrev.com/385ed792cd8fc43478fdf7ff320daf24c6de5cc1/chrome/browser/android/customtabs/detached_resource_request.cc
[add] https://crrev.com/385ed792cd8fc43478fdf7ff320daf24c6de5cc1/chrome/browser/android/customtabs/detached_resource_request.h
[add] https://crrev.com/385ed792cd8fc43478fdf7ff320daf24c6de5cc1/chrome/browser/android/customtabs/detached_resource_request_unittest.cc
[modify] https://crrev.com/385ed792cd8fc43478fdf7ff320daf24c6de5cc1/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/8ae4b3c20c965f5362012ea181c3f816d184eedb

commit 8ae4b3c20c965f5362012ea181c3f816d184eedb
Author: Benoît Lizé <lizeb@google.com>
Date: Tue Mar 06 12:44:23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29c2b4940d0209dfdade5b0cf0af0590608b67d1

commit 29c2b4940d0209dfdade5b0cf0af0590608b67d1
Author: Benoit Lize <lizeb@chromium.org>
Date: Tue Mar 06 18:14:42 2018

customtabs: Make detached resource request accessible from Java.

Adds the JNI part of detached resource request, along with the origin
verification. Also adds a disabled by default feature for parallel
resource requests.

Bug:  816837 
Change-Id: I1eaa14040d399612a4f7f19f2488c30e42ddd9df
Reviewed-on: https://chromium-review.googlesource.com/950862
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541148}
[modify] https://crrev.com/29c2b4940d0209dfdade5b0cf0af0590608b67d1/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/29c2b4940d0209dfdade5b0cf0af0590608b67d1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/29c2b4940d0209dfdade5b0cf0af0590608b67d1/chrome/android/java_sources.gni
[add] https://crrev.com/29c2b4940d0209dfdade5b0cf0af0590608b67d1/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/DetachedResourceRequestTest.java
[modify] https://crrev.com/29c2b4940d0209dfdade5b0cf0af0590608b67d1/chrome/browser/BUILD.gn
[modify] https://crrev.com/29c2b4940d0209dfdade5b0cf0af0590608b67d1/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/29c2b4940d0209dfdade5b0cf0af0590608b67d1/chrome/browser/android/chrome_feature_list.h
[add] https://crrev.com/29c2b4940d0209dfdade5b0cf0af0590608b67d1/chrome/browser/android/customtabs/detached_resource_request_android.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6402e8cbceaf038bc8342816050848de0aa8c9f3

commit 6402e8cbceaf038bc8342816050848de0aa8c9f3
Author: Benoit Lize <lizeb@chromium.org>
Date: Fri Mar 09 14:54:24 2018

customtabs: More tests for Leapfrog.

This CL adds two types of tests:
- An End-to-End (Java + native) test that a cookie can be set.
- Third party cookie blocking tests, which is not easily doable from
  native.

Bug:  816837 
Change-Id: I713b9c00689edae9944bf10bb92bb805ffa60746
Reviewed-on: https://chromium-review.googlesource.com/955582
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542106}
[modify] https://crrev.com/6402e8cbceaf038bc8342816050848de0aa8c9f3/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/DetachedResourceRequestTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/058d35daa23127e7209648152fc43082cf3bbd38

commit 058d35daa23127e7209648152fc43082cf3bbd38
Author: Benoit Lize <lizeb@chromium.org>
Date: Tue Mar 13 12:03:06 2018

customtabs: Add a client callback for warmup completion.

This CL adds a new "extraCallback()" callback to notify a client that
the warmup() sequence is done.
It also converts tests to this method, vs the previous custom callback
runnable, and cleans up a tiny bit some tests.

Bug:  816837 
Change-Id: I8a5f432839be8d0394b03afb6d3ad587adbda6eb
Reviewed-on: https://chromium-review.googlesource.com/957736
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542772}
[modify] https://crrev.com/058d35daa23127e7209648152fc43082cf3bbd38/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
[modify] https://crrev.com/058d35daa23127e7209648152fc43082cf3bbd38/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/058d35daa23127e7209648152fc43082cf3bbd38/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/058d35daa23127e7209648152fc43082cf3bbd38/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/058d35daa23127e7209648152fc43082cf3bbd38/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsTestUtils.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1989515c3735380c930bf7de65786ef16fa83741

commit 1989515c3735380c930bf7de65786ef16fa83741
Author: Benoit Lize <lizeb@chromium.org>
Date: Wed Mar 14 17:55:01 2018

customtabs: Add CustomTabs APIs for detached parallel requests.

This CL adds the CustomTabs "client" APIs for parallel request:
- Enable and query parallel request state
- Get the URL and requested origin from the Intent

Bug:  816837 
Change-Id: I6c5cc86453a941f08f118be6229bf3a2c497d344
Reviewed-on: https://chromium-review.googlesource.com/962761
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543122}
[modify] https://crrev.com/1989515c3735380c930bf7de65786ef16fa83741/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
[modify] https://crrev.com/1989515c3735380c930bf7de65786ef16fa83741/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/1989515c3735380c930bf7de65786ef16fa83741/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/1989515c3735380c930bf7de65786ef16fa83741/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/DetachedResourceRequestTest.java

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/e2e78eddec2ebfe289b3a45344f3567fa6131749

commit e2e78eddec2ebfe289b3a45344f3567fa6131749
Author: Benoît Lizé <lizeb@google.com>
Date: Thu Mar 15 14:18:12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed6545e50cbac55e68ea36df0150ce6d4ea18c7a

commit ed6545e50cbac55e68ea36df0150ce6d4ea18c7a
Author: Benoit Lize <lizeb@chromium.org>
Date: Fri Mar 16 12:52:00 2018

customtabs: Record detached requests duration and final status.

Bug:  816837 
Change-Id: Ic31994e78c18d35fec707746973658843851e759
Reviewed-on: https://chromium-review.googlesource.com/962783
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543676}
[modify] https://crrev.com/ed6545e50cbac55e68ea36df0150ce6d4ea18c7a/chrome/browser/android/customtabs/detached_resource_request.cc
[modify] https://crrev.com/ed6545e50cbac55e68ea36df0150ce6d4ea18c7a/chrome/browser/android/customtabs/detached_resource_request.h
[modify] https://crrev.com/ed6545e50cbac55e68ea36df0150ce6d4ea18c7a/chrome/browser/android/customtabs/detached_resource_request_unittest.cc
[modify] https://crrev.com/ed6545e50cbac55e68ea36df0150ce6d4ea18c7a/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a855a4bd0a31d5e6a3c94dec7ab14cf39ac047f9

commit a855a4bd0a31d5e6a3c94dec7ab14cf39ac047f9
Author: Benoit Lize <lizeb@chromium.org>
Date: Mon Mar 19 15:32:06 2018

customtabs: Custom referrer policy for detached requests.

Allows the client to set a referrer policy for the parallel request.

Bug:  816837 
Change-Id: I0a7525fa90079f5dd971e3bfe5565a0fb3c3b10b
Reviewed-on: https://chromium-review.googlesource.com/966443
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544039}
[modify] https://crrev.com/a855a4bd0a31d5e6a3c94dec7ab14cf39ac047f9/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/a855a4bd0a31d5e6a3c94dec7ab14cf39ac047f9/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/DetachedResourceRequestTest.java
[modify] https://crrev.com/a855a4bd0a31d5e6a3c94dec7ab14cf39ac047f9/chrome/browser/android/customtabs/detached_resource_request.cc
[modify] https://crrev.com/a855a4bd0a31d5e6a3c94dec7ab14cf39ac047f9/chrome/browser/android/customtabs/detached_resource_request.h
[modify] https://crrev.com/a855a4bd0a31d5e6a3c94dec7ab14cf39ac047f9/chrome/browser/android/customtabs/detached_resource_request_android.cc
[modify] https://crrev.com/a855a4bd0a31d5e6a3c94dec7ab14cf39ac047f9/chrome/browser/android/customtabs/detached_resource_request_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b4fc0c7a8dba4c9f2b4b1b473069675caab6132

commit 8b4fc0c7a8dba4c9f2b4b1b473069675caab6132
Author: Benoit Lize <lizeb@chromium.org>
Date: Tue Mar 20 14:29:56 2018

customtabs: Test that cross-origin detached requests can set cookies.

Adds a test for detached requests with cross-origin server-side
redirects. Checks that both the initial and the following origin can set
cookies.

Bug:  816837 
Change-Id: I98fd6ac0b617de20dfe2e074ddcbd80bb94e4bb4
Reviewed-on: https://chromium-review.googlesource.com/970643
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544353}
[modify] https://crrev.com/8b4fc0c7a8dba4c9f2b4b1b473069675caab6132/chrome/browser/android/customtabs/detached_resource_request_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98265775fbe531d3b97d144163b001d0516bcdda

commit 98265775fbe531d3b97d144163b001d0516bcdda
Author: Benoit Lize <lizeb@chromium.org>
Date: Wed Mar 21 17:58:37 2018

customtabs: Count redirects for detached requests.

Bug:  816837 
Change-Id: Ic2d2b600c5ab2483f85c6be1447fd091c8aec1fe
Reviewed-on: https://chromium-review.googlesource.com/971222
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544766}
[modify] https://crrev.com/98265775fbe531d3b97d144163b001d0516bcdda/chrome/browser/android/customtabs/detached_resource_request.cc
[modify] https://crrev.com/98265775fbe531d3b97d144163b001d0516bcdda/chrome/browser/android/customtabs/detached_resource_request.h
[modify] https://crrev.com/98265775fbe531d3b97d144163b001d0516bcdda/chrome/browser/android/customtabs/detached_resource_request_unittest.cc
[modify] https://crrev.com/98265775fbe531d3b97d144163b001d0516bcdda/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b574931e92b0a101e6201ee4dcab958f32721c0d

commit b574931e92b0a101e6201ee4dcab958f32721c0d
Author: Benoit Lize <lizeb@chromium.org>
Date: Fri Mar 23 10:49:45 2018

customtabs: Check that detached requests cannot be used to avoid SafeBrowsing.

Detached resource requests don't go through SafeBrowsing during the
initial fetch. This ensures that the checks are done when the cached
response is about to be used in a page.

Bug:  816837 ,  824209 
Change-Id: Ibac43bff9f3dfb211f1f05f8fabfda1d556e93f0
Reviewed-on: https://chromium-review.googlesource.com/975562
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545400}
[modify] https://crrev.com/b574931e92b0a101e6201ee4dcab958f32721c0d/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/DetachedResourceRequestTest.java
[modify] https://crrev.com/b574931e92b0a101e6201ee4dcab958f32721c0d/chrome/browser/android/customtabs/detached_resource_request.h
[modify] https://crrev.com/b574931e92b0a101e6201ee4dcab958f32721c0d/chrome/browser/android/customtabs/detached_resource_request_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8187bea4179f5907befb9f4d2da2a62e9f526cee

commit 8187bea4179f5907befb9f4d2da2a62e9f526cee
Author: Benoit Lize <lizeb@chromium.org>
Date: Thu Mar 29 18:32:04 2018

customtabs: Detailed logging for parallel resource requests.

Bug:  816837 
Change-Id: I0547480ff0ba5eca7676e1b4543070a8a3206bb0
Reviewed-on: https://chromium-review.googlesource.com/984533
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546864}
[modify] https://crrev.com/8187bea4179f5907befb9f4d2da2a62e9f526cee/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/8187bea4179f5907befb9f4d2da2a62e9f526cee/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/DetachedResourceRequestTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2db9dade194a53f17c379546c872a4d1bffa0b0a

commit 2db9dade194a53f17c379546c872a4d1bffa0b0a
Author: Benoit Lize <lizeb@chromium.org>
Date: Mon Apr 09 10:52:44 2018

customtabs: Record the initial status of parallel requests.

Adds a UMA histogram for parallel requests. Records whether the feature
was requested, and whether the request started. In case of failure,
records the reason.

Bug:  816837 
Change-Id: I9e32abc609bed426113a28b7701d1462466e77b0
Reviewed-on: https://chromium-review.googlesource.com/993052
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549145}
[modify] https://crrev.com/2db9dade194a53f17c379546c872a4d1bffa0b0a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/2db9dade194a53f17c379546c872a4d1bffa0b0a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/DetachedResourceRequestTest.java
[modify] https://crrev.com/2db9dade194a53f17c379546c872a4d1bffa0b0a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2db9dade194a53f17c379546c872a4d1bffa0b0a/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a338de2784533517e66813af35c859b16019650

commit 3a338de2784533517e66813af35c859b16019650
Author: Benoit Lize <lizeb@chromium.org>
Date: Tue Apr 17 15:55:59 2018

customtabs: Enable detached requests by default.

Feature has been approved to launch in M67, see
https://crbug.com/817854.

Bug:  816837 
Change-Id: Ibe2699ad633b3c9ae01cbfff91293a6ab7a77859
Reviewed-on: https://chromium-review.googlesource.com/1013487
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551349}
[modify] https://crrev.com/3a338de2784533517e66813af35c859b16019650/chrome/browser/android/chrome_feature_list.cc

Requesting a merge to M67 for the commit above.
Rationale: 1 line change to enable the feature after launch approval.

Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d05fc9e26680ca3f45f244cdaca322b94b7e5dae

commit d05fc9e26680ca3f45f244cdaca322b94b7e5dae
Author: Benoit Lize <lizeb@chromium.org>
Date: Sat Apr 21 00:13:47 2018

customtabs: Enable detached requests by default.

Feature has been approved to launch in M67, see
https://crbug.com/817854.

TBR=lizeb@chromium.org

(cherry picked from commit 3a338de2784533517e66813af35c859b16019650)

Bug:  816837 
Change-Id: Ibe2699ad633b3c9ae01cbfff91293a6ab7a77859
Reviewed-on: https://chromium-review.googlesource.com/1013487
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551349}
Reviewed-on: https://chromium-review.googlesource.com/1023230
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#190}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/d05fc9e26680ca3f45f244cdaca322b94b7e5dae/chrome/browser/android/chrome_feature_list.cc

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/49a9018fc5d6d9f1045d36a2745b1f436442f7ca

commit 49a9018fc5d6d9f1045d36a2745b1f436442f7ca
Author: Benoît Lizé <lizeb@google.com>
Date: Mon Apr 23 13:23:57 2018

Requesting a merge for the commit above to M67.
Rationale: Low-risk simple change to whitelist an application to use the feature (approved for 67, see commit message).

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/3cbff39ced24d2b3dbadcb0d855d5689c5044755

commit 3cbff39ced24d2b3dbadcb0d855d5689c5044755
Author: Benoît Lizé <lizeb@google.com>
Date: Wed Apr 25 11:30:56 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4161a1adee9e4d15c11f62ed5f213213a3afd4e

commit e4161a1adee9e4d15c11f62ed5f213213a3afd4e
Author: Benoit Lize <lizeb@chromium.org>
Date: Tue Jun 05 08:32:25 2018

customtabs: Record the final status of detached requests.

Records the net::{OK,ERROR_*} status of a detached request at completion
time, to get more details on the failure cases.

Bug:  816837 
Change-Id: Iea8e6b4a541cd20e54848f3cb6d8fa7f0348ffdc
Reviewed-on: https://chromium-review.googlesource.com/1084932
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564406}
[modify] https://crrev.com/e4161a1adee9e4d15c11f62ed5f213213a3afd4e/chrome/browser/android/customtabs/detached_resource_request.cc
[modify] https://crrev.com/e4161a1adee9e4d15c11f62ed5f213213a3afd4e/chrome/browser/android/customtabs/detached_resource_request_unittest.cc
[modify] https://crrev.com/e4161a1adee9e4d15c11f62ed5f213213a3afd4e/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e4d618d4238f2f9e640e47982476d1a2b6449d3

commit 7e4d618d4238f2f9e640e47982476d1a2b6449d3
Author: Benoit Lize <lizeb@chromium.org>
Date: Mon Jun 11 13:09:51 2018

customtabs: report the correct value for a UMA histogram.

CustomTabs.DetachedResourceRequest.FinalStatus enum contains labels for
-net::ERR_*, not the direct value. This causes reporting in UMA to be
incorrectly labeled.

Bug:  816837 , 851399
Change-Id: I7febe0ec98f9ae7b028f36af9ff4a40cc938191d
Reviewed-on: https://chromium-review.googlesource.com/1095178
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565982}
[modify] https://crrev.com/7e4d618d4238f2f9e640e47982476d1a2b6449d3/chrome/browser/android/customtabs/detached_resource_request.cc
[modify] https://crrev.com/7e4d618d4238f2f9e640e47982476d1a2b6449d3/chrome/browser/android/customtabs/detached_resource_request_unittest.cc

Requesting a merge to M68 for #25.

- Rationale: required to investigate failures with an on-going experiment, need to go to Beta to have enough data.
- Risk: This is only adding a histogram, very low risk.

Thanks!

This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cab24eb2fcc888cdc84885eec75ed2b6064ff5e2

commit cab24eb2fcc888cdc84885eec75ed2b6064ff5e2
Author: Benoit Lize <lizeb@chromium.org>
Date: Tue Jun 19 11:31:15 2018

customtabs: Record the final status of detached requests.

Records the net::{OK,ERROR_*} status of a detached request at completion
time, to get more details on the failure cases.

TBR=bauerb@chromium.org, holte@chromium.org

(cherry picked from commit e4161a1adee9e4d15c11f62ed5f213213a3afd4e)

Bug:  816837 
Change-Id: Iea8e6b4a541cd20e54848f3cb6d8fa7f0348ffdc
Reviewed-on: https://chromium-review.googlesource.com/1084932
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564406}
Reviewed-on: https://chromium-review.googlesource.com/1105836
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#442}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/cab24eb2fcc888cdc84885eec75ed2b6064ff5e2/chrome/browser/android/customtabs/detached_resource_request.cc
[modify] https://crrev.com/cab24eb2fcc888cdc84885eec75ed2b6064ff5e2/chrome/browser/android/customtabs/detached_resource_request_unittest.cc
[modify] https://crrev.com/cab24eb2fcc888cdc84885eec75ed2b6064ff5e2/tools/metrics/histograms/histograms.xml