New issue
Advanced search Search tips

Issue 816828 link

Starred by 1 user
Status: Fixed
Owner:
dtseng@chromium.org
Closed: Mar 2018
Cc:
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-02-27
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Location of on-screen keyboard is wrong

Project Member Reported by dtseng@chromium.org, Feb 27 2018 
- enable on-screen keyboard (e.g. status tray->accessibility->on screen keyboard enable)
- click show on screen keyboard button
- focus a text field
- query for the location of any key e.g. p

result:
unclipped location is left: 823, top: 97 11x23

expected:
the top should be around 600 or so. I'm touching the key and it's definitely *not* on the top of the screen.

Issues:
- touch typing fails in ChromeVox
- the focus highlight I'm assuming is way off.

Comment 1 by dtseng@chromium.org, Feb 27 2018 

As a further datapoint, one of the ancestor aura Windows is located at left: 0, top: 520 and is 1200x280.

I'm pretty sure the problem lies within  AutomationInternalCustomBindings::ComputeGlobalNodeBounds, where I don't see offset_container_id taken into account. Each AXWindowObjWrapper has its parenting window as an offset container.

Comment 2 by monor...@bugs.chromium.org, Feb 27 2018 

The NextAction date has arrived: 2018-02-27

Comment 3 by dtseng@chromium.org, Feb 27 2018

Owner: dtseng@chromium.org
Actually, I think I see the problem. Location changes never got hooked up to the right event ipc. Since the code was refactored a while back, location changes have a separate ipc message (OnLocationChanged), but the code trying to fire it goes through OnAccessibilityEvent (fired from AxObjCache). Seems like just an oversight. The automation renderer end does the relative bounds offset.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd084da12c96af536a3070e1f84d0b8152d6e757

commit fd084da12c96af536a3070e1f84d0b8152d6e757
Author: David Tseng <dtseng@chromium.org>
Date: Thu Mar 01 04:41:32 2018

Use screen bounds in AXWindowObjWrapper

Bug:  816828 
Test: verify that touch typing works again in ChromeVox
Change-Id: I56e273aeaf225cf38d53efcc7ffff3eca6cf5387
Reviewed-on: https://chromium-review.googlesource.com/940814
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540054}
[modify] https://crrev.com/fd084da12c96af536a3070e1f84d0b8152d6e757/ui/views/accessibility/ax_window_obj_wrapper.cc

Comment 5 by dtseng@chromium.org, Mar 1 2018

Status: fixed (was: Assigned)
►

Sign in to add a comment