Issue metadata
Sign in to add a comment
|
Regression: 'Open PDF in preview' does not get enabled on selecting 'Save as PDF'.
Reported by
aiman.an...@etouch.net,
Feb 27 2018
|
||||||||||||||||||||||
Issue description
Chrome Version: 66.0.3356.0 (Official Build) Revision43318c02bb32c8eb07e9739904d15778d64d3094-refs/heads/master@{#539380} (64 Bit).
OS: Mac(Touchbar 10.13.4).
What steps will reproduce the problem?
1. Launch chrome, open NTP and give Print Command.
2. Change Destination to local printer and again change it to 'Save as PDF'.
3. Observe.
Actual: 'Open PDF in preview' does not get enabled on selecting Save as PDF
Expected: 'Open PDF in preview' should get enabled on selecting Save as PDF
This is a regression issue, broken in M-63 series, Using the per-revision bisect providing the bisect results,
Good Build:63.0.3217.0(Revision:502455)
Bad Build:63.0.3218.0(Revision:502516)
You are probably looking for a change made after 502458 (known good), but no later than 502459 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/535972b3b509dd28b58982b4a150a44435a87956..91afdb650d86071b79d384d03ceef7e0d3dab358
Suspect: https://chromium.googlesource.com/chromium/src/+/91afdb650d86071b79d384d03ceef7e0d3dab358
rbpotter@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: 1. This issue is also seen on M64 Stable(build #64.0.3282.186), M65 Beta(build #64.0.3282.186), M66 Dev(build #66.0.3350.0).
2. Issue is not reproducible on Mac(10.12.6, 10.13.1), Linux(14.04 LTS) and Win(7,8,8.1,10).
Thank You!
,
Feb 27 2018
I can't reproduce this on my Mac with my printers. Looking at the video, I think one needs to have an invalid printer to cause "Open PDF in Preview" to become disabled.
,
Feb 28 2018
Have a candidate fix at https://crrev.com/c/939523 but as noted in comment 2 we are having trouble reproducing this bug to verify it works as intended.
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf8b140ec69dae43c9ea904289381cff2c920883 commit bf8b140ec69dae43c9ea904289381cff2c920883 Author: rbpotter <rbpotter@chromium.org> Date: Thu Mar 01 23:17:44 2018 Fix issue with system dialog and open in preview links Bug: 816826 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I56839874977fb0563b556e198a5252f4d5937ed7 Reviewed-on: https://chromium-review.googlesource.com/941971 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#540335} [modify] https://crrev.com/bf8b140ec69dae43c9ea904289381cff2c920883/chrome/browser/resources/print_preview/print_preview.js
,
Mar 2 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aiman.an...@etouch.net
, Feb 27 2018