New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816814 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocking:
issue 667651



Sign in to add a comment

probe: Verify the number of probed components based on values in device_data

Project Member Reported by yhong@chromium.org, Feb 27 2018

Issue description

Different SKU in same Chromebook project might have different number of components installed.  To allow the user specifies the expected number of components of each category in a more flexible way, we should integrate the verification process with the device_data module.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/476aaad9d899114d81cf53c83038d72b27a4bb6a

commit 476aaad9d899114d81cf53c83038d72b27a4bb6a
Author: Yong Hong <yhong@chromium.org>
Date: Mon Mar 05 12:56:58 2018

pytest/probe: Verify the number of components based on `device_data`.

Different SKU in same Chromebook project might have different number
of components installed.  To allow the user specifies the expected
number of components of each category in a more flexible way, we
should integrate the verification process with the `device_data`
module.

BUG= chromium:816814 
TEST=make test; manually test on DUT

Change-Id: I09c3c1c93dc2d7278930cf5b52f55a9b994050f4
Reviewed-on: https://chromium-review.googlesource.com/938868
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[modify] https://crrev.com/476aaad9d899114d81cf53c83038d72b27a4bb6a/py/tools/deps.conf
[modify] https://crrev.com/476aaad9d899114d81cf53c83038d72b27a4bb6a/py/test/device_data.py
[modify] https://crrev.com/476aaad9d899114d81cf53c83038d72b27a4bb6a/py/test/pytests/probe/probe.py

Comment 2 by yhong@chromium.org, Mar 19 2018

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/1dff314cbdedbf2d87fbb8610ab4f46ad942c41a

commit 1dff314cbdedbf2d87fbb8610ab4f46ad942c41a
Author: Yong Hong <yhong@chromium.org>
Date: Thu Mar 29 14:39:20 2018

shopfloor: Update the spec of the format of device_data in README.

This CL updates `py/shopfloor/README.md` to define the format of
`component` domain of the device data returned from the Chrome OS
Factory Shopfloor Service.

BUG=b:75990339,  chromium:816814 
TEST=None

Change-Id: I9add9a12f841f57bfe288f16e61a383128d91c7b
Reviewed-on: https://chromium-review.googlesource.com/970144
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/1dff314cbdedbf2d87fbb8610ab4f46ad942c41a/py/shopfloor/README.md

Comment 4 by yhong@chromium.org, Mar 30 2018

Blocking: 667651
Project Member

Comment 5 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/02681b19e96465099237d7e6df4ebda39f12e8b6

commit 02681b19e96465099237d7e6df4ebda39f12e8b6
Author: Cheng-Han Yang <chenghan@google.com>
Date: Fri May 04 17:54:50 2018

device_data: Check if device data meets spec.

Device data should only check data type for names starting with
`component.has_`.

BUG= chromium:816814 
TEST=make test; manually test on DUT

Change-Id: I2bb327bcc6eec52e4b1c351998da4d38ee4d92a7
Reviewed-on: https://chromium-review.googlesource.com/1043669
Commit-Ready: Cheng-Han Yang <chenghan@chromium.org>
Tested-by: Cheng-Han Yang <chenghan@chromium.org>
Reviewed-by: Yong Hong <yhong@google.com>

[modify] https://crrev.com/02681b19e96465099237d7e6df4ebda39f12e8b6/py/test/device_data.py

Sign in to add a comment