[css-typed-om] ComputedStylePropertyMap should return computed values. |
||
Issue descriptionComputedStylePropertyMap should return computed values. Most of the time, this is what passing a null layout_object to CSSProperty::CSSValueFromComputedStyle gives, but sometimes it's wrong (e.g. transforms). We should have a separate code path to return the correct computed values for these special cases. Spec: https://drafts.css-houdini.org/css-typed-om-1/#computed-stylepropertymapreadonly-objects
,
Feb 28 2018
For the properties that we are shipping, I think the only case that we can't easily fix is font-style: oblique, which currently computes to italic. I don't think ComputedStyle currently can differentiate the two.
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37888af471588e4821c9ca2edf3ec6decf1b77a8 commit 37888af471588e4821c9ca2edf3ec6decf1b77a8 Author: Darren Shen <shend@chromium.org> Date: Thu Mar 01 19:41:28 2018 [css-typed-om] Fix computed value of an interpolated transform. Previously we did not handle the case of computing the value of an interpolated transform, which occurs when we interpolate between two different transform types containing percentages. The correct result is currently not spec'd [1], so this patch fixes this by just returning "none" in this case. [1] https://github.com/w3c/css-houdini-drafts/issues/425 Bug: 816803 Change-Id: I97c8f6b71f651a8d547fb4cb307121eba7dabdb6 Reviewed-on: https://chromium-review.googlesource.com/942595 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#540258} [add] https://crrev.com/37888af471588e4821c9ca2edf3ec6decf1b77a8/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-interpolated.html [modify] https://crrev.com/37888af471588e4821c9ca2edf3ec6decf1b77a8/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
,
Mar 20 2018
Going to close this bug & open more specific ones. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 28 2018