New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 816802 link

Starred by 1 user
Status: Assigned
Owner:
sgilhuly@chromium.org
Cc:
█ fsam...@chromium.org
sadrul@chromium.org
kylec...@chromium.org
yiyix@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Chrome Viz DevTools

Project Member Reported by yiyix@chromium.org, Feb 27 2018 
This DevTool will allow users to observe elements in Viz Display Compositor, which will be eventually aggregated and shown on the screen. The object of this tool is to help Chrome Devs to track the state of the Compositor Frame Tree, visualizing the content in display compositor and easier to analyze performance gain.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd1e448584de1251e6563c63a9d459e362ca8c23

commit bd1e448584de1251e6563c63a9d459e362ca8c23
Author: Illia Martyniuk <illiam@google.com>
Date: Tue Mar 13 22:02:59 2018

VIZ DevTools: adding the flag to initialize VIZ DevTools

The flag --enable-viz-devtools will be used to initialize Viz DevTools server and
observe Viz Display Compositor objects from the GPU process. Now on creating of the
DevTools server from the browser process we pass the flag we need to search for in
the command line to determine whether to enable devtools or not and a default port
number to run the server on. When we start chrome along with the devtools flag we
can specify the port number we want the server to run on, but it is optional, so
if nothing's specified we pass the default port number to run the server on.
Later the GPU process will also pass its corresponding parameters.

Bug: 816802
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I8f5e461758cf7aa0e575680e659c45232a9fd8e2
Reviewed-on: https://chromium-review.googlesource.com/943247
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#542931}
[modify] https://crrev.com/bd1e448584de1251e6563c63a9d459e362ca8c23/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/bd1e448584de1251e6563c63a9d459e362ca8c23/components/ui_devtools/devtools_server.cc
[modify] https://crrev.com/bd1e448584de1251e6563c63a9d459e362ca8c23/components/ui_devtools/devtools_server.h
[modify] https://crrev.com/bd1e448584de1251e6563c63a9d459e362ca8c23/components/viz/common/switches.cc
[modify] https://crrev.com/bd1e448584de1251e6563c63a9d459e362ca8c23/components/viz/common/switches.h
[modify] https://crrev.com/bd1e448584de1251e6563c63a9d459e362ca8c23/content/browser/gpu/gpu_process_host.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf6cc0659421d90c010dc1278e38efdd4f686038

commit cf6cc0659421d90c010dc1278e38efdd4f686038
Author: Illia Martyniuk <illiam@google.com>
Date: Wed Mar 14 20:28:03 2018

DevTools: Moving enable flag to browser

Moving enable-ui-devtools flag to the browser, so now DevTools
won't carry any host specific information.

Bug: 816802
Change-Id: I9830227660d31803226d8ec469f75f2ce6007712
Reviewed-on: https://chromium-review.googlesource.com/962360
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#543182}
[modify] https://crrev.com/cf6cc0659421d90c010dc1278e38efdd4f686038/chrome/browser/about_flags.cc
[modify] https://crrev.com/cf6cc0659421d90c010dc1278e38efdd4f686038/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/cf6cc0659421d90c010dc1278e38efdd4f686038/chrome/common/chrome_switches.cc
[modify] https://crrev.com/cf6cc0659421d90c010dc1278e38efdd4f686038/chrome/common/chrome_switches.h
[modify] https://crrev.com/cf6cc0659421d90c010dc1278e38efdd4f686038/components/ui_devtools/BUILD.gn
[modify] https://crrev.com/cf6cc0659421d90c010dc1278e38efdd4f686038/components/ui_devtools/devtools_server.cc
[delete] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/ui_devtools/switches.cc
[delete] https://crrev.com/94becc73add51d38cc89649c0186cde7759e4f34/components/ui_devtools/switches.h
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aee1064c67b141f614f5395f0e4bbef53775920e

commit aee1064c67b141f614f5395f0e4bbef53775920e
Author: Illia Martyniuk <illiam@google.com>
Date: Fri Mar 23 00:46:13 2018

Viz: Adding FrameSinkObserver

Adding observer which will be used for updates in Viz DevTools and
potentially other places in the future.

Bug: 816802
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I500e454bdd9c9122785a972d3d1f3886228ecf46
Reviewed-on: https://chromium-review.googlesource.com/972344
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#545314}
[modify] https://crrev.com/aee1064c67b141f614f5395f0e4bbef53775920e/components/viz/service/BUILD.gn
[modify] https://crrev.com/aee1064c67b141f614f5395f0e4bbef53775920e/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/aee1064c67b141f614f5395f0e4bbef53775920e/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[add] https://crrev.com/aee1064c67b141f614f5395f0e4bbef53775920e/components/viz/service/frame_sinks/frame_sink_observer.h
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c690c549d8ada54617474363193cfc2d5de4be41

commit c690c549d8ada54617474363193cfc2d5de4be41
Author: Illia Martyniuk <illiam@google.com>
Date: Mon Mar 26 13:51:35 2018

Viz: Updating FrameSinkObserver

Avoiding unnecessary complexity in FrameSinkObserver. We are interested
in events like creating and destroying FrameSinks which are handled in
"OnCreated...FrameSink" and "OnDestroyed...FrameSink", so we don't need
to use events "OnRegistered...Support" and "OnUnregistered...Support".
These two just give us the unnecessary overhead of handling more events.

Sorry for missing this in previous CL.

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I53eba6a103834cc9d48ced14e013825c3b49027a
Reviewed-on: https://chromium-review.googlesource.com/978374
Commit-Queue: Illia Martyniuk <illiam@google.com>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545776}
[modify] https://crrev.com/c690c549d8ada54617474363193cfc2d5de4be41/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/c690c549d8ada54617474363193cfc2d5de4be41/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/c690c549d8ada54617474363193cfc2d5de4be41/components/viz/service/frame_sinks/frame_sink_observer.h
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64bfcc8887a9799f7e5f0b81a9f3fbc1fdd7e4f2

commit 64bfcc8887a9799f7e5f0b81a9f3fbc1fdd7e4f2
Author: Illia Martyniuk <illiam@google.com>
Date: Fri Mar 30 00:06:05 2018

Aura: Passing page title instead of "DelegatedFrameHost"

We can use more verbose page title instead of "DelegatedFrameHost" to
pass to the SurfaceManager for debugging purposes. It is easier to track
what FrameSink is associated with what Debug Label if these labels are
page titles.

Bug: 816802
Change-Id: If5aa98fc7e9225d2798f85ca21d6ab221c02514b
Reviewed-on: https://chromium-review.googlesource.com/984172
Commit-Queue: Illia Martyniuk <illiam@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547032}
[modify] https://crrev.com/64bfcc8887a9799f7e5f0b81a9f3fbc1fdd7e4f2/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/64bfcc8887a9799f7e5f0b81a9f3fbc1fdd7e4f2/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/64bfcc8887a9799f7e5f0b81a9f3fbc1fdd7e4f2/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/64bfcc8887a9799f7e5f0b81a9f3fbc1fdd7e4f2/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/64bfcc8887a9799f7e5f0b81a9f3fbc1fdd7e4f2/content/browser/web_contents/web_contents_view_aura.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7

commit f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7
Author: Illia Martyniuk <illiam@google.com>
Date: Mon Apr 02 19:26:07 2018

DevTools: Refactoring UI Elements and Agents

Creating common UI Element, Root Element, DOM, CSS and Overlay agents
for UI and Viz DevTools to avoid dependencies. CSS agent contains only
common logic, so there won't be ui-specific or viz-specific CSS Agent.

All the ui_devtools/views/ files are built for aura only. Once we add
Viz logic we want it to work in the same manner but with Viz objects. So
Agents' functionality and the structure of the UIElements must be left
as is. But currently all the agents and ui elements in UI DevTools are
the mix of aura-functionality (like DOMAgent::BuildTreeForWindow) and
non aura-functionality (like DOMAgent::GetDocument). If we just move
all these files to components/ui_devtools (assuming they'll be common
for Viz and Aura) Viz will then have to include aura as a dependency.
So I'm just separating aura-specific functionality (and leave it in
ui_devtools/views) from common functionality which I move to components/
ui_devtools.

Bug: 816802
Change-Id: I3fd3eaca1cd2a7cc8528c12d20979cddfaed994e
Reviewed-on: https://chromium-review.googlesource.com/979135
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#547484}
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/BUILD.gn
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/DEPS
[rename] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/css_agent.cc
[rename] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/css_agent.h
[add] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/dom_agent.cc
[add] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/dom_agent.h
[add] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/overlay_agent.cc
[add] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/overlay_agent.h
[rename] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/root_element.cc
[rename] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/root_element.h
[rename] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/ui_element.cc
[rename] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/ui_element.h
[rename] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/ui_element_delegate.h
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/BUILD.gn
[delete] https://crrev.com/ec9b78051e623b2e136055025cd1ae3bb56e9724/components/ui_devtools/views/dom_agent.cc
[delete] https://crrev.com/ec9b78051e623b2e136055025cd1ae3bb56e9724/components/ui_devtools/views/dom_agent.h
[add] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/dom_agent_aura.cc
[add] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/dom_agent_aura.h
[rename] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/overlay_agent_aura.cc
[rename] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/overlay_agent_aura.h
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/ui_devtools_unittest.cc
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/view_element.cc
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/view_element.h
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/widget_element.cc
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/widget_element.h
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/window_element.cc
[modify] https://crrev.com/f688acd6b7039f7036ec86b7aaa0d43a2a5ccdd7/components/ui_devtools/views/window_element.h
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d22bdd95acd389c555257634a1e74132338b94a9

commit d22bdd95acd389c555257634a1e74132338b94a9
Author: Illia Martyniuk <illiam@google.com>
Date: Thu Apr 05 02:15:21 2018

Viz: Adding methods to track the hierarchy of FrameSinks

Creating a set of RootFrameSinks which will be updated at every
registering/unregistering of support if it's a root support. Also adding
a method to get the children FrameSinkIds by parent. Both of these will
be used to build a FrameSink tree. We intend to track all the FrameSinks
that are created/destroyed, even those that correpond to tooltips,
options menu, etc. Since we create a RootCompositorFrameSink for a
tooltip or the options menu we keep all the RootFrameSinkIds in a set and
insert into this set or erase from the set when RootFrameSink is created
or destroyed respectively.

Adding a method to get a FrameSinkSupport by id. This will be used for
CSS properties and additional attributes (like LastBeginFrameArgs).

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I41a69716a591a7f8c57cd7785a45036730b731c8
Reviewed-on: https://chromium-review.googlesource.com/984035
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#548292}
[modify] https://crrev.com/d22bdd95acd389c555257634a1e74132338b94a9/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/d22bdd95acd389c555257634a1e74132338b94a9/components/viz/service/frame_sinks/frame_sink_manager_impl.h
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d422b5d9ad5ccc632ca5337dc8aacff8106e3ffb

commit d422b5d9ad5ccc632ca5337dc8aacff8106e3ffb
Author: Illia Martyniuk <illiam@google.com>
Date: Mon Apr 09 20:09:19 2018

Viz: Handling the change in hierarchy of surface references

This is called every time the surface reference is added or removed. It
will be used in Viz DevTools to update the tree of surfaces.

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id07fc469a8fd395fac114dafb0d7c15e9809192d
Reviewed-on: https://chromium-review.googlesource.com/998411
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#549253}
[modify] https://crrev.com/d422b5d9ad5ccc632ca5337dc8aacff8106e3ffb/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/d422b5d9ad5ccc632ca5337dc8aacff8106e3ffb/components/viz/service/surfaces/surface_manager.h
[modify] https://crrev.com/d422b5d9ad5ccc632ca5337dc8aacff8106e3ffb/components/viz/service/surfaces/surface_observer.h

Comment 9 by fsam...@chromium.org, Apr 10 2018

Cc: fsam...@chromium.org
Adding self for context.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c777f75ce7cbfda3bc36c441038b2a062136f097

commit c777f75ce7cbfda3bc36c441038b2a062136f097
Author: Illia Martyniuk <illiam@google.com>
Date: Thu Apr 12 06:27:10 2018

Viz: Changing OnRegisteredHierarchy

Moving observer calls a bit up in the code so we don't miss hierarchy
events. We could miss them if |parent_source| is nullptr and we return
from the function earlier than events are sent.
Sorry for not catching this earlier.

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic72e1b1553df6883540c97ff2cead2240fef7c13
Reviewed-on: https://chromium-review.googlesource.com/1008404
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#550048}
[modify] https://crrev.com/c777f75ce7cbfda3bc36c441038b2a062136f097/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61d65e5d81eeeedd102ff8ba0122d098922da1cf

commit 61d65e5d81eeeedd102ff8ba0122d098922da1cf
Author: Illia Martyniuk <illiam@google.com>
Date: Fri Apr 13 23:09:24 2018

VizDevTools: Observing static FrameSink tree

Providing the possibility to track registered FrameSinkIds and created
FrameSinks but without any updates. Since there's no general root of all
FrameSinks we create a dummy root in DevTools and use it as a root of
the FrameSink tree.

Currently presubmit doesn't pass because of the checkdeps violations. It
complains about components/ui_detools/css_agent.h and
components/ui_devtools/devtools_server.h included in viz_main_impl.cc file.

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I0fe43236ca7778668ea55bb5b945bd2526d16091
Reviewed-on: https://chromium-review.googlesource.com/998413
Commit-Queue: Illia Martyniuk <illiam@google.com>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550782}
[modify] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/ui_element.cc
[modify] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/ui_element.h
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/BUILD.gn
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/DEPS
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/dom_agent_viz.cc
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/dom_agent_viz.h
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/frame_sink_element.cc
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/frame_sink_element.h
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/overlay_agent_viz.cc
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/overlay_agent_viz.h
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61d65e5d81eeeedd102ff8ba0122d098922da1cf

commit 61d65e5d81eeeedd102ff8ba0122d098922da1cf
Author: Illia Martyniuk <illiam@google.com>
Date: Fri Apr 13 23:09:24 2018

VizDevTools: Observing static FrameSink tree

Providing the possibility to track registered FrameSinkIds and created
FrameSinks but without any updates. Since there's no general root of all
FrameSinks we create a dummy root in DevTools and use it as a root of
the FrameSink tree.

Currently presubmit doesn't pass because of the checkdeps violations. It
complains about components/ui_detools/css_agent.h and
components/ui_devtools/devtools_server.h included in viz_main_impl.cc file.

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I0fe43236ca7778668ea55bb5b945bd2526d16091
Reviewed-on: https://chromium-review.googlesource.com/998413
Commit-Queue: Illia Martyniuk <illiam@google.com>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550782}
[modify] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/ui_element.cc
[modify] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/ui_element.h
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/BUILD.gn
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/DEPS
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/dom_agent_viz.cc
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/dom_agent_viz.h
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/frame_sink_element.cc
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/frame_sink_element.h
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/overlay_agent_viz.cc
[add] https://crrev.com/61d65e5d81eeeedd102ff8ba0122d098922da1cf/components/ui_devtools/viz_views/overlay_agent_viz.h
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ab5d53e3248cf12220c1682004affa48aa62376

commit 8ab5d53e3248cf12220c1682004affa48aa62376
Author: yiyix <yiyix@chromium.org>
Date: Tue Jul 17 17:58:03 2018

VIZ devtools: Add viz_view to build target

Add viz_views to an exisiting build target.

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I5d7b959487bf86d7b7fa940f8f0948f8e0480cdb
Reviewed-on: https://chromium-review.googlesource.com/1136870
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575713}
[modify] https://crrev.com/8ab5d53e3248cf12220c1682004affa48aa62376/BUILD.gn
[modify] https://crrev.com/8ab5d53e3248cf12220c1682004affa48aa62376/components/ui_devtools/viz_views/frame_sink_element.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14be2cfe5455ea524b7b52f4f88d9a9707f8fb42

commit 14be2cfe5455ea524b7b52f4f88d9a9707f8fb42
Author: yiyix <yiyix@chromium.org>
Date: Sat Aug 18 02:55:31 2018

VizDevTools: Providing updates of a FrameSink tree

FrameSinkElement implements FrameSinkObserver interface and handles all
the events for updating the tree.

Bug: 816802
Change-Id: I6552281672cda18f611c65971aa56eea7aa13a00
Reviewed-on: https://chromium-review.googlesource.com/1113018
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584290}
[modify] https://crrev.com/14be2cfe5455ea524b7b52f4f88d9a9707f8fb42/components/ui_devtools/ui_element.h
[modify] https://crrev.com/14be2cfe5455ea524b7b52f4f88d9a9707f8fb42/components/ui_devtools/viz_views/dom_agent_viz.cc
[modify] https://crrev.com/14be2cfe5455ea524b7b52f4f88d9a9707f8fb42/components/ui_devtools/viz_views/dom_agent_viz.h
[modify] https://crrev.com/14be2cfe5455ea524b7b52f4f88d9a9707f8fb42/components/ui_devtools/viz_views/frame_sink_element.h
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/571c7ef41d8c07586b8a73478165a077363fa75d

commit 571c7ef41d8c07586b8a73478165a077363fa75d
Author: yiyix <yiyix@chromium.org>
Date: Fri Aug 24 15:57:19 2018

VizDevTools: Remove the duplicated information in DomAgentViz

|registered_frame_sink_ids_to_is_connected_| and |frame_sink_elements_|
saves the same information about the FrameSinkId, that is if a
FrameSinkId is register and/or created. This cl removes the variable
|registered_frame_sink_ids_to_is_connected_|.

Bug:816802

Change-Id: Iad9c9e9819ffd44ca8aff7c7b82ad0b5852d6e8d
Reviewed-on: https://chromium-review.googlesource.com/1186195
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585859}
[modify] https://crrev.com/571c7ef41d8c07586b8a73478165a077363fa75d/components/ui_devtools/viz_views/dom_agent_viz.cc
[modify] https://crrev.com/571c7ef41d8c07586b8a73478165a077363fa75d/components/ui_devtools/viz_views/dom_agent_viz.h
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38f1e58b1dd08b2ee9b969df44921b27280a146e

commit 38f1e58b1dd08b2ee9b969df44921b27280a146e
Author: yiyix <yiyix@chromium.org>
Date: Thu Sep 06 21:23:43 2018

VizDevTools: Observing static Surface tree

Builds the Surface tree considering Surfaces that correspond to
RootFrameSinks and detached Surfaces as root Surfaces. All of these are
attached to RootElement.

Bug:816802

TBR=sadrul@chromium.org

Change-Id: I74d11ddb0fed9dc31712dc6e98cf20e936856400
Reviewed-on: https://chromium-review.googlesource.com/1185964
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589302}
[modify] https://crrev.com/38f1e58b1dd08b2ee9b969df44921b27280a146e/components/ui_devtools/ui_element.cc
[modify] https://crrev.com/38f1e58b1dd08b2ee9b969df44921b27280a146e/components/ui_devtools/ui_element.h
[modify] https://crrev.com/38f1e58b1dd08b2ee9b969df44921b27280a146e/components/ui_devtools/viz_views/BUILD.gn
[add] https://crrev.com/38f1e58b1dd08b2ee9b969df44921b27280a146e/components/ui_devtools/viz_views/surface_element.cc
[add] https://crrev.com/38f1e58b1dd08b2ee9b969df44921b27280a146e/components/ui_devtools/viz_views/surface_element.h

Comment 17 by kylec...@chromium.org, Oct 19

Cc: kylec...@chromium.org
Labels: -OS-Chrome -merge-merged-testbranch Target-72
Owner: sgilhuly@chromium.org

Comment 18 by dgozman@chromium.org, Oct 31

Components: -Platform>DevTools
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13fc02ff3ec29324038b483bdf8e730869880a27

commit 13fc02ff3ec29324038b483bdf8e730869880a27
Author: Sean Gilhuly <sgilhuly@chromium.org>
Date: Thu Nov 01 14:05:30 2018

Setup for connecting the Viz DevTools server

Watch for a server socket when the frame sink manager is created, and
run the viz devtools server on the compositor thread if it is present.

The server socket is not passed in through mojo yet, so the devtools
server will not be created.

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic02853a2e1f845df365716c29e4f974ffd7482dc
Reviewed-on: https://chromium-review.googlesource.com/c/1285078
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604571}
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[add] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/components/ui_devtools/devtools.gni
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/components/ui_devtools/devtools_server.cc
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/components/ui_devtools/devtools_server.h
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/components/ui_devtools/viz_views/surface_element.cc
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/components/ui_devtools/viz_views/surface_element.h
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/components/viz/service/BUILD.gn
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/components/viz/service/main/BUILD.gn
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/components/viz/service/main/DEPS
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/components/viz/service/main/viz_compositor_thread_runner.cc
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/components/viz/service/main/viz_compositor_thread_runner.h
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/content/browser/BUILD.gn
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/services/viz/BUILD.gn
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/services/viz/privileged/interfaces/BUILD.gn
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/services/viz/privileged/interfaces/viz_main.mojom
[modify] https://crrev.com/13fc02ff3ec29324038b483bdf8e730869880a27/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da1ee4ba0aa8da0f0e6447699c230c4b3c829520

commit da1ee4ba0aa8da0f0e6447699c230c4b3c829520
Author: Sean Gilhuly <sgilhuly@chromium.org>
Date: Tue Nov 13 21:56:09 2018

Connect the Viz DevTools server

Create a server socket on the browser process and pass it to the viz
process, where the Viz DevTools server is created.

The server is enabled with the flag --enable-viz-devtools=<port>. If no
port is specified, the default 9229 is used.

Once running, you can connect to the server with the following url:
chrome-devtools://devtools/bundled/inspector.html?ws=localhost:9229/0

The viz devtools server should be connected on Android and when it runs
in-process, but these haven't been tested yet.

Bug: 816802
Change-Id: Ica6b98253b49e0658a680a71fa3fe7ad083610a9
Reviewed-on: https://chromium-review.googlesource.com/c/1309135
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607754}
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/components/viz/host/BUILD.gn
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/components/viz/host/gpu_host_impl.cc
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/components/viz/host/gpu_host_impl.h
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/components/viz/service/main/viz_compositor_thread_runner.cc
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/components/viz/service/main/viz_compositor_thread_runner.h
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/components/viz/service/main/viz_main_impl.cc
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/components/viz/service/main/viz_main_impl.h
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/content/browser/BUILD.gn
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/content/browser/gpu/DEPS
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/content/browser/gpu/gpu_process_host.h
[add] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/content/browser/gpu/viz_devtools_connector.cc
[add] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/content/browser/gpu/viz_devtools_connector.h
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/content/public/browser/content_browser_client.h
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/services/viz/privileged/interfaces/BUILD.gn
[modify] https://crrev.com/da1ee4ba0aa8da0f0e6447699c230c4b3c829520/services/viz/privileged/interfaces/viz_main.mojom
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8844de6ab8060eb83589337175baeb63e913822c

commit 8844de6ab8060eb83589337175baeb63e913822c
Author: Sean Gilhuly <sgilhuly@chromium.org>
Date: Wed Nov 21 15:45:06 2018

Improve Viz DevTools stability

Stop recreating the current ui element in BuildTreeForUIElement, and fix
some other errors that were causing DCHECKs.

Node reparenting should be streamlined in the future; currently, the
whole subtree is destroyed and recreated in the new location.

This fixes all of the known crashes in the Viz DevTools server.

Bug: 816802
Change-Id: Ied786d3e244fd62c3482602e5b7067494822c2f6
Reviewed-on: https://chromium-review.googlesource.com/c/1330298
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610073}
[modify] https://crrev.com/8844de6ab8060eb83589337175baeb63e913822c/components/ui_devtools/ui_element.cc
[modify] https://crrev.com/8844de6ab8060eb83589337175baeb63e913822c/components/ui_devtools/ui_element.h
[modify] https://crrev.com/8844de6ab8060eb83589337175baeb63e913822c/components/ui_devtools/viz_views/dom_agent_viz.cc
[modify] https://crrev.com/8844de6ab8060eb83589337175baeb63e913822c/components/ui_devtools/viz_views/dom_agent_viz.h
[modify] https://crrev.com/8844de6ab8060eb83589337175baeb63e913822c/components/ui_devtools/viz_views/frame_sink_element.cc
[modify] https://crrev.com/8844de6ab8060eb83589337175baeb63e913822c/components/ui_devtools/viz_views/frame_sink_element.h
[modify] https://crrev.com/8844de6ab8060eb83589337175baeb63e913822c/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/8844de6ab8060eb83589337175baeb63e913822c/components/viz/service/frame_sinks/frame_sink_manager_impl.h
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e895c9166972891617f1ce72cc8f7cb5446e745

commit 1e895c9166972891617f1ce72cc8f7cb5446e745
Author: Sean Gilhuly <sgilhuly@chromium.org>
Date: Mon Dec 03 19:52:41 2018

VizDevTools: Use unique_ptrs for the FrameSinkElements

FrameSinkElement creation is moved into a function that creates the
unique_ptr and adds it to the map of elements. Removing elements from
this map now deletes them.

The FrameSinkElements need to be owned by DOMAgentViz because it
receives all of the FrameSinkObserver events. Whereas for Views, each
ViewElement, WidgetElement, and WindowElement is its own Observer, so
centralized ownership in DOMAgentAura doesn't make as much sense.

Elements are no longer inserted into |frame_sink_elements_| by
BuildTreeForFrameSink(), so we don't need to static_cast pointers any
more. Also make variable names in BuildTreeForFrameSink() clearer.

Bug: 816802
Change-Id: Ieec4db482ffb3ff8a740eb559c1c3d9ee9a80705
Reviewed-on: https://chromium-review.googlesource.com/c/1346910
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613202}
[modify] https://crrev.com/1e895c9166972891617f1ce72cc8f7cb5446e745/components/ui_devtools/ui_element.cc
[modify] https://crrev.com/1e895c9166972891617f1ce72cc8f7cb5446e745/components/ui_devtools/ui_element.h
[modify] https://crrev.com/1e895c9166972891617f1ce72cc8f7cb5446e745/components/ui_devtools/viz_views/dom_agent_viz.cc
[modify] https://crrev.com/1e895c9166972891617f1ce72cc8f7cb5446e745/components/ui_devtools/viz_views/dom_agent_viz.h
[modify] https://crrev.com/1e895c9166972891617f1ce72cc8f7cb5446e745/components/ui_devtools/viz_views/frame_sink_element.cc
[modify] https://crrev.com/1e895c9166972891617f1ce72cc8f7cb5446e745/components/ui_devtools/viz_views/surface_element.cc
Project Member

Comment 23 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd29bd4767adafbcad65d8a0c59272540aa7ebd5

commit cd29bd4767adafbcad65d8a0c59272540aa7ebd5
Author: Sean Gilhuly <sgilhuly@chromium.org>
Date: Mon Dec 10 17:56:04 2018

VizDevTools: Observe Surface hierarchy

Implement SurfaceObserver methods in DOMAgentViz. Watch for Surfaces to
be created, deleted, or referenced, and update the SurfaceElements
accordingly.

Bug: 816802
Change-Id: I9e24c0fa95c5d89a1f6c1309f2176fabec549011
Reviewed-on: https://chromium-review.googlesource.com/c/1359474
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615167}
[modify] https://crrev.com/cd29bd4767adafbcad65d8a0c59272540aa7ebd5/components/ui_devtools/viz_views/dom_agent_viz.cc
[modify] https://crrev.com/cd29bd4767adafbcad65d8a0c59272540aa7ebd5/components/ui_devtools/viz_views/dom_agent_viz.h
[modify] https://crrev.com/cd29bd4767adafbcad65d8a0c59272540aa7ebd5/components/ui_devtools/viz_views/surface_element.cc
[modify] https://crrev.com/cd29bd4767adafbcad65d8a0c59272540aa7ebd5/components/ui_devtools/viz_views/surface_element.h
Project Member

Comment 24 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47a2af4a2b146fff146d826c91a88f9d7afd1bb3

commit 47a2af4a2b146fff146d826c91a88f9d7afd1bb3
Author: Sean Gilhuly <sgilhuly@chromium.org>
Date: Wed Dec 19 19:07:11 2018

VizDevTools: Unit tests for element interactions

Unit tests for atomic updates to DOMAgentViz, and more complex
interactions and cases with FrameSinks and Surfaces.

Bug: 816802
Change-Id: Icb92dee44cdd7a9409c22f55af20c0f51a902b09
Reviewed-on: https://chromium-review.googlesource.com/c/1374190
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617899}
[modify] https://crrev.com/47a2af4a2b146fff146d826c91a88f9d7afd1bb3/components/BUILD.gn
[modify] https://crrev.com/47a2af4a2b146fff146d826c91a88f9d7afd1bb3/components/ui_devtools/devtools.gni
[modify] https://crrev.com/47a2af4a2b146fff146d826c91a88f9d7afd1bb3/components/ui_devtools/ui_devtools_unittest_utils.cc
[modify] https://crrev.com/47a2af4a2b146fff146d826c91a88f9d7afd1bb3/components/ui_devtools/ui_devtools_unittest_utils.h
[modify] https://crrev.com/47a2af4a2b146fff146d826c91a88f9d7afd1bb3/components/ui_devtools/viz_views/BUILD.gn
[modify] https://crrev.com/47a2af4a2b146fff146d826c91a88f9d7afd1bb3/components/ui_devtools/viz_views/DEPS
[modify] https://crrev.com/47a2af4a2b146fff146d826c91a88f9d7afd1bb3/components/ui_devtools/viz_views/dom_agent_viz.cc
[modify] https://crrev.com/47a2af4a2b146fff146d826c91a88f9d7afd1bb3/components/ui_devtools/viz_views/dom_agent_viz.h
[add] https://crrev.com/47a2af4a2b146fff146d826c91a88f9d7afd1bb3/components/ui_devtools/viz_views/viz_devtools_unittest.cc
Project Member

Comment 25 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf3f61fb6007077199c1def018e6e0fb81404612

commit cf3f61fb6007077199c1def018e6e0fb81404612
Author: Sean Gilhuly <sgilhuly@chromium.org>
Date: Tue Jan 08 20:12:56 2019

Rename ui_devtools/viz_views to ui_devtools/viz

viz_views is a less than ideal name for the Viz DevTools, so change it.

Also add an OWNERS file to ui_devtools/viz.

Bug: 816802
Change-Id: I1eb60a10e778accea1f19cad262e5333f4be452b
Reviewed-on: https://chromium-review.googlesource.com/c/1385111
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620854}
[modify] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/BUILD.gn
[modify] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/BUILD.gn
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/BUILD.gn
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/DEPS
[add] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/OWNERS
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/dom_agent_viz.cc
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/dom_agent_viz.h
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/frame_sink_element.cc
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/frame_sink_element.h
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/overlay_agent_viz.cc
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/overlay_agent_viz.h
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/surface_element.cc
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/surface_element.h
[rename] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/ui_devtools/viz/viz_devtools_unittest.cc
[modify] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/viz/service/main/BUILD.gn
[modify] https://crrev.com/cf3f61fb6007077199c1def018e6e0fb81404612/components/viz/service/main/viz_compositor_thread_runner.cc
►

Sign in to add a comment