New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816801 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

CookiesFetcher needs cleanup.

Reported by pritam.n...@samsung.com, Feb 27 2018

Issue description

Example URL:

Steps to reproduce the problem:
Current implementation of CookiesFetcher keeps the application context as state information. That we can get that statically from ContextUtils#getApplicationContext().

In that case, we can simply get rid of CookiesFetcher java and c++ implementation.

It's a follow-up cleanup bug.

Please read further: 
https://chromium-review.googlesource.com/c/chromium/src/+/903307/18#message-c6f0885170ee3c16c839f059d2293890db334dab

What is the expected behavior?

What went wrong?
CookiesFetcher needs cleanup.

Did this work before? N/A 

Chrome version:   Channel: n/a
OS Version: 
Flash Version:
 
Cc: bauerb@chromium.org rdsmith@chromium.org dcheng@chromium.org
Components: -Internals>Network Internals>Network>Cookies
Labels: -Type-Bug -Pri-2 Pri-3 Type-Task
Cc: torne@chromium.org reillyg@chromium.org
Hi,
I've added a patch, please have a look.

Review url: https://chromium-review.googlesource.com/c/chromium/src/+/942289

Thanks!
Status: Available (was: Unconfirmed)
This is being worked on per #3, so I'll change the status accordingly.
Owner: bauerb@chromium.org
Status: Started (was: Available)
Assigning to myself in Pritam's stead.
Cc: -rdsmith@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df040f996f49df9c38adff7ef84f9d8afd572085

commit df040f996f49df9c38adff7ef84f9d8afd572085
Author: Pritam <pritam.nikam@samsung.com>
Date: Fri Mar 02 18:28:43 2018

CookiesFetcher cleanup.

Current implementation of CookiesFetcher keeps the application context as a
state information. That we can get that statically from the
ContextUtils#getApplicationContext(). In that case, we can simply get rid of
CookiesFetcher java and c++ implementation.

BUG= 816801 

Change-Id: I519c8547baaae0e6fab3296acfe6dad48fba54ae
Reviewed-on: https://chromium-review.googlesource.com/942289
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Pritam Nikam <pritam.nikam@samsung.com>
Cr-Commit-Position: refs/heads/master@{#540561}
[modify] https://crrev.com/df040f996f49df9c38adff7ef84f9d8afd572085/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/df040f996f49df9c38adff7ef84f9d8afd572085/chrome/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java
[modify] https://crrev.com/df040f996f49df9c38adff7ef84f9d8afd572085/chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java
[modify] https://crrev.com/df040f996f49df9c38adff7ef84f9d8afd572085/chrome/browser/BUILD.gn
[delete] https://crrev.com/d6238312f455742e2fafb9208d976eb8daeba2d6/chrome/browser/android/cookies/cookies_fetcher.h
[rename] https://crrev.com/df040f996f49df9c38adff7ef84f9d8afd572085/chrome/browser/android/cookies/cookies_fetcher_util.cc

Hi Bernhard,
We can mark this bug as 'fixed'.
Thanks!

Comment 9 by bauerb@chromium.org, Apr 10 2018

Status: Fixed (was: Started)
Thanks, Pritam!

Sign in to add a comment