New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 81678 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

[Mac] Accelerated 2D canvas not rendering

Project Member Reported by ericbidelman@chromium.org, May 5 2011

Issue description

Example: http://ie.microsoft.com/testdrive/performance/fishietank/
Nothing is rendered on the page.

Mac 13.0.757.0 (84251) does not render

This has happened very recently. Today's Mac Canary: 13.0.756.0 renders fine.
 

Comment 1 by kbr@chromium.org, May 5 2011

Cc: vangelis...@gtempaccount.com

Comment 2 by kbr@chromium.org, May 5 2011

Cc: hbridge@google.com
Labels: Internals-Graphics Feature-GPU

Comment 3 by hbridge@google.com, May 5 2011

which flags are you using eric, can you post your about:version?

Comment 4 by kbr@chromium.org, May 5 2011

Cc: jam...@chromium.org junov@chromium.org bsalo...@google.com a deleted user
Summary: accelerated 2D canvas not rendering
It turns out this is occurring with --enable-accelerated-2d-canvas. Might be the same as  Issue 81674 , but this is happening in full Chrome, not DRT.

Chrome/Mac does not have accelerated canvas, although it should ignore the flag.  If it's not ignoring the flag, that's a bug.
I was running Chromium with a bunch of flags for testing...which included:
--enable-accelerated-compositing --enable-accelerated-2d-canvas

Comment 7 by junov@google.com, May 5 2011

The flag check at: Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp, line 134, is not protected by an build time conditionals that would block it on the mac, but that is nothing new. It would not explain the new fail.

Also, there is Page::sharedGraphicsContext3D that changed recently, but that change should not impact MAC since it is inside #if USE(SKIA)

Comment 8 by kareng@google.com, May 13 2011

Status: Assigned

Comment 9 by kbr@chromium.org, May 13 2011

Owner: junov@chromium.org
Sorry, I can not take this bug. Assigning to Justin who is actually working on this code.

Comment 10 by junov@chromium.org, May 16 2011

Status: Started

Comment 11 by junov@chromium.org, May 16 2011

Status: WontFix
Unreproducible on mac, r84747, webkit r86061
WontFix?

The "--enable-accelerated-2d-canvas" still not ignore in latest mac chromium nightly and mac chrome canary build.
all recent build come with this flag by default

about:gpu --> Canvas: Hardware accelerated

about:version --> Chromium	13.0.780.0 (Developer Build 87191)
about:version --> Google Chrome	13.0.779.0 (Official Build 87165) canary

unless user force "--disable-accelerated-2d-canvas" 
else all canvas 2d example content is blank.
Correction from previous comment

"--enable-accelerated-2d-canvas" gone

but  the option still on 

about:gpu --> Canvas: Hardware accelerated 

need to explicit disable to render those content


Status: Assigned
Labels: -canvas -Feature-GPU Mstone-13 Feature-GPU-Canvas2D ReleaseBlock-Dev
Cc: -hbridge@google.com
Did we by mistake enable accelerated 2d canvas on the mac as well?
I did verify that we have indeed by mistake enabled accelerated 2d canvas on the mac.  CL is up for review to correct this:
http://codereview.chromium.org/7093002/


Cc: enne@chromium.org vangelis@google.com reed@google.com twiz@chromium.org scroggo@chromium.org
 Issue 84327  has been merged into this issue.

Comment 19 by dhw@chromium.org, May 31 2011

Labels: OS-Mac
Summary: [Mac] Accelerated 2D canvas not rendering

Comment 20 by junov@chromium.org, May 31 2011

Status: Started
junov is currently working on a solution that's better than mine.  It requires fixing:
https://bugs.webkit.org/show_bug.cgi?id=61790

Comment 22 by junov@chromium.org, May 31 2011

Fix pending: http://codereview.chromium.org/7102003/
This can't go in until we roll-in the webkit fix for https://bugs.webkit.org/show_bug.cgi?id=61790 
which is currently sitting in the commit queue.

Comment 23 by junov@chromium.org, May 31 2011

WebKit portion of the fix has landed: http://trac.webkit.org/changeset/87748
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 1 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=87482

------------------------------------------------------------------------
r87482 | junov@chromium.org | Wed Jun 01 09:11:22 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/build/features_override.gypi?r1=87482&r2=87481&pathrev=87482

Disable the ACCELERATED_2D_CANVAS build flag on mac

BUG= 81678 
TEST=none

Review URL: http://codereview.chromium.org/7102003
------------------------------------------------------------------------
Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Agreed we should fix before beta, but this isn't a change in behavior over the last Dev channel.
Not sure when the last dev went out but without this change all pages with canvas on the mac will be busted.

Labels: ApprovedForMerge
Status: Fixed
Project Member

Comment 29 by bugdroid1@chromium.org, Jun 3 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=87817

------------------------------------------------------------------------
r87817 | laforge@chromium.org | Fri Jun 03 11:32:23 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/782/src/build/features_override.gypi?r1=87817&r2=87816&pathrev=87817

Merge 87482 - Disable the ACCELERATED_2D_CANVAS build flag on mac

BUG= 81678 
TEST=none

Review URL: http://codereview.chromium.org/7102003

TBR=junov@chromium.org
Review URL: http://codereview.chromium.org/7111011
------------------------------------------------------------------------
 Issue 84864  has been merged into this issue.
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 32 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-WebKit -Mstone-13 -Internals-Graphics -Feature-GPU-Canvas2D Cr-Content Cr-Internals-Graphics M-13 Cr-Internals-GPU-Canvas2D
Project Member

Comment 33 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 34 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink

Comment 35 Deleted

Owner: junov@chromium.org
Status: Fixed
Components: -Internals>Graphics Internals>GPU
Moving old issues out of Internal>Graphics to delete this obsolete component ( crbug.com/685425  for details)

Sign in to add a comment