New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816768 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Security DCHECK failure: i < length_ in StringImpl.h

Project Member Reported by ClusterFuzz, Feb 27 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6031107917873152

Fuzzer: miaubiz_css_fuzzer
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Security DCHECK failure
Crash Address: 
Crash State:
  i < length_ in StringImpl.h
  blink::InlineTextBox::IsLineBreak
  blink::InlineFlowBox::ComputeOverflow
  
Sanitizer: address (ASAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6031107917873152

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 27 2018

Labels: M-64
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 27 2018

Labels: Pri-1

Comment 3 by kenrb@chromium.org, Feb 27 2018

Components: Blink>Layout
Labels: -Security_Severity-High Security_Severity-Medium
Owner: e...@chromium.org
Status: Assigned (was: Untriaged)
Repros easily on a Windows build with DCHECKs (haven't tried other platforms). This is trying to read index 0 from a zero-length string in the LineLayoutItem. Emil, can you please help triage this?

Comment 4 by e...@chromium.org, Mar 1 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2304f6f1ff0d506c9dcb3ed610e67250daf866ed

commit 2304f6f1ff0d506c9dcb3ed610e67250daf866ed
Author: Emil A Eklund <eae@chromium.org>
Date: Fri Mar 02 00:46:36 2018

Check actual text length in InlineTextBox::IsLineBreak

Check the length of the underlying string, rather than the length of the
text box as the two may differ due to text normalization.

Bug:  816768 
Change-Id: Ibb91256200d51f6ec19dcff6e84bc12e5230f776
Reviewed-on: https://chromium-review.googlesource.com/942367
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540382}
[modify] https://crrev.com/2304f6f1ff0d506c9dcb3ed610e67250daf866ed/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

Project Member

Comment 6 by ClusterFuzz, Mar 2 2018

ClusterFuzz has detected this issue as fixed in range 540368:540424.

Detailed report: https://clusterfuzz.com/testcase?key=6031107917873152

Fuzzer: miaubiz_css_fuzzer
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Security DCHECK failure
Crash Address: 
Crash State:
  i < length_ in StringImpl.h
  blink::InlineTextBox::IsLineBreak
  blink::InlineFlowBox::ComputeOverflow
  
Sanitizer: address (ASAN)

Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=540368:540424

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6031107917873152

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Mar 2 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6031107917873152 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 2 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -M-64 M-66
Labels: -reward-topanel reward-unpaid reward-1500
*** Boilerplate reminders! ***
Please do NOT publicly disclose details until a fix has been released to all our users. Early public disclosure may cancel the provisional reward. Also, please be considerate about disclosure when the bug affects a core library that may be used by other products. Please do NOT share this information with third parties who are not directly involved in fixing the bug. Doing so may cancel the provisional reward. Please be honest if you have already disclosed anything publicly or to third parties. Lastly, we understand that some of you are not interested in money. We offer the option to donate your reward to an eligible charity. If you prefer this option, let us know and we will also match your donation - subject to our discretion. Any rewards that are unclaimed after 12 months will be donated to a charity of our choosing.
*********************************
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 16 2018

Labels: Merge-Request-66
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 16 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Approved for M66 - branch:3359
Labels: -reward-unpaid reward-inprocess
Project Member

Comment 15 by sheriffbot@chromium.org, Mar 23 2018

Cc: abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Mar 27 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-66 Release-0-M66
Project Member

Comment 18 by sheriffbot@chromium.org, Jun 8 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment