New issue
Advanced search Search tips

Issue 816745 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The WebRTC echo canceller would benefit of knowing that it operates on a setup non zero ERL

Project Member Reported by peah@chromium.org, Feb 27 2018

Issue description

The echo return loss (ERL) is a measure for how high attenuation an echo path has. When it is known that the echo path cannot have infinite attenuation, the echo canceller benefits from having that specified.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eea09d62ec0771b13b13b50092d62106ffe9cdfa

commit eea09d62ec0771b13b13b50092d62106ffe9cdfa
Author: Per Åhgren <peah@chromium.org>
Date: Tue Feb 27 23:44:59 2018

Added a base::Feature command line flag for specifying a bounded ERL setup

This CL adds a command line switch based on base::Feature to allow the
user to explicitly specify when the setup used is such that the echo
path loss (ERL) is finite.

Bug:  chromium:816745 
Change-Id: Ib64d699c01a85c1251df132b329d00927d5fa72d
Reviewed-on: https://chromium-review.googlesource.com/938922
Commit-Queue: Per Åhgren <peah@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539585}
[modify] https://crrev.com/eea09d62ec0771b13b13b50092d62106ffe9cdfa/content/public/common/content_features.cc
[modify] https://crrev.com/eea09d62ec0771b13b13b50092d62106ffe9cdfa/content/public/common/content_features.h
[modify] https://crrev.com/eea09d62ec0771b13b13b50092d62106ffe9cdfa/content/renderer/media/stream/media_stream_audio_processor.cc

Comment 2 by peah@chromium.org, Mar 5 2018

Status: Fixed (was: Assigned)

Sign in to add a comment