Regression: console does not show useful information for failed subresource requests |
|||||||||
Issue descriptionChrome Version: 66.0.3355.0 OS: Mac, Linux What steps will reproduce the problem? (1) Visit https://example.com (2) Open DevTools. In the console, type: var i = document.createElement('img'); i.src="https://expired.badssl.com"; What is the expected result? The console message for the failed resource load shows the error code that occurred (see attached screenshot before.png from 64.0.3282.167). What happens instead? The console message for the failed resource load says "GET https://expired.badssl.com/ 0 ()" which is confusing and not helpful (see after.png).
,
Jun 26 2018
,
Jun 26 2018
Thanks for the report! DevTools frontend still receives the proper error message, just doesn't render it. I think it's unrelated to site isolation, will take a look. Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/6c5d2a4b76447457f77207430b1b9d124f43f753..88b392acd3923b7933bf1de66cac2068b7163992 Suspect: https://chromium.googlesource.com/chromium/src/+/848d697da0766cc108c5f869f38128b8ff52df94
,
Jun 27 2018
Issue 836039 has been merged into this issue.
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9239db0ce447d1b78fd9191b1b997604562e6879 commit 9239db0ce447d1b78fd9191b1b997604562e6879 Author: Erik Luo <luoe@chromium.org> Date: Thu Jun 28 16:20:32 2018 DevTools: show localized error message for Network errors in Console When migrating [1] formatting logic from ConsoleViewMessage.js to BrowserConsole.js, we forgot to add the line that tries to show a localizedFailDescription. [1] https://chromium-review.googlesource.com/c/chromium/src/+/920541 Bug: 816743 Change-Id: Ic3e6cc49b8634a12fe8667c19fdc4623780075db Reviewed-on: https://chromium-review.googlesource.com/1115872 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#571153} [modify] https://crrev.com/9239db0ce447d1b78fd9191b1b997604562e6879/third_party/WebKit/LayoutTests/http/tests/devtools/console-resource-errors-expected.txt [modify] https://crrev.com/9239db0ce447d1b78fd9191b1b997604562e6879/third_party/WebKit/LayoutTests/http/tests/devtools/console-resource-errors.js [modify] https://crrev.com/9239db0ce447d1b78fd9191b1b997604562e6879/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-long-url-expected.txt [modify] https://crrev.com/9239db0ce447d1b78fd9191b1b997604562e6879/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-with-caret-expected.txt [modify] https://crrev.com/9239db0ce447d1b78fd9191b1b997604562e6879/third_party/blink/renderer/devtools/front_end/browser_console/BrowserConsole.js
,
Jun 28 2018
After the fix in #5 bakes in Canary, I plan to request a merge to 68.
,
Jun 29 2018
,
Jun 29 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 2
abdulsyed@, is it possible to merge to M68? The CL in #5 has been on Canary for a couple of days. It only affects tests and the DevTools frontend.
,
Jul 2
Since this has been present since M66, let's just wait until M69. Do you think its fine to wait until then?
,
Jul 2
That sounds reasonable to me, since it has already been on stable for awhile. Marking as fixed, then, unless there are objections.
,
Jul 3
,
Jul 6
It is also extra brackets on the HTTP status codes (errors). Releated to this issue. It is not fixed in the last canary 69.0.3483.0
,
Jul 9
Hm, #13 looks related, but a separate root cause. Do you happen to have a URL/jsfiddle that consistently reproduces?
,
Jul 9
Here you go: https://topjohnwu.github.io/libsu/ But looks like this happens not in all cases. It can be "404 (Not found)", like normal way, or it can be only brackets, like on image higher. May be it is "empty description" or something similar?
,
Jul 9
Thanks! I've filed a separate report for #13 at: crbug.com/861881 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dgozman@chromium.org
, Mar 12 2018Status: Assigned (was: Untriaged)