New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816743 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Regression: console does not show useful information for failed subresource requests

Project Member Reported by est...@chromium.org, Feb 27 2018

Issue description

Chrome Version: 66.0.3355.0
OS: Mac, Linux

What steps will reproduce the problem?
(1) Visit https://example.com
(2) Open DevTools. In the console, type:
var i = document.createElement('img'); i.src="https://expired.badssl.com";

What is the expected result?
The console message for the failed resource load shows the error code that occurred (see attached screenshot before.png from 64.0.3282.167).

What happens instead?
The console message for the failed resource load says "GET https://expired.badssl.com/ 0 ()" which is confusing and not helpful (see after.png).

 
after.png
55.6 KB View Download
before.png
56.2 KB View Download
Owner: eostroukhov@chromium.org
Status: Assigned (was: Untriaged)
This is probably related to site isolation - we are stripping information which comes cross-process. Perhaps, we should not report any information here as a first easy step. 

Or emit this message from browser longer term. Eugene, mind taking a look?

Comment 2 by l...@chromium.org, Jun 26 2018

Owner: l...@chromium.org

Comment 3 by l...@chromium.org, Jun 26 2018

Labels: -Pri-3 Target-68 Pri-1
Thanks for the report!  DevTools frontend still receives the proper error message, just doesn't render it.  I think it's unrelated to site isolation, will take a look.

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/6c5d2a4b76447457f77207430b1b9d124f43f753..88b392acd3923b7933bf1de66cac2068b7163992

Suspect:
https://chromium.googlesource.com/chromium/src/+/848d697da0766cc108c5f869f38128b8ff52df94

Comment 4 by l...@chromium.org, Jun 27 2018

Cc: manoranj...@chromium.org pfeldman@chromium.org susan.boorgula@chromium.org
 Issue 836039  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9239db0ce447d1b78fd9191b1b997604562e6879

commit 9239db0ce447d1b78fd9191b1b997604562e6879
Author: Erik Luo <luoe@chromium.org>
Date: Thu Jun 28 16:20:32 2018

DevTools: show localized error message for Network errors in Console

When migrating [1] formatting logic from ConsoleViewMessage.js to
BrowserConsole.js, we forgot to add the line that tries to show a
localizedFailDescription.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/920541

Bug:  816743 
Change-Id: Ic3e6cc49b8634a12fe8667c19fdc4623780075db
Reviewed-on: https://chromium-review.googlesource.com/1115872
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571153}
[modify] https://crrev.com/9239db0ce447d1b78fd9191b1b997604562e6879/third_party/WebKit/LayoutTests/http/tests/devtools/console-resource-errors-expected.txt
[modify] https://crrev.com/9239db0ce447d1b78fd9191b1b997604562e6879/third_party/WebKit/LayoutTests/http/tests/devtools/console-resource-errors.js
[modify] https://crrev.com/9239db0ce447d1b78fd9191b1b997604562e6879/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-long-url-expected.txt
[modify] https://crrev.com/9239db0ce447d1b78fd9191b1b997604562e6879/third_party/WebKit/LayoutTests/http/tests/devtools/network/script-as-text-loading-with-caret-expected.txt
[modify] https://crrev.com/9239db0ce447d1b78fd9191b1b997604562e6879/third_party/blink/renderer/devtools/front_end/browser_console/BrowserConsole.js

Comment 6 by l...@chromium.org, Jun 28 2018

After the fix in #5 bakes in Canary, I plan to request a merge to 68.

Comment 7 by l...@chromium.org, Jun 29 2018

Labels: Merge-Request-68
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 29 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: abdulsyed@chromium.org
abdulsyed@, is it possible to merge to M68?  The CL in #5 has been on Canary for a couple of days.  It only affects tests and the DevTools frontend.
Since this has been present since M66, let's just wait until M69. Do you think its fine to wait until then?
Status: Fixed (was: Assigned)
That sounds reasonable to me, since it has already been on stable for awhile.  Marking as fixed, then, unless there are objections.
Labels: -Merge-Review-68 Merge-Rejected-68
It is also extra brackets on the HTTP status codes (errors). Releated to this issue.
It is not fixed in the last canary 69.0.3483.0

img1.png
14.1 KB View Download
img2.png
14.2 KB View Download
Hm, #13 looks related, but a separate root cause.  Do you happen to have a URL/jsfiddle that consistently reproduces?
Here you go: https://topjohnwu.github.io/libsu/
But looks like this happens not in all cases. It can be "404 (Not found)", like normal way, or it can be only brackets, like on image higher. May be it is "empty description" or something similar?
img1.png
27.2 KB View Download
Thanks!  I've filed a separate report for #13 at: crbug.com/861881

Sign in to add a comment