New issue
Advanced search Search tips

Issue 816742 link

Starred by 1 user
Status: Fixed
Owner:
peah@chromium.org
Closed: Mar 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The WebRTC echo canceller would benefit of knowing that it operates on a setup with clock-drift

Project Member Reported by peah@chromium.org, Feb 27 2018 
Setups with clock drift are generally difficult for echo cancellers to handle. Therefore, when it is known that the setup used has clock-drift the echo canceller would benefit from having that specified instead of having to explicitly detect that.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c3a29ca883f4cefe8cf94dd6594b2feaf8a2e4e

commit 2c3a29ca883f4cefe8cf94dd6594b2feaf8a2e4e
Author: Per Åhgren <peah@chromium.org>
Date: Wed Feb 28 12:02:30 2018

Added a base::Feature command line switch for specifying a clock-drift setup

This CL adds a command line switch based on base::Feature to allow the user
to explicitly specify when the setup used is such that the audio playout and
capture are done on different clocks (has clock-drift).

Bug:  chromium:816742 
Change-Id: I8a8e15ef479062a0ab30878ef3bde5b5c1f52d6e
Reviewed-on: https://chromium-review.googlesource.com/938921
Commit-Queue: Per Åhgren <peah@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539795}
[modify] https://crrev.com/2c3a29ca883f4cefe8cf94dd6594b2feaf8a2e4e/content/public/common/content_features.cc
[modify] https://crrev.com/2c3a29ca883f4cefe8cf94dd6594b2feaf8a2e4e/content/public/common/content_features.h
[modify] https://crrev.com/2c3a29ca883f4cefe8cf94dd6594b2feaf8a2e4e/content/renderer/media/stream/media_stream_audio_processor.cc

Comment 2 by peah@chromium.org, Mar 5 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment