New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816732 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

[Findit] Flake Detection - Query and store flaky test data in ndb

Project Member Reported by wylieb@chromium.org, Feb 27 2018

Issue description

In the previously setup cron job, actually query the data store and use the results in ndb.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b78c8eeb6277f7576024e168693d7ccc5ab2d256

commit b78c8eeb6277f7576024e168693d7ccc5ab2d256
Author: Brandon Wylie <wylieb@chromium.org>
Date: Wed Mar 28 17:37:08 2018

[Findit] Flake Detection - Cron job to query and store results

Create a cronjob and associated functions to regularly query for
flakes and store the result. All mutated flakes will be checked for
potential issues to be filed.

Notable points for this change:
* A barebones handler for a cronjob that just calls into the functions
  I wrote. It's untested, that's mainly because it does't do anything.
* Service layer for bucketing flakes and checking for issue filing
  for flakes that have been altered by the bucketing process.
Bug:  816732 
Change-Id: Ic5d8f0103d2df3dae42e9e10d2b6352c41e8cc31
Reviewed-on: https://chromium-review.googlesource.com/969757
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/gae_libs/appengine_util.py
[modify] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/model/flake/detection/test/flake_occurrence_test.py
[modify] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/dispatch.yaml
[modify] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/services/flake_detection/detection_filing_util.py
[add] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/services/flake_detection/test/detect_flakes_test.py
[modify] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/libs/time_util.py
[add] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/handlers/flake/detection/detect_cq_flakes.py
[add] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/module-flake-detection-backend.yaml
[modify] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/main.py
[modify] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/services/flake_detection/test/detection_filing_util_test.py
[modify] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/model/flake/detection/flake_occurrence.py
[modify] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/cron.yaml
[add] https://crrev.com/b78c8eeb6277f7576024e168693d7ccc5ab2d256/appengine/findit/services/flake_detection/detect_flakes.py

Comment 2 by wylieb@chromium.org, Mar 29 2018

Labels: -Pri-1 Pri-0
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5d6744508ab71281df28f944b9eeb803de14306d

commit 5d6744508ab71281df28f944b9eeb803de14306d
Author: Brandon Wylie <wylieb@chromium.org>
Date: Sat Apr 14 00:18:08 2018

[Findit] Flake Detection - Add query to cron endpoint

This query will check for false cq rejections, which is the current
functionality of chromium-try-flakes. It does this by the following
conditions:
* An issue, patchset, master, builder combination should have both a
  passing and failing build.
* The failing build from the previously mentioned combination should
  have steps (with patch) failing and (without patch) passing.
* The tests belonging to the (with patch) failure mentioned above will
  contain the flaky tests. The flaky tests that we're interested for
  the time being is FFFF. This isn't true for webkit_layout_tests,
  which will use related, but perhaps special case logic.

Bug:816732
Change-Id: I2cffef48a81a5a82bae0408f7a13691f5852067f
Reviewed-on: https://chromium-review.googlesource.com/986940
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/5d6744508ab71281df28f944b9eeb803de14306d/appengine/findit/services/flake_detection/detect_flakes.py

Comment 5 by wylieb@chromium.org, Apr 20 2018

Owner: ----
Status: Available (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 24 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by st...@chromium.org, Apr 24 2018

Owner: wylieb@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment