Remove unnecessary LinearLayout from main.xml |
||
Issue descriptionWhy does our main.xml have a LinearLayout root element with only a single child view? https://cs.chromium.org/chromium/src/chrome/android/java/res/layout/main.xml?l=7 Do we add anything as a sibling of CoordinatorLayoutForPointer in code that necessitates that? This looks like it was changed in: https://codereview.chromium.org/2560043002 and maybe this is just cruft left over that we can delete?
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a45232edee8a0251f6ed4f7d36085819d8cadc87 commit a45232edee8a0251f6ed4f7d36085819d8cadc87 Author: Matthew Jones <mdjones@chromium.org> Date: Wed Feb 28 16:31:24 2018 Remove unnecessary linear layout from main.xml This change removes a linear layout from main.xml that only has a single child. The one child has been moved to be a child of the root. BUG= 816715 Change-Id: I96f1ce26f19c56c9ff69587504bc9a8c6d46c326 Reviewed-on: https://chromium-review.googlesource.com/939650 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#539846} [modify] https://crrev.com/a45232edee8a0251f6ed4f7d36085819d8cadc87/chrome/android/java/res/layout/main.xml
,
Feb 28 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mdjones@chromium.org
, Feb 27 2018