New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 816696 link

Starred by 1 user
Status: Verified
Owner:
asvitk...@chromium.org
Closed: Mar 2018
Cc:
skare@chromium.org
isherman@chromium.org
ios-bugs@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Default group does not get activated when multiple features are used in a study

Project Member Reported by asvitk...@chromium.org, Feb 26 2018 
Default group does not get activated when multiple features are used in a study.

This is because we only associate features that are specified on an experiment (and make an exception for the case where a single feature is used in the study).
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bbc915b63923f6e2e32d068768ab087dc5ccf16

commit 5bbc915b63923f6e2e32d068768ab087dc5ccf16
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Tue Feb 27 16:02:30 2018

Refactor default group variation feature association code.

This is a no-op change that paves way for changing the logic
such that multiple features could be associated with a default
group.

Bug:  816696 
Change-Id: Ic8f202dcb52316ad2c3e4310c3c0ecac18f092c6
Reviewed-on: https://chromium-review.googlesource.com/938654
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539440}
[modify] https://crrev.com/5bbc915b63923f6e2e32d068768ab087dc5ccf16/components/variations/BUILD.gn
[modify] https://crrev.com/5bbc915b63923f6e2e32d068768ab087dc5ccf16/components/variations/processed_study.cc
[modify] https://crrev.com/5bbc915b63923f6e2e32d068768ab087dc5ccf16/components/variations/processed_study.h
[modify] https://crrev.com/5bbc915b63923f6e2e32d068768ab087dc5ccf16/components/variations/variations_seed_processor.cc
[modify] https://crrev.com/5bbc915b63923f6e2e32d068768ab087dc5ccf16/components/variations/variations_seed_processor_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c808b531873ee5e8f7c233ba5ed4216749b62b6a

commit c808b531873ee5e8f7c233ba5ed4216749b62b6a
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Thu Mar 15 23:53:38 2018

Change variations default feature association to use all features.

Previously, it would only take effect when a single feature was
enabled on the study. The new logic would associate with all the
features.

Bug:  816696 
Change-Id: Ide5ace721ade5e78f8743b11a96998d3b08ded46
Reviewed-on: https://chromium-review.googlesource.com/963087
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543552}
[modify] https://crrev.com/c808b531873ee5e8f7c233ba5ed4216749b62b6a/components/variations/processed_study.cc
[modify] https://crrev.com/c808b531873ee5e8f7c233ba5ed4216749b62b6a/components/variations/variations_seed_processor_unittest.cc

Comment 3 by asvitk...@chromium.org, Mar 20 2018

Labels: M-67
Status: Verified (was: Started)
Looks to be working. I checked EnterpriseProcessIsolation study, which specifies no features in its 25% default group and the group is seeing data as of the 16th:

https://uma.googleplex.com/variations?sid=b7c7c242ce7cafed89fbd16713d3cdeb

Marking as Verified. Woot!
►

Sign in to add a comment