New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816684 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 819916
issue 824974
issue 842445
issue 875298

Blocking:
issue 803911



Sign in to add a comment

Track Page Load Metrics with Network Service enabled

Project Member Reported by cco3@chromium.org, Feb 26 2018

Issue description

With NetworkService enabled, Page Load Metrics are not being currently tracked.

See:
https://docs.google.com/document/d/1980iNJjM6R09Q7_bgAqIJC8QEvQbi5wErAoNDuswS8I/
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a87490bda575dd8b28b7b863e2dbf38057feffe

commit 7a87490bda575dd8b28b7b863e2dbf38057feffe
Author: Conley Owens <cco3@chromium.org>
Date: Wed Mar 07 20:19:37 2018

Add a SubresourceLoadInfo struct to content/

This data type is useful for sending stats from the renderer to the
browser, in SubresourceResponseStarted methods.  Currently there are six
fields that are passed around, but soon there may be more in order to
get PageLoadMetrics working with the Network Service.

BUG=816684

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I26a62ebb5aa82f225a70fe54098433c5c3342941
Reviewed-on: https://chromium-review.googlesource.com/947582
Commit-Queue: Conley Owens <cco3@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541550}
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/common/frame.mojom
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/public/common/BUILD.gn
[add] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/public/common/subresource_load_info.mojom
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/7a87490bda575dd8b28b7b863e2dbf38057feffe/content/test/test_render_frame.cc

Blockedon: 819916
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/badc08ce7857dd34f5460da498c98ddde2af986c

commit badc08ce7857dd34f5460da498c98ddde2af986c
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Mar 08 07:14:42 2018

Revert "Add a SubresourceLoadInfo struct to content/"

This reverts commit 7a87490bda575dd8b28b7b863e2dbf38057feffe.

Reason for revert: Crash. See  crbug.com/819916 

Original change's description:
> Add a SubresourceLoadInfo struct to content/
> 
> This data type is useful for sending stats from the renderer to the
> browser, in SubresourceResponseStarted methods.  Currently there are six
> fields that are passed around, but soon there may be more in order to
> get PageLoadMetrics working with the Network Service.
> 
> BUG=816684
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I26a62ebb5aa82f225a70fe54098433c5c3342941
> Reviewed-on: https://chromium-review.googlesource.com/947582
> Commit-Queue: Conley Owens <cco3@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541550}

TBR=dcheng@chromium.org,jcivelli@chromium.org,jam@chromium.org,cco3@chromium.org

Change-Id: I48effa0d5a7407dfbbaf41d5d1708a1491f31639
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816684, 819916 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/954588
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541746}
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/common/frame.mojom
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/public/common/BUILD.gn
[delete] https://crrev.com/c2b84ad191135be504a0abf4860b97b59f9d8b52/content/public/common/subresource_load_info.mojom
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/badc08ce7857dd34f5460da498c98ddde2af986c/content/test/test_render_frame.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a

commit 7a78fab4b64ddcb5efa12d254c9e128e3247ba8a
Author: Conley Owens <cco3@chromium.org>
Date: Sat Mar 10 06:27:49 2018

Add a SubresourceLoadInfo struct to content/

This data type is useful for sending stats from the renderer to the
browser, in SubresourceResponseStarted methods.  Currently there are six
fields that are passed around, but soon there may be more in order to
get PageLoadMetrics working with the Network Service.

This reverts commit badc08ce7857dd34f5460da498c98ddde2af986c.

This fixes the problem with the previous change by ensuring we have an
IP address before attempting to update the ClientSideDetectionHost IP
map.

BUG=816684, 819916 ,820032

Change-Id: I24ebb230c5bd76a5d2a43b39e86aba7541386bec
Reviewed-on: https://chromium-review.googlesource.com/957802
Commit-Queue: Conley Owens <cco3@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542359}
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/common/frame.mojom
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/public/common/BUILD.gn
[add] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/public/common/subresource_load_info.mojom
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/7a78fab4b64ddcb5efa12d254c9e128e3247ba8a/content/test/test_render_frame.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0

commit d46ddaea180a3dec1671c752f3e5ffb3fc183ca0
Author: Conley Owens <cco3@chromium.org>
Date: Thu Mar 15 01:27:09 2018

Report was_cached in SubresourceLoadInfo

This change adds a boolean `was_cached` to the SubresourceLoadInfo
struct.  This lets consumers know whether or not the response was
fetched from the network cache.  Notably, this is important for
recording page load metrics when the Network Service is enabled.

BUG=816684

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I28d60ff7286feca5d333203405ee9c351f43c0ab
Reviewed-on: https://chromium-review.googlesource.com/938650
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543276}
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/browser/loader/navigation_url_loader_network_service.h
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/public/common/subresource_load_info.mojom
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/renderer/loader/web_url_loader_impl.cc
[add] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/content/test/data/page_with_cached_subresource.html
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/services/network/public/cpp/resource_response.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/services/network/public/cpp/resource_response_info.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/services/network/public/cpp/resource_response_info.h
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/services/network/public/cpp/url_loader_completion_status.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/services/network/public/cpp/url_loader_completion_status.h
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/services/network/url_loader.cc
[modify] https://crrev.com/d46ddaea180a3dec1671c752f3e5ffb3fc183ca0/services/network/url_loader_factory.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b2b1a92072144890a713700be568c9fc3e520c4

commit 0b2b1a92072144890a713700be568c9fc3e520c4
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date: Thu Mar 15 15:24:15 2018

Revert "Report was_cached in SubresourceLoadInfo"

This reverts commit d46ddaea180a3dec1671c752f3e5ffb3fc183ca0.

Reason for revert: 2 tests are failing with NavigationMojoResponse.
See  https://crbug.com/822237 
The two failing are disabled with the NetworkService.
I can't fix the reverted CL. It has removed URLLoaderCompletionStatus.exists_in_cache and rely on NavigationURLLoaderNetworkService::OnResponseStarted to memorize if the response is in the cache.
In a lot of cases when NavigationURLLoaderDelegate::OnRequestFailed() is called, NavigationURLLoaderNetworkService::OnResponseStarted() is not called. It means |has_stale_copy_in_cache| will be set to false even if the failed request is in cache.

Original change's description:
> Report was_cached in SubresourceLoadInfo
> 
> This change adds a boolean `was_cached` to the SubresourceLoadInfo
> struct.  This lets consumers know whether or not the response was
> fetched from the network cache.  Notably, this is important for
> recording page load metrics when the Network Service is enabled.
> 
> BUG=816684
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I28d60ff7286feca5d333203405ee9c351f43c0ab
> Reviewed-on: https://chromium-review.googlesource.com/938650
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Conley Owens <cco3@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543276}

TBR=dcheng@chromium.org,jcivelli@chromium.org,jam@chromium.org,cco3@chromium.org

Change-Id: I23b197839b9b35af7d79ed03320a7494635c61bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816684
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/964461
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543375}
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/browser/loader/navigation_url_loader_network_service.h
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/public/common/subresource_load_info.mojom
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/content/renderer/loader/web_url_loader_impl.cc
[delete] https://crrev.com/4087a4cc0e9c7ae2eb7d465581afe92e59825541/content/test/data/page_with_cached_subresource.html
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/services/network/public/cpp/resource_response.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/services/network/public/cpp/resource_response_info.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/services/network/public/cpp/resource_response_info.h
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/services/network/public/cpp/url_loader_completion_status.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/services/network/public/cpp/url_loader_completion_status.h
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/services/network/url_loader.cc
[modify] https://crrev.com/0b2b1a92072144890a713700be568c9fc3e520c4/services/network/url_loader_factory.cc

Sorry I had to revert the patch without notice. Author is OOO today and reviewers are not in my timezone.
The two failing test are disabled with the NetworkService.
Moreover, not all tests are run with NavigationMojoResponse.
Hopefully, as soon as https://chromium-review.googlesource.com/c/chromium/src/+/959016 will land, it will be the case.

The reverted CL has removed URLLoaderCompletionStatus.exists_in_cache. It memorize |response_was_cached_| in 
1) NavigationURLLoaderNetworkService::OnResponseStarted() and reuse it in 
2) NavigationURLLoaderNetworkSercice::OnComplete()

But it turns out that 2) can be called without 1) being called before. It causes NavigationURLLoaderDelegate::OnRequestFailed to be called with |has_state_copy_in_cache| == false instead of true.
Cc: arthurso...@chromium.org

Comment 9 by jam@chromium.org, Mar 21 2018

Owner: cco3@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5904f060dea9d9cecb9afb378a68a17fd4e8e25

commit d5904f060dea9d9cecb9afb378a68a17fd4e8e25
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Mar 23 19:43:57 2018

Change WebContentsObserver::SubresourceResponseStarted to load complete

Changing the WebContentsObserver::SubresourceResponseStarted to
SubresourceLoadComplete. This is going to be used to support page load
metrics with the network service.

Note that SubresourceResponseStarted in frame.mojom is kept, as it is
used by the SSLManager. It's implementation is kept in WebContentsImpl
and its parameters are changed to only what's needed for that use case.

Bug: 816684
Change-Id: I78fa4b0d7f44cfb0a5e98a7fc008fb7a17f8aae4
Reviewed-on: https://chromium-review.googlesource.com/967370
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545558}
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/common/frame.mojom
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/public/common/subresource_load_info.mojom
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/renderer/loader/resource_dispatcher.h
[add] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/test/data/page_with_cached_subresource.html
[modify] https://crrev.com/d5904f060dea9d9cecb9afb378a68a17fd4e8e25/content/test/test_render_frame.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb2025ae3516f5f7442401a8ce84f3c099de7de9

commit bb2025ae3516f5f7442401a8ce84f3c099de7de9
Author: Conley Owens <cco3@chromium.org>
Date: Fri Mar 23 23:34:00 2018

Report was_cached in SubresourceLoadInfo

This change adds a boolean `was_cached` to the SubresourceLoadInfo
struct. This lets consumers know whether or not the response was
fetched from the network cache. Notably, this is important for
recording page load metrics when the Network Service is enabled.

This reverts commit 0b2b1a92072144890a713700be568c9fc3e520c4.

Issues in the previous commit are fixed by retaining the exists_in_cache
field.

In a many cases when NavigationURLLoaderDelegate::OnRequestFailed() is
called, NavigationURLLoaderNetworkService::OnResponseStarted() has not
been called. In these cases, we cannot rely on using a stored
was_cached value, since it may not be properly updated.

BUG=816684, 822237 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0beb72b825ae0a12122170cec2e4f4358dda58af
Reviewed-on: https://chromium-review.googlesource.com/966792
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545626}
[modify] https://crrev.com/bb2025ae3516f5f7442401a8ce84f3c099de7de9/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/bb2025ae3516f5f7442401a8ce84f3c099de7de9/content/public/common/subresource_load_info.mojom
[modify] https://crrev.com/bb2025ae3516f5f7442401a8ce84f3c099de7de9/content/renderer/loader/resource_dispatcher.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b69dc07eb52c9ceb258aff3351cd6f5795c9412

commit 7b69dc07eb52c9ceb258aff3351cd6f5795c9412
Author: Conley Owens <cco3@chromium.org>
Date: Mon Mar 26 22:21:52 2018

Report mime_type in SubresourceLoadInfo

This change adds a string `mime_type` to the list of fields in
SubresourceLoadInfo.  Notably, this is important for recording page
load metrics when the Network Service is enabled.

BUG=816684

Change-Id: Ie95bd46074f2a0f915eb8378800afa0f5ed46ecd
Reviewed-on: https://chromium-review.googlesource.com/963312
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545877}
[modify] https://crrev.com/7b69dc07eb52c9ceb258aff3351cd6f5795c9412/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/7b69dc07eb52c9ceb258aff3351cd6f5795c9412/content/public/common/subresource_load_info.mojom
[modify] https://crrev.com/7b69dc07eb52c9ceb258aff3351cd6f5795c9412/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/7b69dc07eb52c9ceb258aff3351cd6f5795c9412/content/renderer/loader/resource_dispatcher.h

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/309dda82963e6c9a5c155ee323f97c8cddc2b2d5

commit 309dda82963e6c9a5c155ee323f97c8cddc2b2d5
Author: Conley Owens <cco3@chromium.org>
Date: Thu Mar 29 01:07:46 2018

Report network_accessed in SubresourceLoadInfo

This change adds a bool `network_accessed` to the list of fields in
SubresourceLoadInfo.  Notably, this is important for recording page
load metrics when the Network Service is enabled.

BUG=816684

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0192a50584da4a932da98ebd0a84f4c126836ce1
Reviewed-on: https://chromium-review.googlesource.com/963313
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546686}
[modify] https://crrev.com/309dda82963e6c9a5c155ee323f97c8cddc2b2d5/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/309dda82963e6c9a5c155ee323f97c8cddc2b2d5/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/309dda82963e6c9a5c155ee323f97c8cddc2b2d5/content/public/common/resource_load_info.mojom
[modify] https://crrev.com/309dda82963e6c9a5c155ee323f97c8cddc2b2d5/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/309dda82963e6c9a5c155ee323f97c8cddc2b2d5/content/renderer/loader/resource_dispatcher.h
[modify] https://crrev.com/309dda82963e6c9a5c155ee323f97c8cddc2b2d5/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/309dda82963e6c9a5c155ee323f97c8cddc2b2d5/services/network/public/cpp/resource_response.cc
[modify] https://crrev.com/309dda82963e6c9a5c155ee323f97c8cddc2b2d5/services/network/public/cpp/resource_response_info.cc
[modify] https://crrev.com/309dda82963e6c9a5c155ee323f97c8cddc2b2d5/services/network/public/cpp/resource_response_info.h
[modify] https://crrev.com/309dda82963e6c9a5c155ee323f97c8cddc2b2d5/services/network/url_loader.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8642f95b91c3d8236e4289fc2db4367e77cb88f5

commit 8642f95b91c3d8236e4289fc2db4367e77cb88f5
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Mar 30 22:24:53 2018

Add request_id to content.mojom.SubresourceLoadInfo

Adds the request_id parameter to content.mojom.SubresourceLoadInfo.

Bug: 816684
Change-Id: I4701cad13e1648bdf350137a435572ea1278884f
Reviewed-on: https://chromium-review.googlesource.com/978868
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547287}
[modify] https://crrev.com/8642f95b91c3d8236e4289fc2db4367e77cb88f5/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/8642f95b91c3d8236e4289fc2db4367e77cb88f5/content/public/common/resource_load_info.mojom
[modify] https://crrev.com/8642f95b91c3d8236e4289fc2db4367e77cb88f5/content/renderer/loader/resource_dispatcher.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd4ba282cfefa418ea6a3d62bc8183203df43384

commit dd4ba282cfefa418ea6a3d62bc8183203df43384
Author: Conley Owens <cco3@chromium.org>
Date: Mon Apr 02 21:48:30 2018

Report priority in ResourceLoadInfo

This change adds `priority` to the list of fields in
ResourceLoadInfo.  Notably, this is important for recording page
load metrics when the Network Service is enabled.

BUG=816684

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I47fc9bf91ea76ee38acd8bb2bf485a21e88f455f
Reviewed-on: https://chromium-review.googlesource.com/986622
Commit-Queue: Conley Owens <cco3@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547528}
[modify] https://crrev.com/dd4ba282cfefa418ea6a3d62bc8183203df43384/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/dd4ba282cfefa418ea6a3d62bc8183203df43384/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/dd4ba282cfefa418ea6a3d62bc8183203df43384/content/public/common/resource_load_info.mojom
[modify] https://crrev.com/dd4ba282cfefa418ea6a3d62bc8183203df43384/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/dd4ba282cfefa418ea6a3d62bc8183203df43384/content/renderer/loader/resource_dispatcher.h
[modify] https://crrev.com/dd4ba282cfefa418ea6a3d62bc8183203df43384/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/dd4ba282cfefa418ea6a3d62bc8183203df43384/services/network/public/cpp/resource_response_info.cc
[modify] https://crrev.com/dd4ba282cfefa418ea6a3d62bc8183203df43384/services/network/public/cpp/resource_response_info.h
[modify] https://crrev.com/dd4ba282cfefa418ea6a3d62bc8183203df43384/services/network/url_loader.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a869ea9b5bbd7b5cb0683c8fcb895f4dcd174826

commit a869ea9b5bbd7b5cb0683c8fcb895f4dcd174826
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Apr 03 00:31:34 2018

Add original_url, request_start and net_error to ResourceLoadInfo

This CL adds the original_url, request_start and net_error to
ResourceLoadInfo.

Bug: 816684
Change-Id: Ic4659292100165a054c2a5b5adfde7d3c207bc03
Reviewed-on: https://chromium-review.googlesource.com/988808
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547580}
[modify] https://crrev.com/a869ea9b5bbd7b5cb0683c8fcb895f4dcd174826/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/a869ea9b5bbd7b5cb0683c8fcb895f4dcd174826/content/public/common/resource_load_info.mojom
[modify] https://crrev.com/a869ea9b5bbd7b5cb0683c8fcb895f4dcd174826/content/renderer/loader/resource_dispatcher.cc
[add] https://crrev.com/a869ea9b5bbd7b5cb0683c8fcb895f4dcd174826/content/test/data/page_with_image_redirect.html

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8c74f51bafd5be8b99f3640cd9bce07695ca643

commit a8c74f51bafd5be8b99f3640cd9bce07695ca643
Author: Jay Civelli <jcivelli@google.com>
Date: Sat Apr 14 17:25:46 2018

Add always_access_network to content.mojom.ResourceLoadInfo

Adding always_access_network to the content.mojom.ResourceLoadInfo.

Bug: 816684
Change-Id: If4f53330199cf3487379ecdb8b8bfb5168f97f89
Reviewed-on: https://chromium-review.googlesource.com/1000719
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550899}
[modify] https://crrev.com/a8c74f51bafd5be8b99f3640cd9bce07695ca643/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/a8c74f51bafd5be8b99f3640cd9bce07695ca643/content/public/common/resource_load_info.mojom
[modify] https://crrev.com/a8c74f51bafd5be8b99f3640cd9bce07695ca643/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/a8c74f51bafd5be8b99f3640cd9bce07695ca643/content/renderer/loader/resource_dispatcher.h

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8c74f51bafd5be8b99f3640cd9bce07695ca643

commit a8c74f51bafd5be8b99f3640cd9bce07695ca643
Author: Jay Civelli <jcivelli@google.com>
Date: Sat Apr 14 17:25:46 2018

Add always_access_network to content.mojom.ResourceLoadInfo

Adding always_access_network to the content.mojom.ResourceLoadInfo.

Bug: 816684
Change-Id: If4f53330199cf3487379ecdb8b8bfb5168f97f89
Reviewed-on: https://chromium-review.googlesource.com/1000719
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550899}
[modify] https://crrev.com/a8c74f51bafd5be8b99f3640cd9bce07695ca643/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/a8c74f51bafd5be8b99f3640cd9bce07695ca643/content/public/common/resource_load_info.mojom
[modify] https://crrev.com/a8c74f51bafd5be8b99f3640cd9bce07695ca643/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/a8c74f51bafd5be8b99f3640cd9bce07695ca643/content/renderer/loader/resource_dispatcher.h

Project Member

Comment 19 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd6fa0b51fefcc9a38f5bd620ca9c27fc1b4e84d

commit fd6fa0b51fefcc9a38f5bd620ca9c27fc1b4e84d
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Apr 17 18:13:00 2018

Add redirect info to ResourceLoadInfo

Adding information about redirects when notifying a resource was loaded.

Bug: 816684
Change-Id: Ice12ad0bad3e38fae0af60cd932e76a26d827ed4
Reviewed-on: https://chromium-review.googlesource.com/1014664
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551394}
[modify] https://crrev.com/fd6fa0b51fefcc9a38f5bd620ca9c27fc1b4e84d/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/fd6fa0b51fefcc9a38f5bd620ca9c27fc1b4e84d/content/public/common/resource_load_info.mojom
[modify] https://crrev.com/fd6fa0b51fefcc9a38f5bd620ca9c27fc1b4e84d/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/fd6fa0b51fefcc9a38f5bd620ca9c27fc1b4e84d/content/renderer/loader/resource_dispatcher.h

Project Member

Comment 20 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301

commit 153e5b9cbc5f2ebe06ebb2e32b745a41c8102301
Author: Conley Owens <cco3@chromium.org>
Date: Thu Apr 19 20:05:32 2018

Report load_timing_info in SubresourceLoadInfo

This change adds a `load_timing_info` to the list of fields
in SubresourceLoadInfo.  Notably, this is important for recording
page load metrics when the Network Service is enabled.

This change also removes `request_start`, since `load_timing_info`
contains the same field.

BUG=816684

Change-Id: I3b044c160f28155d81e99c6a84598e270ba78077
Reviewed-on: https://chromium-review.googlesource.com/1005963
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552136}
[modify] https://crrev.com/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301/content/public/common/BUILD.gn
[add] https://crrev.com/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301/content/public/common/load_timing_info.mojom
[add] https://crrev.com/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301/content/public/common/load_timing_info.typemap
[add] https://crrev.com/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301/content/public/common/load_timing_info_struct_traits.cc
[add] https://crrev.com/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301/content/public/common/load_timing_info_struct_traits.h
[modify] https://crrev.com/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301/content/public/common/resource_load_info.mojom
[modify] https://crrev.com/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301/content/public/common/typemaps.gni
[modify] https://crrev.com/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/153e5b9cbc5f2ebe06ebb2e32b745a41c8102301/content/renderer/loader/resource_dispatcher.h

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52a633053d96a94d85daabadde6ede178681f7b2

commit 52a633053d96a94d85daabadde6ede178681f7b2
Author: Jay Civelli <jcivelli@google.com>
Date: Mon Apr 30 22:39:55 2018

Add is_main_frame to ResourceLoadInfo

This CL adds an is_main_frame member to the
content.mojom.ResourceLoadInfo. It is needed to switch the preconnect
predictor to using the network service.

Bug: 816684
Change-Id: Id053130c3269923d7465ec6fc11579011b3910b5
Reviewed-on: https://chromium-review.googlesource.com/1033730
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554905}
[modify] https://crrev.com/52a633053d96a94d85daabadde6ede178681f7b2/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/52a633053d96a94d85daabadde6ede178681f7b2/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/52a633053d96a94d85daabadde6ede178681f7b2/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/52a633053d96a94d85daabadde6ede178681f7b2/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/52a633053d96a94d85daabadde6ede178681f7b2/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/52a633053d96a94d85daabadde6ede178681f7b2/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/52a633053d96a94d85daabadde6ede178681f7b2/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/52a633053d96a94d85daabadde6ede178681f7b2/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/52a633053d96a94d85daabadde6ede178681f7b2/content/public/browser/web_contents_observer.h

Owner: jcivelli@chromium.org
Status: Started (was: Assigned)
Blocking: 803911

Comment 25 by dxie@chromium.org, May 22 2018

Labels: -Pri-3 Proj-Servicification-Canary OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1

Comment 26 by dxie@google.com, Jun 29 2018

Status: Available (was: Started)

Comment 27 by dxie@google.com, Jun 29 2018

Owner: ----
 Issue 803911  has been merged into this issue.
Blockedon: 824974
Owner: cduvall@chromium.org
Status: Started (was: Available)
Blockedon: 842445
Project Member

Comment 32 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36164bd9230614c1425bcf4655e2a8c1da1fbd9d

commit 36164bd9230614c1425bcf4655e2a8c1da1fbd9d
Author: Clark DuVall <cduvall@chromium.org>
Date: Thu Aug 09 22:49:08 2018

Track page load metrics with network service

This uses the strategy suggested in  crbug.com/842445#c10  to map the
renderer request IDs to global request IDs so PageLoadMetrics can
associate ResourceLoadComplete events with the correct PageLoadTracker.

The LoadingMetricsFailed test is still failing because
DidFinishNavigation is called before ResourceLoadComplete, which means
the PageLoadTracker has already been destroyed before we can track the
failed request. From the discussion in  crbug.com/842445 , this doesn't
seem like a big deal.

Bug:  842445 , 816684
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ifb1c0d689840f626c0612ddab26a10d8ea9eb078
Reviewed-on: https://chromium-review.googlesource.com/1155800
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581942}
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/chrome/browser/net/network_request_metrics_browsertest.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/chrome/browser/predictors/loading_predictor_tab_helper.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/chrome/browser/predictors/loading_predictor_tab_helper.h
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/chrome/browser/predictors/loading_predictor_tab_helper_unittest.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/common/frame_messages.h
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/renderer/loader/web_url_loader_impl.h
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/renderer/loader/weburlresponse_extradata_impl.h
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/36164bd9230614c1425bcf4655e2a8c1da1fbd9d/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Cc: ryansturm@chromium.org jkarlin@chromium.org bmcquade@chromium.org
Labels: -Pri-1 -Proj-Servicification-Canary Proj-Servicification Pri-2
This is complete except for page load metrics for failed navigations. There was some discussion in  issue 842445  about whether this is needed or not. I'm going to close that bug and we can continue that discussion here.

For now, I'll leave this bug open, but remove it from network service canary blockers. When we decide if failed navs are necessary or not, we can either close this or find a solution.
Thanks!
Labels: Hotlist-KnownIssue
Blockedon: 875298

Sign in to add a comment