Many test extensions (e.g., extensions in chrome/test/data/extensions) are using manifest v1. We should update them all to manifest v2 (or remove them, if they are really manifest v1 specific).
Good
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48879f486c49cdc46432f88a9cb241cf175031d3 commit 48879f486c49cdc46432f88a9cb241cf175031d3 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 01 07:14:01 2018 [Extensions] Update a bunch of tests to manifest v2 We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates the majority of manifest.json files under chrome/test/data/extensions. This CL only modifies files that update cleanly (i.e., no other test updates necessary). A separate CL will address those. Bug: 816679 Change-Id: I0ae5a47efd9929c5db2c74d58e4d04de7099ef1c Reviewed-on: https://chromium-review.googlesource.com/938261 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540081} [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/activity_log_app/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/events/webview_events/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/extension_resource_request_policy/hosted_app/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/get_display_path/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/get_display_path_prettify/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/get_volume_list/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/get_volume_list_not_kiosk_session/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/get_writable_file_entry/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/get_writable_file_entry_with_write/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/get_writable_root_entry/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/invalid_choose_file_type/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/is_writable_file_entry/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/is_writable_file_entry_with_write/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/on_volume_list_changed/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_background/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_cancel/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_directory/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_directory_cancel/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_directory_with_only_write/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_directory_with_write/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_directory_without_permission/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_existing/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_existing_with_write/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_multiple_existing/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_multiple_with_suggested_name/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_multiple_writable_existing_with_write/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_writable_existing/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/open_writable_existing_with_write/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/request_file_system_background/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/request_file_system_not_chromeos/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/request_file_system_not_kiosk_session/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/request_file_system_not_whitelisted_component/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/request_file_system_read_only/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/request_file_system_user_reject/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/request_file_system_whitelisted_component/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/request_file_system_writable/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/restore_directory/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/restore_entry/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/retain_directory/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/retain_entry/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/save_background/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/save_cancel/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/save_existing/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/save_existing_with_write/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/save_multiple/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/save_new/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/file_system/save_new_with_write/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/image_writer_private/list_devices/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/image_writer_private/write_from_file/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/lazy_events/new_event_in_new_version/v1/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/lazy_events/new_event_in_new_version/v2/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/lazy_events/on_installed/v1/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/lazy_events/on_installed/v2/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/lazy_events/on_installed_permissions_increase/v1/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/lazy_events/on_installed_permissions_increase/v2/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/management/packaged_app/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/media_galleries/access_attached/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/media_galleries/copy_to_access/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/media_galleries/delete_access/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/media_galleries/gallerywatch/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/media_galleries/media_metadata/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/media_galleries/no_access/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/media_galleries/no_galleries/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/media_galleries/no_galleries_copy_to/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/media_galleries/read_access/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/media_galleries/tourl/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/native_bindings/instance_of/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/native_bindings/platform_app/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/notifications/api/basic_usage/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/notifications/api/by_user/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/notifications/api/csp/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/notifications/api/events/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/notifications/api/partial_update/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/notifications/api/permission/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/notifications/api/require_interaction/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/notifications/api/unload/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/notifications/api/user_gesture/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/runtime/get_package_directory/app/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/runtime/on_restart_required/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/serial/api/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/serial/real_hardware/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/serial/real_hardware_fail/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/socket/api/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/socket/unload/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/system/get_update_status/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/usb_manual/list_interfaces/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/webstore_private/app/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/webstore_private/extension/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/api_test/webstore_private/localized_extension/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/app_update/v1/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/app_update/v2/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/autoupdate/v1/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/autoupdate/v2/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/autoupdate/v3/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/bad/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/bad/bad_encoding/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/browsertest/browser_action_popup/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/browsertest/page_action_popup/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/fullscreen_app/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/install/install_older_version/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/install/install_same_version/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/install/install_v2/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/kiosk/kiosk_only/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/l10n/cdakfjkehipfnofphlponafnbnglaafl/1.0/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/l10n/jhkccedbcahooljabgejipmdkcojbijg/1.0/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/l10n/lgpnlbnlajcjdkakbbnfcgkdfggonpic/1.0/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/packaged_app/component_oauth2/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/app_icon/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/app_view/bad_app/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/app_view/guest_app/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/app_view/host_app/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/app_view/shim/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/background_page_navigation/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/component/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/context_menu/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/context_menu_click/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/disabled_window_properties/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/extension_view/creation/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/extension_view/extension_attribute/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/extension_view/load_api/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/extension_view/src_attribute/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/get_display_path/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/iframes/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/isolation/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_2/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_application_octet_stream/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_file/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_file_by_extension/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_file_by_extension_and_type/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_file_with_any_extension/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_file_with_no_extension/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_invalid/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_new_file/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_no_intent/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_nothing/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_wrong_extension/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/launch_wrong_type/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/leave_fullscreen/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/load_and_launch_file/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/messaging/app1/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/minimal/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/minimal_id/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/mutation_events/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/navigation/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/oauth2/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/open_link/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/optional_permission_request/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/outer_bounds/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/prevent_leave_fullscreen/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/prevent_leave_fullscreen_old/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/print_api/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/reinstall_data_cleanup/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/reload/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/restart_device/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/restore_state/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/restrictions/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/speech/background_page/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/speech/background_page_no_permission/manifest.json [modify] https://crrev.com/48879f486c49cdc46432f88a9cb241cf175031d3/chrome/test/data/extensions/platform_apps/storage/manif
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10137eb37f4672b1ee6f84dac0c0c6fe514c9b36 commit 10137eb37f4672b1ee6f84dac0c0c6fe514c9b36 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Sat Mar 03 01:19:40 2018 [Extensions] Update more test extensions to manifest v2 Update chrome/test/data/extensions/permissions_increase/* to manifest v2. This required changing background_page to background. Bug: 816679 Change-Id: I99afd26749acf1c7d8bf9b737200370de5324ba5 Reviewed-on: https://chromium-review.googlesource.com/946549 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540704} [modify] https://crrev.com/10137eb37f4672b1ee6f84dac0c0c6fe514c9b36/chrome/test/data/extensions/permissions_increase/v1/manifest.json [modify] https://crrev.com/10137eb37f4672b1ee6f84dac0c0c6fe514c9b36/chrome/test/data/extensions/permissions_increase/v2/manifest.json [modify] https://crrev.com/10137eb37f4672b1ee6f84dac0c0c6fe514c9b36/chrome/test/data/extensions/permissions_increase/v3/manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e60b70bd53a4e132943c4d6e7a0ff9be552ed09b commit e60b70bd53a4e132943c4d6e7a0ff9be552ed09b Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Sat Mar 03 02:49:42 2018 [Extensions] Update more test extensions to manifest v2 Update chrome/test/data/extensions/api_test/system to manifest v2. This involved complying to manifest v2's CSP requirements. Bug: 816679 Change-Id: I14b3f139770722a7312786c582ca0e74fef892db Reviewed-on: https://chromium-review.googlesource.com/946906 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540728} [modify] https://crrev.com/e60b70bd53a4e132943c4d6e7a0ff9be552ed09b/chrome/test/data/extensions/api_test/system/get_incognito_mode_availability/manifest.json [delete] https://crrev.com/97a8accfcb1462c88d5e412c5d5a62300956769e/chrome/test/data/extensions/api_test/system/get_incognito_mode_availability/test.html [add] https://crrev.com/e60b70bd53a4e132943c4d6e7a0ff9be552ed09b/chrome/test/data/extensions/api_test/system/get_incognito_mode_availability/test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f commit 5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 06 14:34:59 2018 [Extensions] Update extensions manifests to manifest v2 We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates the majority of manifest files under extensions/test/data, excluding those in manifest_tests. This CL only modifies files that update cleanly (i.e., no other test updates necessary). A separate CL will address those. Bug: 816679 Change-Id: I68c95cf792d8ac708456219b7a5b7b492c330d43 Reviewed-on: https://chromium-review.googlesource.com/950234 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541098} [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/audio/add_nodes/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/audio/input_mute_change/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/audio/output_mute_change/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/audio/remove_nodes/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/audio/volume_change/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/display_source/api/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/dns/api/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/hid/add_event/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/hid/api/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/hid/get_user_selected_devices/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/hid/remove_event/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/add_event/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/device_handling/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/get_user_selected_devices/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/invalid_length_transfer/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/invalid_timeout/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/list_interfaces/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/remove_event/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/reset_device/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/set_configuration/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/transfer_event/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/transfer_failure/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/api_test/usb/zero_length_transfer/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/sockets_tcp/api/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/sockets_tcp_server/api/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/sockets_tcp_server/unload/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/system/cpu/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/system/display/info/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/system/display/overscan/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/system/display/overscan_no_complete/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/system/memory/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/system/network/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/unpacker/empty_default_locale/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/unpacker/good_l10n/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/unpacker/has_default_missing_locales/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/unpacker/invalid_default_locale/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/unpacker/invalid_messages_file/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/unpacker/missing_default_data/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/unpacker/missing_default_has_locales/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/unpacker/missing_messages_file/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/unpacker/no_l10n/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/unpacker/no_locale_data/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/web_view/accept_touch_events/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/web_view/close_on_loadcommit/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/web_view/display_none_set_src/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/web_view/inside_iframe/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/web_view/media_access/check/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/web_view/media_access/deny/manifest.json [modify] https://crrev.com/5c0ab82ecd6c0bc2dde46f1ff9f3ca31adab559f/extensions/test/data/web_view/visibility_changed/manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8dd0ac163bfd93584c7df4a676a558b4a9436c67 commit 8dd0ac163bfd93584c7df4a676a558b4a9436c67 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 06 21:26:21 2018 [Extensions] Update Extension Manifest Tests to manifest v2 We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates the majority of manifest files under extensions/test/data/manifest_tests (which are not usually named manifest.json). All these manifests updated cleanly. Bug: 816679 Change-Id: I5d36f66ac19541b413915a027297ca7cfd359604 Reviewed-on: https://chromium-review.googlesource.com/950231 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541194} [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/default_locale_invalid.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/default_locale_valid.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_invalid_extension.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_invalid_extension_element.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_invalid_handlers.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_invalid_include_directories.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_invalid_no_type_or_extension.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_invalid_not_app.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_invalid_too_many.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_invalid_type.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_invalid_type_element.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_invalid_verb.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/file_handlers_valid.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/incognito_not_allowed.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/incognito_split.json [modify] https://crrev.com/8dd0ac163bfd93584c7df4a676a558b4a9436c67/extensions/test/data/manifest_tests/minimal.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f501cb347ad83c44d35e49a1ebd546ed87f33b2 commit 8f501cb347ad83c44d35e49a1ebd546ed87f33b2 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 07 02:15:16 2018 [Extensions] Update script_and_capture tests to manifest v2 We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates manifest files under chrome/test/data/extensions/script_and_capture (which are not usually named manifest.json). All files updated cleanly. Bug: 816679 Change-Id: I96cce6762c72eda98148d5aa49a57b2703fe9b63 Reviewed-on: https://chromium-review.googlesource.com/952363 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541290} [modify] https://crrev.com/8f501cb347ad83c44d35e49a1ebd546ed87f33b2/chrome/test/data/extensions/script_and_capture/extension_chrome_favicon_wildcard.json [modify] https://crrev.com/8f501cb347ad83c44d35e49a1ebd546ed87f33b2/chrome/test/data/extensions/script_and_capture/extension_component_all.json [modify] https://crrev.com/8f501cb347ad83c44d35e49a1ebd546ed87f33b2/chrome/test/data/extensions/script_and_capture/extension_component_google.json [modify] https://crrev.com/8f501cb347ad83c44d35e49a1ebd546ed87f33b2/chrome/test/data/extensions/script_and_capture/extension_http_favicon.json [modify] https://crrev.com/8f501cb347ad83c44d35e49a1ebd546ed87f33b2/chrome/test/data/extensions/script_and_capture/extension_regular_all.json [modify] https://crrev.com/8f501cb347ad83c44d35e49a1ebd546ed87f33b2/chrome/test/data/extensions/script_and_capture/extension_wildcard.json [modify] https://crrev.com/8f501cb347ad83c44d35e49a1ebd546ed87f33b2/chrome/test/data/extensions/script_and_capture/extension_wildcard_chrome.json [modify] https://crrev.com/8f501cb347ad83c44d35e49a1ebd546ed87f33b2/chrome/test/data/extensions/script_and_capture/extension_wildcard_settings.json [modify] https://crrev.com/8f501cb347ad83c44d35e49a1ebd546ed87f33b2/chrome/test/data/extensions/script_and_capture/tab_specific.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb commit b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 07 04:39:30 2018 [Extensions] Update permissions tests to manifest v2 We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates manifest files under chrome/test/data/extensions/permissions (which are not usually named manifest.json). All files updated cleanly. Bug: 816679 Change-Id: I0a4e7a5b25b1e299009f891adefe04190d0f6417 Reviewed-on: https://chromium-review.googlesource.com/952374 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#541329} [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/content_script_all_urls.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/content_script_file_scheme.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/content_script_http_scheme.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/many-apis.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/many-hosts.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/more-than-3-hosts.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/permissions_all_urls.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/permissions_file_scheme.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/permissions_http_scheme.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/platform_app_all_urls.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/platform_app_hosts.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/web_request_all_host_permissions.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/web_request_com_host_permissions.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/web_request_no_host.json [modify] https://crrev.com/b3876818e9ef2da29eeeb00eb38a6ea3adbfc2bb/chrome/test/data/extensions/permissions/web_request_not_all_host_permissions.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffad65b369389b624a7a609553ea59861cf7b897 commit ffad65b369389b624a7a609553ea59861cf7b897 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 07 16:57:34 2018 [Extensions] Update miscellaneous tests to manifest v2 We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates miscellaneous manifest files under chrome/test/data/extensions/ that weren't named manifest.json and weren't in a subdirectory to warrant updating them all in a patch. All files updated cleanly. Bug: 816679 Change-Id: I4e7132e528bc8a760ba77f5665ea8e900d936ddf Reviewed-on: https://chromium-review.googlesource.com/952290 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541476} [modify] https://crrev.com/ffad65b369389b624a7a609553ea59861cf7b897/chrome/test/data/extensions/absolute_path/absolute.json [modify] https://crrev.com/ffad65b369389b624a7a609553ea59861cf7b897/chrome/test/data/extensions/api_test/webstore_private/bundle/app1.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1347fd7cbed7d0a55d38779421837eafc765f712 commit 1347fd7cbed7d0a55d38779421837eafc765f712 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 07 17:29:43 2018 [Extensions] Update Page Action Manifest Tests to manifest v2 We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates the majority of manifest files under chrome/test/data/extensions/page_actions (which are not usually named manifest.json). This CL only modifies files that update cleanly (i.e., no other test updates necessary). A separate CL will address those. Bug: 816679 Change-Id: I5bbb98be75c9a1912e3221095d8aa4db1ba6f7d2 Reviewed-on: https://chromium-review.googlesource.com/952270 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541484} [modify] https://crrev.com/1347fd7cbed7d0a55d38779421837eafc765f712/chrome/test/data/extensions/page_action/page_action_default_popup.json [modify] https://crrev.com/1347fd7cbed7d0a55d38779421837eafc765f712/chrome/test/data/extensions/page_action/page_action_empty.json [modify] https://crrev.com/1347fd7cbed7d0a55d38779421837eafc765f712/chrome/test/data/extensions/page_action/page_action_empty_default_popup.json [modify] https://crrev.com/1347fd7cbed7d0a55d38779421837eafc765f712/chrome/test/data/extensions/page_action/page_action_new_format.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7596aa1a5efc11d9814dbe41b669c03f145565d commit a7596aa1a5efc11d9814dbe41b669c03f145565d Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 07 20:46:54 2018 [Extensions] Update Chrome Manifest Tests to manifest v2 We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates the majority of manifest files under chrome/test/data/extensions/manifest_tests (which are not usually named manifest.json). This CL only modifies files that update cleanly (i.e., no other test updates necessary). A separate CL will address those. Bug: 816679 Change-Id: Id8b03de2bd26a70d313e85cf56433e3788686e2d Reviewed-on: https://chromium-review.googlesource.com/950225 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541568} [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/background_allow_no_js_access.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/background_allow_no_js_access2.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/background_page.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/background_permission.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/content_script_chrome_url_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/content_script_match_pattern_not_string.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/content_script_yahoo.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/default_path_for_extent.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/devtools_extension.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/devtools_extension_url_invalid_type.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/evil_non_platform_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/exclude_matches.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/exclude_matches_empty.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/exclude_matches_invalid_host.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/exclude_matches_not_list.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/experimental.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_access_permission.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_access_permission_list.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_action_id.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_action_title.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_actions_1.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_actions_2.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_empty_access_permission_list.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_file_filters_1.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_file_filters_2.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_file_filters_url.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_value.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_missing_permission.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filebrowser_valid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filesystemprovider_missing_capabilities.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filesystemprovider_missing_permission.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/filesystemprovider_valid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/homepage_bad_schema.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/homepage_empty.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/homepage_externally_hosted.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/homepage_google_hosted.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/homepage_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/homepage_valid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/hosted_app_absolute_options.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/hosted_app_file_options.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/hosted_app_relative_options.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_icon_size.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_chrome_version_too_low.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_description_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_files_css_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_files_css_item_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_files_empty.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_files_js_empty_css_missing.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_files_js_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_files_js_item_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_icons_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_icons_path_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_locale_empty.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_locale_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_min_chrome_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_name_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_name_missing.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_options_url_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_permissions_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_permissions_item_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_1.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_2.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_4.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_5.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_script_files_missing.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_script_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_script_item_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_script_match_item_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_script_match_item_invalid_2.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_script_matches_empty.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_script_matches_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_script_matches_missing.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_short_name_empty.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_short_name_type.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_version_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_version_missing.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_invalid_version_name_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_app_minimum_chrome.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_app_requirements.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_minimal.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_minimum_chrome.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_name_no_rtl.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_name_strong_rtl.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_options.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_permissions.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_permissions_empty.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_permissions_unknown.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_platform_app_no_manifest_version.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_short_name.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/init_valid_version_name.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/isolated_app_valid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_default_platform_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_disabled_platform_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_enabled_extension.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_enabled_hosted_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_enabled_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_enabled_packaged_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_enabled_platform_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_only_extension.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_only_hosted_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_only_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_only_not_enabled.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_only_packaged_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/kiosk_only_platform_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_container_invalid_type.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_container_invalid_value.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_container_without_launch_url.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_default.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_height.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_height_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_height_negative.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_local_path.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_local_path_localized.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_panel.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_path_and_extent.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_path_and_url.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_path_invalid_localized.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_path_invalid_type.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_path_invalid_value.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_tab.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_url_invalid_localized.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_url_invalid_type_1.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_url_invalid_type_2.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_url_invalid_type_3.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_web_url_absolute.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_web_url_localized.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_web_url_relative.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_width.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_width_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_width_negative.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/launch_window.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/minimal.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/multiple_ui_surfaces.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/normalize_icon_paths.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/not_platform_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/offline_default_packaged_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/offline_default_platform_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/offline_default_platform_app_with_webview.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/offline_disabled_packaged_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/offline_enabled_extension.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/offline_enabled_hosted_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/offline_enabled_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/offline_enabled_packaged_app.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/old_unlimited_storage.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/override_history.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/override_invalid_page.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/override_new_tab.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/override_newtab_and_history.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/packaged_app_absolute_options.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/permission_chrome_resources_url.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/permission_chrome_url_invalid.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/platform_app_with_options_page.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/ports_in_content_scripts.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/ports_in_permissions.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/shared_module_about.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/shared_module_about_absolute.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/shared_module_about_invalid_type.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/tabs_extension.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/theme_color.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/theme_color_wrong_type.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/tts_engine_invalid_1.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/tts_engine_invalid_2.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/tts_engine_invalid_3.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/tts_engine_invalid_4.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe41b669c03f145565d/chrome/test/data/extensions/manifest_tests/tts_engine_invalid_5.json [modify] https://crrev.com/a7596aa1a5efc11d9814dbe
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d42648dd9f14c535b1e98a93e85d5a99bc9b0599 commit d42648dd9f14c535b1e98a93e85d5a99bc9b0599 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Mar 12 20:55:47 2018 [Extensions] Remove manifest v1 support for page actions In manifest v1, page actions had support for different keys, including a list of icons (instead of a single icon), "popup" (vs "default_popup"), "name" (vs "default_title"), "type" (deprecated), and "id" (deprecated). Remove parsing support for the deprecated keys. Update unit tests to manifest v2 where applicable, and remove manifest v1-specific tests. Bug: 816677 , 816679 Change-Id: Id4db2558e0f5b9006c89a0f3ef89aed230a7b359 Reviewed-on: https://chromium-review.googlesource.com/953179 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542590} [modify] https://crrev.com/d42648dd9f14c535b1e98a93e85d5a99bc9b0599/chrome/browser/extensions/extension_action.cc [modify] https://crrev.com/d42648dd9f14c535b1e98a93e85d5a99bc9b0599/chrome/browser/extensions/extension_action.h [modify] https://crrev.com/d42648dd9f14c535b1e98a93e85d5a99bc9b0599/chrome/common/extensions/api/extension_action/action_info.cc [modify] https://crrev.com/d42648dd9f14c535b1e98a93e85d5a99bc9b0599/chrome/common/extensions/api/extension_action/action_info.h [modify] https://crrev.com/d42648dd9f14c535b1e98a93e85d5a99bc9b0599/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc [modify] https://crrev.com/d42648dd9f14c535b1e98a93e85d5a99bc9b0599/chrome/test/data/extensions/page_action/page_action.json [delete] https://crrev.com/659dd8c260e08eb9bcda193b7787a2b47d31e315/chrome/test/data/extensions/page_action/page_action_empty_popup.json [delete] https://crrev.com/659dd8c260e08eb9bcda193b7787a2b47d31e315/chrome/test/data/extensions/page_action/page_action_invalid_name.json [delete] https://crrev.com/659dd8c260e08eb9bcda193b7787a2b47d31e315/chrome/test/data/extensions/page_action/page_action_invalid_name_no_title.json [modify] https://crrev.com/d42648dd9f14c535b1e98a93e85d5a99bc9b0599/chrome/test/data/extensions/page_action/page_action_invalid_title.json [delete] https://crrev.com/659dd8c260e08eb9bcda193b7787a2b47d31e315/chrome/test/data/extensions/page_action/page_action_new_format.json [delete] https://crrev.com/659dd8c260e08eb9bcda193b7787a2b47d31e315/chrome/test/data/extensions/page_action/page_action_no_icon.json [delete] https://crrev.com/659dd8c260e08eb9bcda193b7787a2b47d31e315/chrome/test/data/extensions/page_action/page_action_no_id.json [delete] https://crrev.com/659dd8c260e08eb9bcda193b7787a2b47d31e315/chrome/test/data/extensions/page_action/page_action_no_name.json [delete] https://crrev.com/659dd8c260e08eb9bcda193b7787a2b47d31e315/chrome/test/data/extensions/page_action/page_action_popup.json [delete] https://crrev.com/659dd8c260e08eb9bcda193b7787a2b47d31e315/chrome/test/data/extensions/page_action/page_action_popup_and_default_popup.json [delete] https://crrev.com/659dd8c260e08eb9bcda193b7787a2b47d31e315/chrome/test/data/extensions/page_action/page_action_type.json [modify] https://crrev.com/d42648dd9f14c535b1e98a93e85d5a99bc9b0599/extensions/common/manifest_constants.cc [modify] https://crrev.com/d42648dd9f14c535b1e98a93e85d5a99bc9b0599/extensions/common/manifest_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8 commit 7a1b3bb0f7aa68093639da976f3b4ecedd4585d8 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 27 00:25:49 2018 [Extensions] Remove manifest v1 support for accessible resources In manifest version 1, all extension resources were considered accessible by the web (i.e., could be embedded within or requested by a web page). In manifest v2, only resources explicitly specified in the web_accessible_resources key are accessible. Remove support for manifest v1, and always check the web accessible resources. Update unit tests to migrate relevant tests and remove tests for manifest v1-specific behavior. Bug: 816677 , 816679 Change-Id: Id0dd3ef75cd5d49e3f87e45ac3a8b19a00391146 Reviewed-on: https://chromium-review.googlesource.com/953177 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#545898} [modify] https://crrev.com/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8/chrome/browser/extensions/extension_protocols_unittest.cc [modify] https://crrev.com/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8/chrome/common/extensions/manifest_tests/extension_manifests_web_accessible_resources_unittest.cc [modify] https://crrev.com/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8/chrome/renderer/extensions/resource_request_policy.cc [delete] https://crrev.com/811d1a139265b7d8c94fc1690184de2351d9230f/chrome/test/data/extensions/manifest_tests/web_accessible_resources_3.json [delete] https://crrev.com/811d1a139265b7d8c94fc1690184de2351d9230f/chrome/test/data/extensions/manifest_tests/web_accessible_resources_4.json [rename] https://crrev.com/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8/chrome/test/data/extensions/manifest_tests/web_accessible_resources_none.json [rename] https://crrev.com/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8/chrome/test/data/extensions/manifest_tests/web_accessible_resources_pattern.json [rename] https://crrev.com/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8/chrome/test/data/extensions/manifest_tests/web_accessible_resources_single.json [rename] https://crrev.com/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8/chrome/test/data/extensions/manifest_tests/web_accessible_resources_wildcard.json [modify] https://crrev.com/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8/extensions/browser/extension_protocols.cc [modify] https://crrev.com/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8/extensions/browser/url_request_util.cc [modify] https://crrev.com/7a1b3bb0f7aa68093639da976f3b4ecedd4585d8/extensions/common/manifest_handlers/web_accessible_resources_info.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60c784b759508ed36a644304b541f0f10e61f1dd commit 60c784b759508ed36a644304b541f0f10e61f1dd Author: Ben Wells <benwells@chromium.org> Date: Tue Mar 27 04:34:58 2018 Revert "[Extensions] Remove manifest v1 support for accessible resources" This reverts commit 7a1b3bb0f7aa68093639da976f3b4ecedd4585d8. Reason for revert: Seems to have caused memory failures. Sample failure: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/8760 with this in the stack views::WidgetDelegate::GetAccessibleWindowTitle Original change's description: > [Extensions] Remove manifest v1 support for accessible resources > > In manifest version 1, all extension resources were considered > accessible by the web (i.e., could be embedded within or > requested by a web page). In manifest v2, only resources > explicitly specified in the web_accessible_resources key are > accessible. Remove support for manifest v1, and always check > the web accessible resources. > > Update unit tests to migrate relevant tests and remove tests for > manifest v1-specific behavior. > > Bug: 816677 , 816679 > Change-Id: Id0dd3ef75cd5d49e3f87e45ac3a8b19a00391146 > Reviewed-on: https://chromium-review.googlesource.com/953177 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545898} TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org Change-Id: Ifae57fc0f5cb2b738d48527af5e20c19eac5b0a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816677 , 816679 Reviewed-on: https://chromium-review.googlesource.com/981336 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#546010} [modify] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/chrome/browser/extensions/extension_protocols_unittest.cc [modify] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/chrome/common/extensions/manifest_tests/extension_manifests_web_accessible_resources_unittest.cc [modify] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/chrome/renderer/extensions/resource_request_policy.cc [rename] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/chrome/test/data/extensions/manifest_tests/web_accessible_resources_1.json [rename] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/chrome/test/data/extensions/manifest_tests/web_accessible_resources_2.json [copy] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/chrome/test/data/extensions/manifest_tests/web_accessible_resources_3.json [add] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/chrome/test/data/extensions/manifest_tests/web_accessible_resources_4.json [rename] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/chrome/test/data/extensions/manifest_tests/web_accessible_resources_5.json [rename] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/chrome/test/data/extensions/manifest_tests/web_accessible_resources_6.json [modify] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/extensions/browser/extension_protocols.cc [modify] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/extensions/browser/url_request_util.cc [modify] https://crrev.com/60c784b759508ed36a644304b541f0f10e61f1dd/extensions/common/manifest_handlers/web_accessible_resources_info.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f43c33174eff48032a5c6e88fd0e872c27478245 commit f43c33174eff48032a5c6e88fd0e872c27478245 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 27 19:54:17 2018 Reland "[Extensions] Remove manifest v1 support for accessible resources" This is a reland of 7a1b3bb0f7aa68093639da976f3b4ecedd4585d8 TBR=karandeepb@chromium.org (reland with no changes) Original change's description: > [Extensions] Remove manifest v1 support for accessible resources > > In manifest version 1, all extension resources were considered > accessible by the web (i.e., could be embedded within or > requested by a web page). In manifest v2, only resources > explicitly specified in the web_accessible_resources key are > accessible. Remove support for manifest v1, and always check > the web accessible resources. > > Update unit tests to migrate relevant tests and remove tests for > manifest v1-specific behavior. > > Bug: 816677 , 816679 > Change-Id: Id0dd3ef75cd5d49e3f87e45ac3a8b19a00391146 > Reviewed-on: https://chromium-review.googlesource.com/953177 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545898} Bug: 816677 , 816679 Change-Id: Ic26fb161878df83c40e92e2fa19dd3f698b4d62c Reviewed-on: https://chromium-review.googlesource.com/981090 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546215} [modify] https://crrev.com/f43c33174eff48032a5c6e88fd0e872c27478245/chrome/browser/extensions/extension_protocols_unittest.cc [modify] https://crrev.com/f43c33174eff48032a5c6e88fd0e872c27478245/chrome/common/extensions/manifest_tests/extension_manifests_web_accessible_resources_unittest.cc [modify] https://crrev.com/f43c33174eff48032a5c6e88fd0e872c27478245/chrome/renderer/extensions/resource_request_policy.cc [delete] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/chrome/test/data/extensions/manifest_tests/web_accessible_resources_3.json [delete] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/chrome/test/data/extensions/manifest_tests/web_accessible_resources_4.json [rename] https://crrev.com/f43c33174eff48032a5c6e88fd0e872c27478245/chrome/test/data/extensions/manifest_tests/web_accessible_resources_none.json [rename] https://crrev.com/f43c33174eff48032a5c6e88fd0e872c27478245/chrome/test/data/extensions/manifest_tests/web_accessible_resources_pattern.json [rename] https://crrev.com/f43c33174eff48032a5c6e88fd0e872c27478245/chrome/test/data/extensions/manifest_tests/web_accessible_resources_single.json [rename] https://crrev.com/f43c33174eff48032a5c6e88fd0e872c27478245/chrome/test/data/extensions/manifest_tests/web_accessible_resources_wildcard.json [modify] https://crrev.com/f43c33174eff48032a5c6e88fd0e872c27478245/extensions/browser/extension_protocols.cc [modify] https://crrev.com/f43c33174eff48032a5c6e88fd0e872c27478245/extensions/browser/url_request_util.cc [modify] https://crrev.com/f43c33174eff48032a5c6e88fd0e872c27478245/extensions/common/manifest_handlers/web_accessible_resources_info.cc
The following revision refers to this bug: https://chromium.googlesource.com/native_client/src/native_client.git/+/ab8b219c8b5578b860f128087190d201fe55e84d commit ab8b219c8b5578b860f128087190d201fe55e84d Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Mar 30 18:10:32 2018 [Native Client] Update chrome extension test The extension in the chrome_extension test is using manifest v1, which has been deprecated for more than five years. Update it to manifest v2. NOTRY=true Bug: chromium:816679 Change-Id: Ibab520e118db12cb084bd613584bcf7a387a57bf Reviewed-on: https://chromium-review.googlesource.com/988139 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> [modify] https://crrev.com/ab8b219c8b5578b860f128087190d201fe55e84d/tests/chrome_extension/background.html [add] https://crrev.com/ab8b219c8b5578b860f128087190d201fe55e84d/tests/chrome_extension/background.js [modify] https://crrev.com/ab8b219c8b5578b860f128087190d201fe55e84d/tests/chrome_extension/manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51671097a3ead788cd64b125fa8926357c824aff commit 51671097a3ead788cd64b125fa8926357c824aff Author: nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Mar 30 21:00:06 2018 Roll src/native_client/ 303fc9961..ab8b219c8 (1 commit) https://chromium.googlesource.com/native_client/src/native_client.git/+log/303fc9961cb4..ab8b219c8b55 $ git log 303fc9961..ab8b219c8 --date=short --no-merges --format='%ad %ae %s' 2018-03-30 rdevlin.cronin [Native Client] Update chrome extension test Created with: roll-dep src/native_client BUG= chromium:816679 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mseaborn@chromium.org Change-Id: If59f983fec378a86b8d1348db6aa995b374f676a Reviewed-on: https://chromium-review.googlesource.com/988244 Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547265} [modify] https://crrev.com/51671097a3ead788cd64b125fa8926357c824aff/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ffe6be48a0b094a06e653eb05113cc8058ae789 commit 0ffe6be48a0b094a06e653eb05113cc8058ae789 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 12 00:20:39 2018 [Extensions] Update app shim handler test to use manifest v2 Update extension_app_shim_handler_mac_unittest.cc to generate extensions with manifest_version 2. Bug: 816679 Change-Id: If39956a5b8b986da6d84957e91849cfe670346a0 Reviewed-on: https://chromium-review.googlesource.com/1008175 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549974} [modify] https://crrev.com/0ffe6be48a0b094a06e653eb05113cc8058ae789/chrome/browser/apps/app_shim/extension_app_shim_handler_mac_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db0cd1f0ad8f5f6cc3bc646d14c0ea9a02445350 commit db0cd1f0ad8f5f6cc3bc646d14c0ea9a02445350 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 12 01:09:09 2018 [Extensions] Update shortcuts provider test to use manifest v2 Update shortcuts_provider_extension_unittest.cc to generate extensions using manifest_version 2. Bug: 816679 Change-Id: I1d895e66c6ebadff948ff78690d1130fbc725f4f Reviewed-on: https://chromium-review.googlesource.com/1008603 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#549985} [modify] https://crrev.com/db0cd1f0ad8f5f6cc3bc646d14c0ea9a02445350/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08c1dd02c06ba3398d94322d67d90df0bf19cbb3 commit 08c1dd02c06ba3398d94322d67d90df0bf19cbb3 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 12 01:15:45 2018 [Extensions] Update notification system observer test to use manifest v2 Update notification_system_observer_unittest.cc to generate extensions with manifest_version 2. Bug: 816679 Change-Id: Ida57ff94738d3ec7fcfb207b8495d7a31d784a94 Reviewed-on: https://chromium-review.googlesource.com/1008607 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549990} [modify] https://crrev.com/08c1dd02c06ba3398d94322d67d90df0bf19cbb3/chrome/browser/notifications/notification_system_observer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c38732f8eb7cfdec0ab8817db3e986eb4e204179 commit c38732f8eb7cfdec0ab8817db3e986eb4e204179 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 12 05:35:00 2018 [Extensions] Remove obsolete storage manifest test ChromeManifestTest.StorageAPIManifestVersionAvailability tests that the chrome.storage API is not available to manifest v1 extensions. This behavior is now enforced (and much more thorouhgly tested) through the features unittests. Remove the test. Bug: 816679 Change-Id: I8e313127cd43885fab8b49a9a3acfb58dbf2d4c9 Reviewed-on: https://chromium-review.googlesource.com/1007624 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550023} [delete] https://crrev.com/966219da520d75de98c911daf79fdaf6c3f0f8e3/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc [modify] https://crrev.com/c38732f8eb7cfdec0ab8817db3e986eb4e204179/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbc15a3a0c4aadfa1277f2fbd25eb35590ba1708 commit cbc15a3a0c4aadfa1277f2fbd25eb35590ba1708 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 12 09:28:39 2018 [Extensions] Update some extensions browser tests to use manifest v2 Some extension browser tests generate extension objects at runtime. Update these to generate extensions with manifest_version: 2. Where it wasn't already used, also update these to use ExtensionBuilder, which uses manifest v2 by default. Bug: 816679 Bug: 756488 Change-Id: I7142d085ad9569dccd4e9b62e09c7a68da08e360 Reviewed-on: https://chromium-review.googlesource.com/1008633 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550113} [modify] https://crrev.com/cbc15a3a0c4aadfa1277f2fbd25eb35590ba1708/chrome/browser/extensions/api/sessions/sessions_apitest.cc [modify] https://crrev.com/cbc15a3a0c4aadfa1277f2fbd25eb35590ba1708/chrome/browser/extensions/extension_install_prompt_browsertest.cc [modify] https://crrev.com/cbc15a3a0c4aadfa1277f2fbd25eb35590ba1708/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36376da42c02265d7716639f32d968130b9c3921 commit 36376da42c02265d7716639f32d968130b9c3921 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 12 11:11:42 2018 [Extensions] Update background application list model test to use manifest v2 Update background_application_list_model_unittest.cc to generate extensions with manifest_version 2. Bug: 816679 Change-Id: Icb245afea008fb2bdf57ae20e7289539aa39724e Reviewed-on: https://chromium-review.googlesource.com/1008605 Commit-Queue: Drew Wilson <atwilson@chromium.org> Reviewed-by: Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550142} [modify] https://crrev.com/36376da42c02265d7716639f32d968130b9c3921/chrome/browser/background/background_application_list_model_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fa235b63f813db3edd77307d6c85c37ddb65606 commit 1fa235b63f813db3edd77307d6c85c37ddb65606 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 12 14:04:07 2018 [Extensions] Update extensions unittests to use manifest v2 A bunch of extension unittests generate extension objects at runtime. Update these to generate extensions with manifest_version: 2. Where trivial, update these to use ExtensionBuilder (if they weren't already), which uses manifest v2 by default. Bug: 816679 Bug: 756488 Change-Id: Iec80a5dd288452e70e5dbdd1902180611f6bbcca Reviewed-on: https://chromium-review.googlesource.com/1007501 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550180} [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/browser/extensions/extension_management_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/browser/extensions/extension_prefs_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/browser/extensions/extension_protocols_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/browser/extensions/extension_web_ui_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/browser/extensions/install_tracker_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/browser/extensions/permissions_based_management_policy_provider_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/browser/extensions/standard_management_policy_provider_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/browser/extensions/test_extension_prefs.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/browser/extensions/updater/extension_updater_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/common/extensions/permissions/permission_set_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/common/extensions/sync_type_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/test/data/extensions/manifest_tests/background_scripts.json [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/test/data/extensions/page_action/page_action.json [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/chrome/test/data/extensions/page_action/page_action_invalid_title.json [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/api/declarative/rules_registry_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/api/power/power_api_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/api/storage/settings_test_util.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/api_test_utils.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/api_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/app_window/app_window_geometry_cache_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/extension_registry_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/info_map_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/policy_check_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/requirements_checker_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/browser/runtime_data_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/common/api/declarative/declarative_manifest_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/common/extension_set_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/common/file_util_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/shell/browser/api/identity/identity_api_unittest.cc [modify] https://crrev.com/1fa235b63f813db3edd77307d6c85c37ddb65606/extensions/shell/browser/system_logs/shell_system_logs_fetcher_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/272d95714049d4b918fe2f4553e126624e3b4fe8 commit 272d95714049d4b918fe2f4553e126624e3b4fe8 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 12 14:28:55 2018 [Extensions] Update sync unittests to use manifest v2 Update profile_signin_confirmation_helper_unittest.cc and sync_extension_helper.cc to generate extensions with manifest_version 2. Bug: 816679 Change-Id: I302693e92b7925f900cd41b7fa3751a4a299a8cf Reviewed-on: https://chromium-review.googlesource.com/1008624 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550187} [modify] https://crrev.com/272d95714049d4b918fe2f4553e126624e3b4fe8/chrome/browser/sync/test/integration/sync_extension_helper.cc [modify] https://crrev.com/272d95714049d4b918fe2f4553e126624e3b4fe8/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a444099247c3510739135e9e0c49660e1feabcc4 commit a444099247c3510739135e9e0c49660e1feabcc4 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Apr 17 20:07:36 2018 [Extensions] Move browsertest exceptions for manifest v1 to leaf(ier) tests Instead of having ExtensionBrowserTest (and everything deriving from it) allow manifest v1 extensions, make ExtensionBrowserTest only allow these when the test class opts into it (via ExtensionBrowserTest::ShouldAllowLegacyExtensionManifests()). This will make it easier to chip away at these and remove usages. Bug: 816679 TBR=gab@chromium.org (trivial change in pref_hash_browsertest.cc) Change-Id: I771d5b96b96b49104cbcdd26e7b5f377c44153be Reviewed-on: https://chromium-review.googlesource.com/1014183 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551449} [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/api/identity/identity_apitest.cc [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/api/management/management_apitest.cc [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/api/management/management_browsertest.cc [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/api/tabs/tabs_test.cc [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/crx_installer_browsertest.cc [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/extension_browsertest.cc [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/extension_browsertest.h [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/extension_functional_browsertest.cc [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/external_install_error_browsertest.cc [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/webstore_installer_test.cc [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/extensions/webstore_installer_test.h [modify] https://crrev.com/a444099247c3510739135e9e0c49660e1feabcc4/chrome/browser/prefs/tracked/pref_hash_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec74271408212aa61c05ca284a267885d3d363a3 commit ec74271408212aa61c05ca284a267885d3d363a3 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 18 18:20:17 2018 [Extensions] Update ExtensionManagementApiTest to manifest v2 Update ExtensionManagementApiTest to manifest v2 and remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I0448ee64cbde9ed8431c30090d1f109e6d655fce Reviewed-on: https://chromium-review.googlesource.com/1014711 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551749} [modify] https://crrev.com/ec74271408212aa61c05ca284a267885d3d363a3/chrome/browser/extensions/api/management/management_apitest.cc [modify] https://crrev.com/ec74271408212aa61c05ca284a267885d3d363a3/chrome/test/data/extensions/api_test/management/no_permission/test.js [modify] https://crrev.com/ec74271408212aa61c05ca284a267885d3d363a3/chrome/test/data/extensions/api_test/management/test/basics.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2290d94aff9b25e3c92807b072240293d2172d5f commit 2290d94aff9b25e3c92807b072240293d2172d5f Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 18 19:08:37 2018 [Extensions] Update ExtensionTabsTest to manifest v2 Update ExtensionTabsTest to manifest v2 and remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ib718a2169cf42c81f640780884d9a824eca63534 Reviewed-on: https://chromium-review.googlesource.com/1014716 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551771} [modify] https://crrev.com/2290d94aff9b25e3c92807b072240293d2172d5f/chrome/browser/extensions/api/tabs/tabs_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43846d7661d00142e56770ba88ecf8a70bef2306 commit 43846d7661d00142e56770ba88ecf8a70bef2306 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 18 20:22:16 2018 [Extensions] Update IdentityTestWithSignin to manifest v2 Update IdentityTestWithSignin to manifest v2 and remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I0312986394cf10c58f31884284f7830df947feea Reviewed-on: https://chromium-review.googlesource.com/1014600 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551804} [modify] https://crrev.com/43846d7661d00142e56770ba88ecf8a70bef2306/chrome/browser/extensions/api/identity/identity_apitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62f2eeed8fc091e4d79c65f9ada6303bcdd96336 commit 62f2eeed8fc091e4d79c65f9ada6303bcdd96336 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 18 20:47:04 2018 [Extensions] Update ExtensionWebstorePrivateApiTest to manifest v2 Update ExtensionWebstorePrivateApiTest to manifest v2 and remove the allowance for manifest v1 extensions. Repackage two crx's used in the webstorePrivate API tests to be updated to manifest v2. Bug: 816679 Change-Id: I8ba99179c99b62c6ef49cf3aa8e7afab7dfacdf5 Reviewed-on: https://chromium-review.googlesource.com/1015081 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551813} [modify] https://crrev.com/62f2eeed8fc091e4d79c65f9ada6303bcdd96336/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc [modify] https://crrev.com/62f2eeed8fc091e4d79c65f9ada6303bcdd96336/chrome/test/data/extensions/api_test/webstore_private/extension.crx [modify] https://crrev.com/62f2eeed8fc091e4d79c65f9ada6303bcdd96336/chrome/test/data/extensions/api_test/webstore_private/localized_extension.crx
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0eb8141ea79103fee55a7fb7aebbc9dcc9dfaee7 commit 0eb8141ea79103fee55a7fb7aebbc9dcc9dfaee7 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 19 01:21:44 2018 [Extensions] Update WebstoreInstallerTests to manifest v2 Update WebstoreInstallerTests to manifest v2 and remove the allowance for manifest v1 extensions. Repackage the crx used in the webstore_inline_install API tests to be updated to manifest v2. Bug: 816679 Change-Id: Id38616cf30c70d886542d5b4d8112c8831372863 Reviewed-on: https://chromium-review.googlesource.com/1017582 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551910} [modify] https://crrev.com/0eb8141ea79103fee55a7fb7aebbc9dcc9dfaee7/chrome/browser/extensions/webstore_installer_test.cc [modify] https://crrev.com/0eb8141ea79103fee55a7fb7aebbc9dcc9dfaee7/chrome/browser/extensions/webstore_installer_test.h [modify] https://crrev.com/0eb8141ea79103fee55a7fb7aebbc9dcc9dfaee7/chrome/test/data/extensions/api_test/webstore_inline_install/extension.crx [modify] https://crrev.com/0eb8141ea79103fee55a7fb7aebbc9dcc9dfaee7/chrome/test/data/extensions/api_test/webstore_inline_install/inlineinstall/detail/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa [modify] https://crrev.com/0eb8141ea79103fee55a7fb7aebbc9dcc9dfaee7/chrome/test/data/extensions/api_test/webstore_inline_install/inlineinstall/detail/cccccccccccccccccccccccccccccccc [modify] https://crrev.com/0eb8141ea79103fee55a7fb7aebbc9dcc9dfaee7/chrome/test/data/extensions/api_test/webstore_inline_install/inlineinstall/detail/ecglahbcnmdpdciemllbhojghbkagdje
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2780ac5d821d63520829e1aa2f9747d57de0393 commit e2780ac5d821d63520829e1aa2f9747d57de0393 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 19 18:31:11 2018 [Extensions] Update ExtensionIconSourceTests to manifest v2 Update ExtensionIconSourceTests to manifest v2 and remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I6fe638994b9ca34b03fc16debcfb547d75e967e1 Reviewed-on: https://chromium-review.googlesource.com/1018405 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552093} [modify] https://crrev.com/e2780ac5d821d63520829e1aa2f9747d57de0393/chrome/browser/extensions/extension_icon_source_apitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a94ea4ede76f07e7ed37ec47face2eb99ab3a29e commit a94ea4ede76f07e7ed37ec47face2eb99ab3a29e Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 19 19:14:16 2018 [Extensions] Update WebNavigationApiTests to manifest v2 WebNavigationApiTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I755823e0335de01994d5b2b8dccfbc795795d0ee Reviewed-on: https://chromium-review.googlesource.com/1018412 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#552109} [modify] https://crrev.com/a94ea4ede76f07e7ed37ec47face2eb99ab3a29e/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e83aa862864a77b3f2a9109c92efed33943e98c9 commit e83aa862864a77b3f2a9109c92efed33943e98c9 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 19 20:29:23 2018 [Extensions] Update PageActionCrash25562 test to manifest v2 The PageActionCrash25562 test has been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I56c954aebb48a469cd7a9ab5c9f916d73498d5d5 Reviewed-on: https://chromium-review.googlesource.com/1018408 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#552145} [modify] https://crrev.com/e83aa862864a77b3f2a9109c92efed33943e98c9/chrome/browser/extensions/page_action_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e9387c326a398181afb37dbfcebce303e2d4cb2 commit 5e9387c326a398181afb37dbfcebce303e2d4cb2 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Apr 20 04:22:03 2018 [Extensions] Remove legacy test extension Remove a legacy "adblock.crx" test extension. It was originally added in 2011 in https://codereview.chromium.org/7794011 for some unknown crash (there was no comment on the CL nor a linked bug to indicate *what* crash this might be). It is also a manifest v1 extension, which is no longer supported by chrome. Remove the .crx and the test. The crx was also used by a policy test, but it appears any crx will do. Add a simple_with_icon.crx file and use that in place of the old. Bug: 816679 , 387866 Change-Id: Ic3640d8434a2b58a4d4a9d02880db8c9003e94e6 Reviewed-on: https://chromium-review.googlesource.com/1017312 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#552258} [modify] https://crrev.com/5e9387c326a398181afb37dbfcebce303e2d4cb2/chrome/browser/extensions/extension_functional_browsertest.cc [modify] https://crrev.com/5e9387c326a398181afb37dbfcebce303e2d4cb2/chrome/browser/policy/policy_browsertest.cc [delete] https://crrev.com/9e2ebb26a81722b956ea99f17ed7fa1e8a2468a7/chrome/test/data/extensions/adblock.crx [add] https://crrev.com/5e9387c326a398181afb37dbfcebce303e2d4cb2/chrome/test/data/extensions/simple_with_icon.crx [add] https://crrev.com/5e9387c326a398181afb37dbfcebce303e2d4cb2/chrome/test/data/extensions/simple_with_icon.pem [modify] https://crrev.com/5e9387c326a398181afb37dbfcebce303e2d4cb2/chrome/test/data/policy/extension_install_sources_test.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42ac0be7db7b5c9124fcb22142e4efc8303ff08e commit 42ac0be7db7b5c9124fcb22142e4efc8303ff08e Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Apr 20 04:38:37 2018 [Extensions] Update ExtensionCrxInstallerTest to manifest v2 Update ExtensionCrxInstallerTest to manifest v2 and remove the allowance for manifest v1 extensions. Update good.crx, good_v1.crx, and good2.crx to be manifest v2 extensions. Add directories for good_unpacked, good2_unpacked, and good_v1 in order to allow easy repackaging of these extensions in the future. Keep the old good.crx as legacy_crx_package.crx, since it's still useful in the mime type sniffing test. Bug: 816679 Change-Id: I7c286e037ee6225db14603074f411c2c6260a3f8 Reviewed-on: https://chromium-review.googlesource.com/1015968 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#552263} [modify] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/browser/extensions/crx_installer_browsertest.cc [modify] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/common/extensions/extension_unittest.cc [modify] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good.crx [modify] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good2.crx [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good2_unpacked/background.html [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good2_unpacked/manifest.json [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good2_unpacked/script1.js [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good2_unpacked/script2.js [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good_unpacked/manifest.json [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good_unpacked/script1.js [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good_unpacked/script2.js [modify] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good_v1.crx [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good_v1/manifest.json [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good_v1/script1.js [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/good_v1/script2.js [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/legacy_crx_package.README [add] https://crrev.com/42ac0be7db7b5c9124fcb22142e4efc8303ff08e/chrome/test/data/extensions/legacy_crx_package.crx
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4daa045ec17d289cea74ddf86859bc6dd8e320df commit 4daa045ec17d289cea74ddf86859bc6dd8e320df Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Apr 20 18:29:08 2018 [Extensions] Update ExtensionFunctionalTests to manifest v2 ExtensionFunctionalTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I9a250fa7212bd33db1b123c244956c07d4f7d3cd Reviewed-on: https://chromium-review.googlesource.com/1021661 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552395} [modify] https://crrev.com/4daa045ec17d289cea74ddf86859bc6dd8e320df/chrome/browser/extensions/extension_functional_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e25f3576074516a315795a91e35716fe67ff1f4 commit 3e25f3576074516a315795a91e35716fe67ff1f4 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Apr 20 18:29:13 2018 [Extensions] Update ExtensionManagementTests to manifest v2 ExtensionManagementTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ib0401a6fdde8e19cdf213769d83dfca73ec98c3d Reviewed-on: https://chromium-review.googlesource.com/1021660 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552396} [modify] https://crrev.com/3e25f3576074516a315795a91e35716fe67ff1f4/chrome/browser/extensions/api/management/management_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6559f12269e921ff9320cbc613dc8819713c139 commit d6559f12269e921ff9320cbc613dc8819713c139 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Apr 20 20:34:14 2018 [Extensions] Update ExtensionResourceRequestPolicyTest to manifest v2 ExtensionResourceRequestPolicyTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I05069412df2ff5bc93cdc6299046b0389e0ad33d Reviewed-on: https://chromium-review.googlesource.com/1022002 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552455} [modify] https://crrev.com/d6559f12269e921ff9320cbc613dc8819713c139/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cedac69023de64b9a352b26c80e8b134632389b4 commit cedac69023de64b9a352b26c80e8b134632389b4 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Apr 24 18:20:26 2018 [Extensions] Update ChromeLauncherControllerTests to manifest v2 ChromeLauncherControllerTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ibe3aba811e68240bd5338aef9268af83bd611acc Reviewed-on: https://chromium-review.googlesource.com/1026084 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553205} [modify] https://crrev.com/cedac69023de64b9a352b26c80e8b134632389b4/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dae58f923cff8db483ec3c6ac1add8526ee590d5 commit dae58f923cff8db483ec3c6ac1add8526ee590d5 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Apr 24 19:02:05 2018 [Extensions] Update ComponentLoaderTests to manifest v2 ComponentLoaderTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ic35a4f11840ea2194b16f93eb541aa62e8cd7361 Reviewed-on: https://chromium-review.googlesource.com/1025134 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553220} [modify] https://crrev.com/dae58f923cff8db483ec3c6ac1add8526ee590d5/chrome/browser/extensions/component_loader_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1de93897f93f46c92cfaf6ceb4a63ce47a81352f commit 1de93897f93f46c92cfaf6ceb4a63ce47a81352f Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Apr 24 19:17:15 2018 [Extensions] Update SandboxedUnpackerTests to manifest v2 Update SandboxedUnpackerTests to manifest v2 and remove the allowance for manifest v1 extensions. Repackage all the crx's used in the sandboxed unpacker tests. Additionally, git doesn't allow empty directories to be added to the repository, which appears to have caused problems with some of the unpacked versions of these extensions (where the empty directory is necessary for the test). Add the missing directories, and put in a dummy readme file to appease git. Bug: 816679 Change-Id: I7130bbe89079437b8ee9090ba120039e2dbe9672 Reviewed-on: https://chromium-review.googlesource.com/1024910 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553226} [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/browser/sandboxed_unpacker_unittest.cc [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/bad_image.crx [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/bad_zip.crx [rename] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/bad_zip.pem [rename] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/bad_zip.sh [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/empty_default_locale.crx [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/good_l10n.crx [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/good_package.crx [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/has_default_missing_locales.crx [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/invalid_default_locale.crx [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/invalid_messages_file.crx [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/missing_default_data.crx [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/missing_default_has_locales.crx [add] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/missing_default_has_locales/_locales/README [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/missing_messages_file.crx [add] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/missing_messages_file/_locales/en_US/README [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/no_l10n.crx [modify] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/no_locale_data.crx [add] https://crrev.com/1de93897f93f46c92cfaf6ceb4a63ce47a81352f/extensions/test/data/unpacker/no_locale_data/_locales/README
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2069f5798d7ec453ae25d292a799d0f04b4aa85b commit 2069f5798d7ec453ae25d292a799d0f04b4aa85b Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Apr 24 22:09:21 2018 [Extensions] Update PrefHashBrowserTestBase to manifest v2 PrefHashBrowserTestBase tests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Idfa6c27efac318842ad5169370e2073d02edb615 Reviewed-on: https://chromium-review.googlesource.com/1014561 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553313} [modify] https://crrev.com/2069f5798d7ec453ae25d292a799d0f04b4aa85b/chrome/browser/prefs/tracked/pref_hash_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf71828f1a3b7d1236d3d3c24982df9d830e829d commit cf71828f1a3b7d1236d3d3c24982df9d830e829d Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 25 00:12:49 2018 [Extensions] Update ExtensionSettingsUIBrowserTests to manifest v2 ExtensionSettingsUIBrowserTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ib0d7f277f7c2d79a941c689962e84030d24fe5b7 Reviewed-on: https://chromium-review.googlesource.com/1026086 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553381} [modify] https://crrev.com/cf71828f1a3b7d1236d3d3c24982df9d830e829d/chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc [modify] https://crrev.com/cf71828f1a3b7d1236d3d3c24982df9d830e829d/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b5cff45ed379e0bc81ee29495b14114a23a7826 commit 6b5cff45ed379e0bc81ee29495b14114a23a7826 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 25 00:39:00 2018 [Extensions] Update ExternalInstallErrorTests to manifest v2 ExternalInstallErrorTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I59bcbcaf0d1d15e6270e485398091f3e714f217b Reviewed-on: https://chromium-review.googlesource.com/1024609 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553394} [modify] https://crrev.com/6b5cff45ed379e0bc81ee29495b14114a23a7826/chrome/browser/extensions/external_install_error_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c50dab45b9f696b1305ad8e15b7e1a338eafd325 commit c50dab45b9f696b1305ad8e15b7e1a338eafd325 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 25 14:48:23 2018 [Extensions] Update DeviceLocalAccountTests to manifest v2 DeviceLocalAccountTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: If61d9bf5b3b9a919c152c5486bae57513e095c18 Reviewed-on: https://chromium-review.googlesource.com/1026074 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553548} [modify] https://crrev.com/c50dab45b9f696b1305ad8e15b7e1a338eafd325/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb4e9851fb0e1be9aac965d7f1ff96a77bedd6a8 commit eb4e9851fb0e1be9aac965d7f1ff96a77bedd6a8 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 25 14:48:34 2018 [Extensions] Update PolicyTests to manifest v2 PolicyTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ifc1db03aa42db2ae367389d4ec3df4efb18573db Reviewed-on: https://chromium-review.googlesource.com/1026073 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553549} [modify] https://crrev.com/eb4e9851fb0e1be9aac965d7f1ff96a77bedd6a8/chrome/browser/policy/policy_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc81f1ec842aeda59384a188af599905483696fc commit fc81f1ec842aeda59384a188af599905483696fc Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 25 17:15:52 2018 [Extensions] Update DownloadTests to manifest v2 DownloadTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: If536e7da72deb5934305bf0a68b011b6b55582d5 Reviewed-on: https://chromium-review.googlesource.com/1026070 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553616} [modify] https://crrev.com/fc81f1ec842aeda59384a188af599905483696fc/chrome/browser/download/download_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/077ce1f7489a6461042a40c15da0182cc47dfece commit 077ce1f7489a6461042a40c15da0182cc47dfece Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 25 21:18:55 2018 [Extensions] Update ExtensionServiceTestBase et al to manifest v2 Update ExtensionServiceTestBase and all derived tests to use manifest v2 extensions. Update old .crx files, Preferences files, and dynamically-created extensions. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ib07447a9cde9017f250d8100d3e55a9fd790d48c Reviewed-on: https://chromium-review.googlesource.com/1024642 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553749} [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/chromeos/extensions/gfx_utils_unittest.cc [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/extensions/api/mdns/mdns_api_unittest.cc [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/extensions/extension_migrator_unittest.cc [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/extensions/extension_service_test_base.cc [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/extensions/extension_service_test_base.h [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/extensions/extension_service_unittest.cc [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/profile_resetter/profile_resetter_unittest.cc [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/supervised_user/supervised_user_service_unittest.cc [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/ui/app_list/arc/arc_app_unittest.cc [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider_unittest.cc [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/app_list/Preferences [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/bad/Preferences [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/bad_underscore.crx [add] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/bad_underscore/_locale/README [add] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/bad_underscore/manifest.json [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/external_standalone/ldnnhddmnhbkjipkidpdiheffobcpfmf.crx [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/good/Preferences [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/good/PreferencesExternal [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/l10n/Preferences [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/page_action.crx [add] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/page_action_unpacked.pem [add] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/page_action_unpacked/manifest.json [modify] https://crrev.com/077ce1f7489a6461042a40c15da0182cc47dfece/chrome/test/data/extensions/pending_updates/Preferences
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c83c84e8be0edb0c69defc3cb2f69accfe3f4bb commit 9c83c84e8be0edb0c69defc3cb2f69accfe3f4bb Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 26 01:02:52 2018 [Extensions] Remove some test-only manifest v1 switches Remove Extension::ScopedAllowLegacyExtensions and ExtensionBrowserTest::ShouldAllowLegacyExtensionManifests(). These are both unused now that all the affected tests have been updated. Leave in the commandline flag kAllowLegacyExtensionManifests. This can still be useful as a last resort for loading a v1 extension, and there's no harm in leaving it in since we've removed all manifest v1-specific handling (that is, all extensions loaded will effectively be treated as v2). Bug: 816679 Change-Id: I673bee01d00eaf7b82e1996da84f9b44e090aaf9 Reviewed-on: https://chromium-review.googlesource.com/1029000 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553860} [modify] https://crrev.com/9c83c84e8be0edb0c69defc3cb2f69accfe3f4bb/chrome/browser/extensions/extension_browsertest.cc [modify] https://crrev.com/9c83c84e8be0edb0c69defc3cb2f69accfe3f4bb/chrome/browser/extensions/extension_browsertest.h [modify] https://crrev.com/9c83c84e8be0edb0c69defc3cb2f69accfe3f4bb/extensions/common/extension.cc [modify] https://crrev.com/9c83c84e8be0edb0c69defc3cb2f69accfe3f4bb/extensions/common/extension.h [modify] https://crrev.com/9c83c84e8be0edb0c69defc3cb2f69accfe3f4bb/extensions/common/extension_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2f44cbea9e9a55b81856f17f7a8b4d3b43d20c0 commit a2f44cbea9e9a55b81856f17f7a8b4d3b43d20c0 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 26 01:08:29 2018 [Extensions] Update StartupHelperBrowserTests to manifest v2 StartupHelperBrowserTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ib11500da4e22cd74f60193e5fd3d3c0368fb686f Reviewed-on: https://chromium-review.googlesource.com/1024600 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553863} [modify] https://crrev.com/a2f44cbea9e9a55b81856f17f7a8b4d3b43d20c0/chrome/browser/extensions/startup_helper_browsertest.cc
50 patches later, I think this is finally done.
Comment 1 by aruproy8...@gmail.com
, Feb 27 2018