Issue metadata
Sign in to add a comment
|
3.8% regression in smoothness.gpu_rasterization.tough_filters_cases at 538411:538480 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 26 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16e80c28440000
,
Feb 27 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/16e80c28440000 Enable fSharpenMipmappedTextures in Skia by brianosman@google.com https://chromium.googlesource.com/chromium/src/+/dbefb45d16d8544042eb143a831da738618be61b Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 16 2018
brianosman: The bisect found a performance regression at your CL, can you take a look?
,
Mar 19 2018
What does the gap in the pinpoint job mean? It looks like the metric is identical on the previous commit, so I'm not sure why my CL was selected. For reference: My CL could have caused a minor performance regression in some cases, but it's a substantial improvement in quality, as well as an improvement in memory and performance in most cases, so any such trade-off would be worth it. I'm just not convinced this is one of those cases.
,
Mar 23 2018
That pinpoint job picked me, but the graph appears to exonerate my CL?
,
Mar 23 2018
tl;dr - pinpoint didn't repro an actual regression, just a slight change in distribution. WontFix-ing because this is just a change on one device/metric/page and bisect can't reproduce. Full details: Sorry, didn't look closely enough last time. You can read more about how pinpoint detects performance changes at go/pinpoint-data. On the graph, the gap means that it did detect a difference in the distribution of the data points after your CL. And if you look at the values on the right while clicking on different points, you can see that the distribution of the points does seem to change, but the overall value of the metric does not. +dtu is planning to get the data from the dashboard about the size of regression that pinpoint should expect, so we can handle these cases better in the future. Thanks for looking into this and commenting clearly!
,
Mar 23 2018
The distribution changed in such a way that the mean changed, but the median did not. Unfortunately, the graph shows only the median. Whether the overall value of the metric changed depends on what you mean by "overall value".
,
Mar 23 2018
I would interpret it as, "some frames that previously took 33.3ms now take 50ms". Since most of the frames took 50ms both before and after, the median didn't change.
,
Mar 26 2018
dtu: Thanks, I hadn't picked up on the graph being median. That (plus the histograms) make much more sense now. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 26 2018