New issue
Advanced search Search tips

Issue 816646 link

Starred by 1 user
Status: Fixed
Merged: issue 816643
Owner:
arthurso...@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"ChromeNavigationBrowserTest.BlockLegacySubresources" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 26 2018 
"ChromeNavigationBrowserTest.BlockLegacySubresources" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNDaHJvbWVOYXZpZ2F0aW9uQnJvd3NlclRlc3QuQmxvY2tMZWdhY3lTdWJyZXNvdXJjZXMM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by zakerinasab@chromium.org, Feb 27 2018

Owner: arthurso...@chromium.org
Status: Assigned (was: Untriaged)
Flaky test on mac_chromium_rel_ng. I'm disabling the test in https://chromium-review.googlesource.com/c/chromium/src/+/938365. Will reduce the priority to P2 when this is landed.

Assigned to arthursonzogni@ as the writer of the test (according to git blame). arthursonzogni@: would you please take a look and assign it to the proper person if you're not the correct owner for this bug? Thanks.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875245c319cde9bf7d54ae2dfd89ee02c376856f

commit 875245c319cde9bf7d54ae2dfd89ee02c376856f
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Feb 27 17:09:01 2018

Disable ChromeNavigationBrowserTest.BlockLegacySubresources on Mac

Bug:816646
Change-Id: I9793d98d321fa3e5685d275f2e7d4c7d98fd1ddb

TBR=arthursonzogni@chromium.org

Change-Id: I9793d98d321fa3e5685d275f2e7d4c7d98fd1ddb
Reviewed-on: https://chromium-review.googlesource.com/938365
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539468}
[modify] https://crrev.com/875245c319cde9bf7d54ae2dfd89ee02c376856f/chrome/browser/chrome_navigation_browsertest.cc

Comment 3 by zakerinasab@chromium.org, Feb 27 2018

Labels: -Pri-1 -Sheriff-Chromium Pri-2

Comment 4 by msw@chromium.org, Feb 27 2018

Mergedinto: 816643
Status: Duplicate (was: Assigned)
This test should be re-enabled, it only failed with a cq trybot patch applied.

Comment 5 by msw@chromium.org, Feb 27 2018

Status: Assigned (was: Duplicate)
Hmm, maybe not this one? It failed with several unrelated patches applied:
http://crrev.com/c/931802
http://crrev.com/c/937882
http://crrev.com/c/924373
http://crrev.com/c/938283
http://crrev.com/c/930325
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d61d2be240782f68fd1a3f0bf10892205491b4a4

commit d61d2be240782f68fd1a3f0bf10892205491b4a4
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date: Wed Jun 06 09:04:27 2018

Re-enable ChromeNavigationBrowserTest.BlockLegacySubresources on Mac.

Bug:  816646 
Change-Id: I76f84ba670a69a7e599d43b3dcd0eddde43578fa
Reviewed-on: https://chromium-review.googlesource.com/1082397
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564830}
[modify] https://crrev.com/d61d2be240782f68fd1a3f0bf10892205491b4a4/chrome/browser/chrome_navigation_browsertest.cc

Comment 7 by arthurso...@chromium.org, Jun 6 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment