New issue
Advanced search Search tips

Issue 816645 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 816643
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

"BrowserFocusTest.FindFocusTest" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 26 2018

Issue description

"BrowserFocusTest.FindFocusTest" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKQsSBUZsYWtlIh5Ccm93c2VyRm9jdXNUZXN0LkZpbmRGb2N1c1Rlc3QM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: OS-Windows
Owner: sky@chromium.org
Status: Assigned (was: Untriaged)
Disabling the test on Windows in https://chromium-review.googlesource.com/c/chromium/src/+/938387. Assigning the bug to sky@ since he is the owner of  crbug.com/523255 , as requested in the test comments.
Priority should reduce to P2 when the test is disabled.
Labels: -OS-Windows OS-Chrome
Ah, this is a Chrome OS flake, not Win. I'll fix it soon.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41d56f974752011f030c5b2f63be331df960bad0

commit 41d56f974752011f030c5b2f63be331df960bad0
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Mon Feb 26 22:01:28 2018

Disable BrowserFocusTest.FindFocusTest on Chrome OS

Bug:816645
Change-Id: Ifecbd85be7b27e5193d63089a1e0222c3674d1c9

TBR=sky@chromium.org

Change-Id: Ifecbd85be7b27e5193d63089a1e0222c3674d1c9
Reviewed-on: https://chromium-review.googlesource.com/938387
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539279}
[modify] https://crrev.com/41d56f974752011f030c5b2f63be331df960bad0/chrome/browser/ui/browser_focus_uitest.cc

Labels: -Pri-1 -Sheriff-Chromium Pri-2

Comment 5 by msw@chromium.org, Feb 27 2018

Mergedinto: 816643
Status: Duplicate (was: Assigned)
This test should be re-enabled, it only failed with a cq trybot patch applied.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a5bbdd79b8621a793ef27010bd270c22565bff8

commit 0a5bbdd79b8621a793ef27010bd270c22565bff8
Author: Michael Wasserman <msw@chromium.org>
Date: Wed Feb 28 00:05:46 2018

Revert "Disable BrowserFocusTest.FindFocusTest on Chrome OS"

This reverts commit 41d56f974752011f030c5b2f63be331df960bad0.

Reason for revert:
It only failed with a cq trybot patch applied, see  http://crbug.com/816643 

Original change's description:
> Disable BrowserFocusTest.FindFocusTest on Chrome OS
> 
> Bug:816645
> Change-Id: Ifecbd85be7b27e5193d63089a1e0222c3674d1c9
> 
> TBR=sky@chromium.org
> 
> Change-Id: Ifecbd85be7b27e5193d63089a1e0222c3674d1c9
> Reviewed-on: https://chromium-review.googlesource.com/938387
> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
> Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539279}

TBR=sky@chromium.org,zakerinasab@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  816645 
Change-Id: Ic584d4c7f423d8c1b9f0a5887bfabca4908cabe6
Reviewed-on: https://chromium-review.googlesource.com/940162
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539590}
[modify] https://crrev.com/0a5bbdd79b8621a793ef27010bd270c22565bff8/chrome/browser/ui/browser_focus_uitest.cc

Sign in to add a comment