Issue metadata
Sign in to add a comment
|
Put |process_id| and |routing_id| parameters first at OnSSLCertificateError() mojo interface to match the style of other functions |
||||||||||||||||||||||
Issue descriptionThis is from the comment at: https://chromium-review.googlesource.com/c/chromium/src/+/877512/18/services/network/public/mojom/network_service.mojom For OnSSLCertificateError() at services/network/public/mojom/network_service.mojom The two parameters: "uint32 process_id" and "uint32 routing_id" can be put first to match the style of the other two functions: OnAuthRequired() OnCertificateRequested()
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ec9c03904b0cfc2239807ed6e475b28e17d18d8 commit 2ec9c03904b0cfc2239807ed6e475b28e17d18d8 Author: Jun Cai <juncai@chromium.org> Date: Fri Mar 02 19:32:06 2018 NetworkService: Change |process_id| and |routing_id| parameters order in OnSSLCertificateError() For OnSSLCertificateError() at //services/network/public/mojom/network_service.mojom The two parameters: "uint32 process_id" and "uint32 routing_id" can be put first to match the style of the other two functions: OnAuthRequired() OnCertificateRequested() Bug: 816639 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I539c55157fd187455fe1b08ee11ea3e017846b5a Reviewed-on: https://chromium-review.googlesource.com/938393 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540585} [modify] https://crrev.com/2ec9c03904b0cfc2239807ed6e475b28e17d18d8/content/browser/network_service_client.cc [modify] https://crrev.com/2ec9c03904b0cfc2239807ed6e475b28e17d18d8/content/browser/network_service_client.h [modify] https://crrev.com/2ec9c03904b0cfc2239807ed6e475b28e17d18d8/services/network/public/mojom/network_service.mojom [modify] https://crrev.com/2ec9c03904b0cfc2239807ed6e475b28e17d18d8/services/network/url_loader.cc
,
Mar 2 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by juncai@chromium.org
, Feb 26 2018