New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816605 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue skia:7050



Sign in to add a comment

Swarming: support output directories.

Project Member Reported by mar...@chromium.org, Feb 26 2018

Issue description

Output directories seems broken (?)

In practice, determinism is better than guessing, so I propose this following self-describing format:
- Output directories have trailing '/' or '\\'
- Output files do not

Then no need for two arguments.

https://cs.chromium.org/chromium/infra/luci/client/run_isolated.py?q="def+link_outputs_to_outdir"

(Related to  issue 816602 )
 

Comment 1 by mar...@chromium.org, Feb 26 2018

Cc: borenet@chromium.org
Labels: -OS-Mac

Comment 2 by aludwin@google.com, Feb 26 2018

Owner: sadafm@google.com

Comment 3 by bore...@google.com, Feb 26 2018

Blocking: skia:7050

Comment 4 by bore...@google.com, Mar 14 2018

Labels: -Pri-3 Pri-2
Friendly ping. This is blocking (by way of a couple different bugs) Skia's transition to using Kitchen.

Comment 5 by sadafm@google.com, Mar 14 2018

Status: Started (was: Available)
Sorry I dint't know this was blocking. I will have an update on this bug soon.

Comment 6 by mar...@chromium.org, Mar 14 2018

Ignore the initial comment about trailing /\, we won't go this route and will just discover instead.

Comment 7 by bore...@google.com, Mar 23 2018

Just wanted to check and see if there's anything I can do to help this along!

Comment 8 by aludwin@google.com, Mar 23 2018

There's a fix currently in review, hopefully it will land relatively soon.

Comment 9 by sadafm@google.com, Apr 10 2018

Status: Fixed (was: Started)
This should be fixed now. Let us know if you try it out and run into any issues.

Comment 10 by aludwin@google.com, Apr 10 2018

For the record, here's the change: https://chromium-review.googlesource.com/c/971762/

Comment 11 by bore...@google.com, Apr 10 2018

Awesome, thanks!  It'll take a bit of tinkering to test, but I'll follow up soon.

Comment 12 by bore...@google.com, Apr 12 2018

Confirmed working as expected! Thanks!

Sign in to add a comment