Swarming: hard fail on failure when gathering output files |
|||
Issue description
run_isolated.py has a function link_outputs_to_outdir() which tries to archives all output files to ${ISOLATED_OUTDIR}. It currently doesn't support directories and silently fail instead.
This should be real failure that is correctly surfaced, e.g. a post task failure or an in-task internal failure?
Ref:
https://cs.chromium.org/chromium/infra/luci/client/run_isolated.py?q="def+link_outputs_to_outdir"
,
Feb 26 2018
Thanks, filed issue 816605 to clarify output directory support.
,
Feb 26 2018
If issue 816605 is fixed, does this issue become obsolete?
,
Feb 26 2018
No, this would be for example to make it an hard fail if: - outputs are missing (they are currently optional, not a fan personally) - linking/copying outputs fail (for example, lack of disk space, reason doesn't matter)
,
Feb 26 2018
We currently have "optional" outputs (eg something like test.FAIL and test.SUCCESS 0-byte files) so we'd need some way to differentiate between optional and mandatory outputs. This ~matches how Bazel rules work IIRC. Agreed that any linking/copying failure should be a hard stop. Sadaf, please let me know if you want to keep this one, otherwise we can reassign.
,
Mar 14 2018
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/fcd12a9397594775dfde9e4df0467616e3b15166 commit fcd12a9397594775dfde9e4df0467616e3b15166 Author: Sadaf Matinkhoo <sadafm@google.com> Date: Thu Mar 29 20:36:22 2018 Support directory output in bot Bug:816602 Change-Id: Id73b0fa6fa3db2db2188c2476f771eaa88ae9849 Reviewed-on: https://chromium-review.googlesource.com/971762 Commit-Queue: Sadaf Matinkhoo <sadafm@google.com> Reviewed-by: Adrian Ludwin <aludwin@google.com> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/fcd12a9397594775dfde9e4df0467616e3b15166/client/run_isolated.py [modify] https://crrev.com/fcd12a9397594775dfde9e4df0467616e3b15166/client/tests/run_isolated_test.py
,
Apr 10 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by aludwin@google.com
, Feb 26 2018