New issue
Advanced search Search tips

Issue 816597 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

frame reload during getUserMedia hits DCHECKs

Project Member Reported by guidou@chromium.org, Feb 26 2018

Issue description

A number of DCHECKs are hit in rare occassions when invoking location.reload() in the middle of a getUserMedia() call.
This has no negative consequences on production builds.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76575bdb52d2726b39153600b17bea08bd8ab286

commit 76575bdb52d2726b39153600b17bea08bd8ab286
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu Mar 01 16:32:42 2018

Improve handling of frame reloads in getUserMedia()

This mainly serves as a test for  https://crbug.com/816323 , but also
removes two DCHECKs that were wrong.

This CL also removes UserMediaProcessor::RequestInfo::HasPendingSources()
since it was used just for implementing two DCHECKs, one of which is no
longer valid due to other recent changes.

No behavior change is intended.


Bug:  816597 ,  816323 

Change-Id: Icfddae5f9a9709e9702f696cb70f289697bdcb6b
Reviewed-on: https://chromium-review.googlesource.com/938041
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540176}
[modify] https://crrev.com/76575bdb52d2726b39153600b17bea08bd8ab286/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/76575bdb52d2726b39153600b17bea08bd8ab286/content/renderer/media/stream/user_media_processor.cc
[add] https://crrev.com/76575bdb52d2726b39153600b17bea08bd8ab286/third_party/WebKit/LayoutTests/fast/mediastream/getusermedia-reload-no-crash.html

Status: Fixed (was: Started)

Sign in to add a comment