New issue
Advanced search Search tips

Issue 816568 link

Starred by 2 users
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Scrolls sometimes generate clicks or long presses

Project Member Reported by mthiesse@chromium.org, Feb 26 2018 
We don't ensure that our scroll events exceed Android touch slop, so sometimes our scroll events are interpreted as clicks (or long presses).

We should make sure that whenever we send a scroll that it exceeds the touch slop value.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1af4c93c2241eea6211d8a93ca448db5f9a708b5

commit 1af4c93c2241eea6211d8a93ca448db5f9a708b5
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Tue Feb 27 00:09:34 2018

VR: Fix click and long press generation from scroll events.

When we send scroll events we need to make sure the touch events
we generate exceed the touch slop value required to initiate a
scroll.

This also fixes fling cancels, which were previously not doing
anything at all.

Bug:  816568 
Change-Id: I119d1d467cb10b1e578c8cd01ffba3351e7b70a4
Reviewed-on: https://chromium-review.googlesource.com/932561
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539316}
[modify] https://crrev.com/1af4c93c2241eea6211d8a93ca448db5f9a708b5/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/AndroidUiGestureTarget.java
[modify] https://crrev.com/1af4c93c2241eea6211d8a93ca448db5f9a708b5/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/1af4c93c2241eea6211d8a93ca448db5f9a708b5/chrome/browser/android/vr/android_ui_gesture_target.cc
[modify] https://crrev.com/1af4c93c2241eea6211d8a93ca448db5f9a708b5/chrome/browser/android/vr/android_ui_gesture_target.h

Comment 2 by mthiesse@chromium.org, Feb 27 2018

Status: Fixed (was: Started)

Comment 3 by dougman@chromium.org, Feb 28 2018

Labels: Test-Complete
►

Sign in to add a comment