Moving amd64-generic-goma-canary-chromium-pfq-informational to swarming will require special recipe. |
||||||||
Issue descriptionThe goma canary builder relies on a special config flag being sent by the waterfall to request that the canary version of goma is used for the build. Post-swarming, the waterfall won't be available to supply this flag. Approaches I see: A) A special build recipe. B) Pass in flag via buildbucket request. C) Move goma installation to cbuildbot and use cbuildbot_config. My thinking is that it's best to create a new recipe, then add a new config value to specify which recipe to use. When we start auto-generating scheduler configs, this will be used there.
,
Mar 1 2018
Let me describe the current status (mainly for goma members) goma canary bot on chromeos side is currently running on https://ci.chromium.org/buildbot/chromiumos.chromium/amd64-generic-goma-canary-chromium-pfq-informational/ (note: as of 1st Mar. goma canary version is not used yet) Currently goma is installed in "ensure_goma" step, which runs before "cbuildbot" step. So, cbuildbot config cannot be utilized in ensure_goma step. To install goma in ensure_step, in chrome (not chromeos), we have a config map (builder name -> config), and use it to specify "goma_canary" config. So I'm considering to use similar structure in chromeos bots, too. However, post-swarming, builder name won't be available. If cbuildbot runs in a VM that is different from the builder, canary version of goma might not be installed in such a swarming VM. So we need to consider something dgarrett mentioned.
,
Mar 5 2018
,
Mar 30 2018
,
Mar 30 2018
,
Apr 25 2018
I have migrated this to swarming, but forgot to tweak the recipe. I believe this means the builder is currently running, but not using the Goma canary.
,
Apr 25 2018
The new location is here: https://cros-goldeneye.corp.google.com/chromeos/legoland/builderSummary?builderGroups=pre_cq&limit=3
,
May 28 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/c7f93cd797bb2e8202beeb4800914d5679732e4c commit c7f93cd797bb2e8202beeb4800914d5679732e4c Author: Don Garrett <dgarrett@google.com> Date: Mon May 28 02:58:16 2018
,
May 28 2018
I cannot see any goma-canary bot in #Comment 7. Hmm, did it disappear...?
,
May 28 2018
I can see https://cros-goldeneye.corp.google.com/chromeos/legoland/builderHistory?buildConfig=amd64-generic-goma-canary-chromium-pfq-informational&buildBranch and I confirmed the canary version was not used for a while. If it continued from around Apr 25, no one didn't checked chrome version for goma version 155 and 156? sigh...
,
May 29 2018
I'm sorry about that, it was a dumb oversite on my part. But, it does appear to be fixed now. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dgarr...@chromium.org
, Feb 26 2018