New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816554 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 795946



Sign in to add a comment

support ufs based storage

Project Member Reported by gwendal@chromium.org, Feb 26 2018

Issue description

Similarly to crbug:655192, add support for ufs based storage throughout the code base.
ufs device presents themselves as SCSI device [sda], so the assumption sda means a SATA device is not true anymore.

From NVMe experience, asreas that need some upgrade:
+ autotest:
 - hardware_StorageQualBase/hardware_SsdDetection.test 
 - hardware_StorageQualBase
 - /platform_CryptohomeFio.XXXX   
 - server/hosts/cros_label.py

+ chromeos-common.sh
 - in get_device_type and other base functions.

+ storage-info-common.sh
 - support for information gathering


 
Cc: mka@chromium.org swboyd@chromium.org evgreen@chromium.org
Note: see also issuetracker.google.com/77540192
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/49157b5bacdee09fb2359052dd31cf6c55c01d0b

commit 49157b5bacdee09fb2359052dd31cf6c55c01d0b
Author: Alexis Savery <asavery@chromium.org>
Date: Wed Jun 06 04:28:44 2018

sdparm: upgraded package to upstream

Upgraded sys-apps/sdparm to version 1.10 on amd64, arm, x86

BUG=chromium:816554
TEST=emerge, on lulu sdparm works

Change-Id: Idd35f276c0a5e509d6916e5a5d7be661a50de036
Reviewed-on: https://chromium-review.googlesource.com/1069796
Commit-Ready: Alexis Savery <asavery@chromium.org>
Tested-by: Alexis Savery <asavery@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/49157b5bacdee09fb2359052dd31cf6c55c01d0b/sys-apps/sdparm/Manifest
[add] https://crrev.com/49157b5bacdee09fb2359052dd31cf6c55c01d0b/sys-apps/sdparm/sdparm-1.10.ebuild
[add] https://crrev.com/49157b5bacdee09fb2359052dd31cf6c55c01d0b/metadata/md5-cache/sys-apps/sdparm-1.10
[add] https://crrev.com/49157b5bacdee09fb2359052dd31cf6c55c01d0b/sys-apps/sdparm/metadata.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/ae90210a10251bcfbd610b6a75ece85007076110

commit ae90210a10251bcfbd610b6a75ece85007076110
Author: Alexis Savery <asavery@chromium.org>
Date: Fri Aug 17 09:13:50 2018

cheza: change the metadata to point rootdev_base to ufs

BUG=chromium:816554
TEST=Ran chromeos-install without --dst

Change-Id: I287fad9ead761d15582410cd2b1665b146fbaf96
Reviewed-on: https://chromium-review.googlesource.com/1176728
Commit-Ready: Alexis Savery <asavery@chromium.org>
Tested-by: Alexis Savery <asavery@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Evan Green <evgreen@chromium.org>

[modify] https://crrev.com/ae90210a10251bcfbd610b6a75ece85007076110/baseboard-cheza/scripts/disk_layout.json

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/51946c603323c85f5f18c14a5970f635169578c8

commit 51946c603323c85f5f18c14a5970f635169578c8
Author: Alexis Savery <asavery@chromium.org>
Date: Tue Sep 18 21:03:42 2018

storage_info: add support for ufs

BUG=chromium:816554
TEST=storage_info.txt contains ufs device info

Change-Id: I9eaf6581f60046c5400120858afeb9114230b4dd
Reviewed-on: https://chromium-review.googlesource.com/1131840
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alexis Savery <asavery@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[modify] https://crrev.com/51946c603323c85f5f18c14a5970f635169578c8/storage_info/share/storage-info-common.sh

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dec5e0f3fd15fca94bc57dbf3645fd698d82a021

commit dec5e0f3fd15fca94bc57dbf3645fd698d82a021
Author: Alexis Savery <asavery@chromium.org>
Date: Tue Sep 18 21:03:42 2018

chromeos-common-script: add ufs device type

Change get_device_type to return UFS when device is a ufs device.
Add list_fixed_ufs_disks

BUG=chromium:816554
TEST=Check on machine booting from ufs

Change-Id: I58514167d834ec57fb0b192ee6af0385897456fc
Reviewed-on: https://chromium-review.googlesource.com/1176787
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alexis Savery <asavery@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[modify] https://crrev.com/dec5e0f3fd15fca94bc57dbf3645fd698d82a021/chromeos-common-script/share/chromeos-common.sh

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/570e7fb30805cdb17427afd8644d1d29bc3a7fb7

commit 570e7fb30805cdb17427afd8644d1d29bc3a7fb7
Author: Alexis Savery <asavery@chromium.org>
Date: Wed Oct 03 20:59:29 2018

autotest: add ufs support in autotest

BUG=chromium:816554
TEST=Ran StorageQualBase.test

Change-Id: I39bfc5aca16b4786cc9ca443c4549b7f37371be8
Reviewed-on: https://chromium-review.googlesource.com/1173479
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alexis Savery <asavery@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[modify] https://crrev.com/570e7fb30805cdb17427afd8644d1d29bc3a7fb7/client/site_tests/hardware_SsdDetection/hardware_SsdDetection.py
[modify] https://crrev.com/570e7fb30805cdb17427afd8644d1d29bc3a7fb7/server/hosts/cros_label.py

Sign in to add a comment