New issue
Advanced search Search tips

Issue 816549 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 469639



Sign in to add a comment

Remove experimental flag and origin trial logic from AudioWorklet

Project Member Reported by hongchan@chromium.org, Feb 26 2018

Issue description

Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/dEsseBBMbs4/rvdT2wK4BQAJ

The following files need to be updated to enable AudioWorklet by default:
- AudioParamMap.idl
- AudioWorklet.idl
- AudioWorkletGlobalScope.idl
- AudioWorkletNode.idl
- AudioWorkletProcessor.idl
- BaseAudioContext.idl
- BaseAudioContext.cpp
- runtime_enabled_features.json5

- http/tests/origin_trials/webexposed/audioworklet-origin-trial-interfaces.html
- webexposed/global-interface-listing-expected.txt and friends


 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b38d192d113384bc10627d88094aa43ed4541cb0

commit b38d192d113384bc10627d88094aa43ed4541cb0
Author: Hongchan Choi <hongchan@chromium.org>
Date: Thu Mar 01 04:01:47 2018

Enable AudioWorklet by default

Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/dEsseBBMbs4/rvdT2wK4BQAJ

The following links were tested with the release build of this CL:
https://googlechromelabs.github.io/web-audio-samples/audio-worklet/
https://www.webaudiomodules.org/wamsynths/
https://wasabi.i3s.unice.fr/pedalboard/
http://faust.grame.fr/news/2017/12/12/benchmark-tools.html
https://node.charlieroberts.cricket/playground/

Bug:  816549 
Test: all existing AudioWorklet layout tests are passing.
Change-Id: Ia211ab0a62a757e0bdce3acc0d98d6b0b89ce034
Reviewed-on: https://chromium-review.googlesource.com/938162
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540036}
[delete] https://crrev.com/9d73c9eb4552a4540b4cd8eab1866538cb2c6617/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/audioworklet-origin-trial-interfaces.html
[delete] https://crrev.com/9d73c9eb4552a4540b4cd8eab1866538cb2c6617/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-common.js
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-gain-node.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-node-construction.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-node-onerror.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-node-options.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/context-audio-worklet.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/dynamic-channel-count.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/global-sample-rate.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/message-port.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/node-option-to-processor.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/timing-info.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/worklet-context-interaction.html
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/Source/modules/webaudio/AudioParamMap.idl
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/Source/modules/webaudio/AudioWorklet.idl
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.idl
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.idl
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessor.idl
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl
[modify] https://crrev.com/b38d192d113384bc10627d88094aa43ed4541cb0/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Status: Verified (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2522b11a93567e32048c0b26e0e3afee8d064afa

commit 2522b11a93567e32048c0b26e0e3afee8d064afa
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Wed Aug 08 04:01:49 2018

AudioWorklet: retire runtime flag

AudioWorklet shipped to stable in M66
https://chromium-review.googlesource.com/938162
https://www.chromestatus.com/feature/4588498229133312

BUG= 816549 

Change-Id: Ie70d0303e381d8ededefa77e572d03724d7d731f
Reviewed-on: https://chromium-review.googlesource.com/1163048
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581467}
[modify] https://crrev.com/2522b11a93567e32048c0b26e0e3afee8d064afa/third_party/blink/renderer/modules/webaudio/audio_worklet.h
[modify] https://crrev.com/2522b11a93567e32048c0b26e0e3afee8d064afa/third_party/blink/renderer/platform/runtime_enabled_features.json5

Sign in to add a comment