New issue
Advanced search Search tips

Issue 816545 link

Starred by 1 user
Status: Started
Owner:
alexilin@chromium.org
Cc:
pasko@chromium.org
lizeb@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 882895


Sign in to add a comment

Deprecate ResourcePrefetchPredictor

Project Member Reported by alexilin@chromium.org, Feb 26 2018 
ResourcePrefetchPredictor isn't going to be used in the near future. But it shares the code with PreconnectPredictor that is going to be launched.

There are at least 2 reasons to do it sooner than later:
* Make the preconnect predictor work with the NetworkService. We'll have to remove an observer from the ResourceDispatcherHostDelegate. The plan is to add all information we need to WebContentsObserver and the preconnect predictor requires a subset of all data we collect. So either we add only this subset to WebContentsObserver and resource prefetch predictor will stop working, or we add extra data to WebContentsObserver than we probably will ever need.
* Improve the preconnect predictor memory footprint by removing extra information from LoadingDataCollector. For example, the preconnect predictor doesn't need full URLs but we're keeping them in memory for some time because of the prefetch predictor.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a

commit b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Wed Feb 28 15:21:12 2018

predictors: Remove ResourcePrefetchPredictor

The ResourcePrefetchPredictor isn't going to be used in the near future.

Bug: 816545
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3e15bef529e5f0b13a09275b8fe7b385ec8215ba
Reviewed-on: https://chromium-review.googlesource.com/939171
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539827}
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/BUILD.gn
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/about_flags.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer.h
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_data_collector.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_data_collector.h
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_data_collector_unittest.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_predictor.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_predictor.h
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_predictor_config.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_predictor_config.h
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_predictor_config_unittest.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_predictor_unittest.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_stats_collector.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_stats_collector.h
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_stats_collector_unittest.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_test_util.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/loading_test_util.h
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/resource_prefetch_common.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/resource_prefetch_common.h
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/resource_prefetch_predictor.h
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/resource_prefetch_predictor.proto
[delete] https://crrev.com/cde7dafd09bf9f851e3b654be774276af422b402/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/resource_prefetch_predictor_tables.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/resource_prefetch_predictor_tables.h
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
[delete] https://crrev.com/cde7dafd09bf9f851e3b654be774276af422b402/chrome/browser/predictors/resource_prefetcher.cc
[delete] https://crrev.com/cde7dafd09bf9f851e3b654be774276af422b402/chrome/browser/predictors/resource_prefetcher.h
[delete] https://crrev.com/cde7dafd09bf9f851e3b654be774276af422b402/chrome/browser/predictors/resource_prefetcher_unittest.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/resources/predictors/resource_prefetch_predictor.html
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/resources/predictors/resource_prefetch_predictor.js
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/ui/webui/predictors/predictors_handler.cc
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/browser/ui/webui/predictors/predictors_handler.h
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/chrome/test/BUILD.gn
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7003a957dd2de398d113a37e3023c24ad5e49ee2

commit 7003a957dd2de398d113a37e3023c24ad5e49ee2
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Wed Mar 14 09:35:27 2018

predictors: Remove unused fields from URLRequestSummary

Many fields of predictors::URLRequestSummary are not used after the
ResourcePrefetchPredictor was deprecated. This CL removes obsolete
members from the class.

Bug: 816545
Change-Id: I405e4a640a23f587691d7cc0ac7a6fa2341e3dbc
Reviewed-on: https://chromium-review.googlesource.com/960665
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543037}
[modify] https://crrev.com/7003a957dd2de398d113a37e3023c24ad5e49ee2/chrome/browser/net/loading_predictor_observer.cc
[modify] https://crrev.com/7003a957dd2de398d113a37e3023c24ad5e49ee2/chrome/browser/predictors/loading_data_collector.cc
[modify] https://crrev.com/7003a957dd2de398d113a37e3023c24ad5e49ee2/chrome/browser/predictors/loading_data_collector.h
[modify] https://crrev.com/7003a957dd2de398d113a37e3023c24ad5e49ee2/chrome/browser/predictors/loading_data_collector_unittest.cc
[modify] https://crrev.com/7003a957dd2de398d113a37e3023c24ad5e49ee2/chrome/browser/predictors/loading_test_util.cc
[modify] https://crrev.com/7003a957dd2de398d113a37e3023c24ad5e49ee2/chrome/browser/predictors/loading_test_util.h
[modify] https://crrev.com/7003a957dd2de398d113a37e3023c24ad5e49ee2/chrome/browser/predictors/resource_prefetch_predictor_tab_helper.cc
[modify] https://crrev.com/7003a957dd2de398d113a37e3023c24ad5e49ee2/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc

Comment 3 by alexilin@chromium.org, Sep 12

Blockedon: 882895
I'll mark this as Fixed after the LoadingPredictor cleanup is done.
►

Sign in to add a comment