New issue
Advanced search Search tips

Issue 816542 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 469639



Sign in to add a comment

Remove AudioWorkletProcessorState and add onprocessorerror to AudioWorkletNode

Project Member Reported by hongchan@chromium.org, Feb 26 2018

Issue description

Spec PR: https://github.com/WebAudio/web-audio-api/pull/1509

1. Remove AudioWorkletProcessorState from the implementation
2. Add `onprocessorerror` to AudioWorkletNode IDL
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df8a43ce8e32a77d676a4a2c1326a51559819c06

commit df8a43ce8e32a77d676a4a2c1326a51559819c06
Author: Hongchan Choi <hongchan@chromium.org>
Date: Wed Feb 28 04:05:40 2018

Revise AudioWorkletNode IDL (AudioWorkletProcessorState, onprocessorerror)

Spec PR: https://github.com/WebAudio/web-audio-api/pull/1509

1. Remove AudioWorkletProcessorState from the implementation.
2. Add `onprocessorerror` to AudioWorkletNode IDL.
3. Modify the existing test for AudioWorkletProcessorState
   to test onprocessorerror handler.

Bug:  816542 
Test: http/tests/webaudio/audio-worklet/audio-worklet-node-onerror.html
Change-Id: I96280c7dbed5cdf2d608633e4ddb9c94e9b4f6e7
Reviewed-on: https://chromium-review.googlesource.com/937986
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539699}
[add] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-node-onerror.html
[delete] https://crrev.com/538b1db48679ff36ff68c3db02c9c22648fe82be/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-processor-state.html
[add] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/error-processor.js
[delete] https://crrev.com/538b1db48679ff36ff68c3db02c9c22648fe82be/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/state-processor.js
[modify] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/Source/core/events/event_type_names.json5
[modify] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.cpp
[modify] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.cpp
[modify] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.h
[modify] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.idl
[modify] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessor.cpp
[modify] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessor.h
[add] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorErrorState.h
[modify] https://crrev.com/df8a43ce8e32a77d676a4a2c1326a51559819c06/third_party/WebKit/Source/modules/webaudio/BUILD.gn

Status: Verified (was: Started)

Sign in to add a comment