Diagnose impact of v8:51458 |
||||||||||||||||||
Issue descriptionIf you are assigned this bug, I'm sorry, I'm running a bunch of pinpoint jobs and it doesn't yet support not auto-assigning... (please re-assign to gab@ in that event). Benchmarks affected by increasing the number of workers contributing to concurrent marking coalesced @ https://chromeperf.appspot.com/group_report?bug_id=816541 as well as lost ~2.5% on chromium-rel-win10/octane/Splay (visible even though too noisy to generate a linkable alert): https://chromeperf.appspot.com/report?sid=58d57db8b3635bfe30dc64e4a48dca7972ba2bffbb8d429e43dcd1e807e8d866&start_rev=534293&end_rev=539114 Many graphs in this report can be seen to improve as well (no alerts generated because it followed a big spike and the stddev necessary for an alert temporarily increased...): https://chromeperf.appspot.com/group_report?bug_id=809961 (this report captures the graphs which regressed initially in related r534414 -- subsequently fixed in v8:r51249) Noteworthy above: v8-gc-total_sum / v8-gc-full-mark-compactor_avg
,
Feb 26 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/169129a8440000
,
Feb 26 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/17991670440000
,
Feb 26 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14bd7c28440000
,
Feb 26 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11dc8bb0440000
,
Feb 26 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/174cfb20440000
,
Feb 26 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/169129a8440000
,
Feb 26 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/11dc8bb0440000
,
Feb 26 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/14efff70440000
,
Feb 26 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/14bd7c28440000
,
Feb 26 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/17991670440000
,
Feb 26 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/174cfb20440000
,
Feb 27 2018
,
Feb 27 2018
,
Feb 27 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16a80cd8440000
,
Feb 27 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/129d2b90440000
,
Feb 27 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14a76f08440000
,
Feb 27 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14bd3af0440000
,
Feb 27 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12c92598440000
,
Feb 27 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14b98668440000
,
Feb 27 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12c04f08440000
,
Feb 27 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14fe6668440000
,
Feb 27 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/129d2b90440000
,
Feb 27 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/12c04f08440000
,
Feb 27 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/14a76f08440000
,
Feb 27 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/14bd3af0440000
,
Feb 27 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/12c92598440000
,
Feb 27 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/14b98668440000
,
Feb 27 2018
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/16a80cd8440000 Use all available workers for concurrent marking. by gab@chromium.org https://chromium.googlesource.com/v8/v8/+/3c62f7ae0744ebf95769429e5b2b3c83fc384fdf Revert "Update V8 to version 6.6.283." by gab@chromium.org https://chromium.googlesource.com/chromium/src/+/7de67f111bbb38a270e02e44e5d99d5baa355d76 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 27 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14fe6668440000 Use all available workers for concurrent marking. by gab@chromium.org https://chromium.googlesource.com/v8/v8/+/3c62f7ae0744ebf95769429e5b2b3c83fc384fdf Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 28 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/17a87268440000
,
Feb 28 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1498e278440000
,
Feb 28 2018
,
Feb 28 2018
,
Feb 28 2018
,
Feb 28 2018
,
Feb 28 2018
Alright I think I've coalesced all the effects of this CL. It improves so system_health.memory_desktop benchmarks, some Group-GC/duration stats, and Splay for nodejs. Interestingly, tt regresses Splay on mac11-pro and win10-rel however. Graphs : https://chromeperf.appspot.com/group_report?bug_id=816541 + win10-rel/Splay : https://chromeperf.appspot.com/report?sid=58d57db8b3635bfe30dc64e4a48dca7972ba2bffbb8d429e43dcd1e807e8d866&start_rev=534293&end_rev=539114
,
Feb 28 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/17a87268440000 Fix CreateAnonymousSharedMemory() not to leak FILE when returning fd. by wez@chromium.org https://chromium.googlesource.com/chromium/src/+/45a7b305282b175e11c871c1a8ac3b8336c66259 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 28 2018
Congrats Wez! Created issue 817356 to document your improvement.
,
Feb 28 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/1498e278440000 Revert "Revert "Separate creation time & flush time behavior in GrDrawOpAtlas (take 2)"" by robertphillips@google.com https://skia.googlesource.com/skia/+/934c3d0c548d254a0d986963ee751caf0ffcb500 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 1 2018
,
Mar 1 2018
,
Mar 1 2018
,
Mar 1 2018
@simonhatch, see OP, we have many graphs on which we see improvements/regressions which we would like to tag to this bug but we can't because no automatic alert was detected (in general because the relevant metrics experienced an unrelated spike during the improvement, increasing the stddev and hiding everything else within). Is there any way we can manually add an "alert" point and link it to this bug?
,
Mar 1 2018
re: #c44 No there's no way to manually create an alert at the moment. If this is high priority, I could rig something up for you, otherwise this is a requested feature for the new UI that benjhayden@ is working on.
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/226da60f4a6f3b46877282a43d3ef71044bc07aa commit 226da60f4a6f3b46877282a43d3ef71044bc07aa Author: Gabriel Charette <gab@chromium.org> Date: Fri Mar 02 15:36:54 2018 [v8] Do not do rely on hyper-threads for concurrent marking on Mac. This should recover https://chromeperf.appspot.com/report?sid=4d751475ba95911f865aed7a822d55dde18304bc0cfd2f8409d1de9fe9695343 and https://arewefastyet.com/#machine=28&view=single&suite=octane&subtest=Splay It will however regress this: https://chromeperf.appspot.com/report?sid=020744195cfb20c373344b86b76385ce2919b53796b5c0651ba71c0625e8de19&start_rev=531511&end_rev=540262 R=ulan@chromium.org Bug: chromium:812178 , chromium:816541 Change-Id: Ia367d24b013c3f16d1dc2ae56d4c5ef23342845f Reviewed-on: https://chromium-review.googlesource.com/946099 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#51703} [modify] https://crrev.com/226da60f4a6f3b46877282a43d3ef71044bc07aa/src/heap/concurrent-marking.cc
,
Mar 2 2018
Jobs for traces between spikes caused by using more workers.... maybe this yields something... https://pinpoint-dot-chromeperf.appspot.com/job/12b8c9b4440000 https://pinpoint-dot-chromeperf.appspot.com/job/1680e424440000 (from this benchmark : https://chromeperf.appspot.com/report?sid=4d751475ba95911f865aed7a822d55dde18304bc0cfd2f8409d1de9fe9695343&start_rev=534293&end_rev=540435 )
,
May 4 2018
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 26 2018