"org.chromium.android_webview.test.AwContentsGarbageCollectionTest#testCreateAndGcManyTimes" is flaky |
||||
Issue description"org.chromium.android_webview.test.AwContentsGarbageCollectionTest#testCreateAndGcManyTimes" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZQsSBUZsYWtlIlpvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQXdDb250ZW50c0dhcmJhZ2VDb2xsZWN0aW9uVGVzdCN0ZXN0Q3JlYXRlQW5kR2NNYW55VGltZXMM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/199cf63e9a3d79c25029b9f2b0ef7c366973207d commit 199cf63e9a3d79c25029b9f2b0ef7c366973207d Author: Bo <boliu@chromium.org> Date: Mon Feb 26 17:16:13 2018 Revert "Enable mojo based synchronous compositor" This reverts commit 69ac9fe8f6eb8340280ec386220ea968e8fbf5bd. Reason for revert: Caused crbug.com/816538 , which is a crash causing test flakes. Bug: 816538 Original change's description: > Enable mojo based synchronous compositor > > Turn off disabling mojo input messages for webview. That will enable > the mojo input channel and the mojo synchronous compositor input channel. > > BUG=722928 > > Change-Id: I14ae3d3a83405eb9c6a228f7f08171dab3ca86f2 > Reviewed-on: https://chromium-review.googlesource.com/898553 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539127} TBR=boliu@chromium.org,dtapuska@chromium.org Change-Id: Ic0b24d2fb2d68366f9ce5a7a25daab06ef387c7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 722928 Reviewed-on: https://chromium-review.googlesource.com/937781 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539173} [modify] https://crrev.com/199cf63e9a3d79c25029b9f2b0ef7c366973207d/android_webview/lib/aw_main_delegate.cc
,
Feb 27 2018
Thanks boliu@ for taking care of this. No failures related to this test after your patch.
,
Feb 27 2018
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bea5cdcec3f22ec74569b537541e55ff15a653c commit 7bea5cdcec3f22ec74569b537541e55ff15a653c Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Feb 27 17:26:04 2018 Ensure the SynchronousCompositorMojo is destroyed before InputHandlerProxy Since the SynchronousCompositorProxy (base class of SynchronousCompositorMojo) holds onto a reference to the InputHandlerProxy it must be destroyed before the InputHandlerProxy is destroyed. BUG= 816538 Change-Id: I990b5a427970b28219464267de41a28b1fabb5d0 Reviewed-on: https://chromium-review.googlesource.com/938485 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539481} [modify] https://crrev.com/7bea5cdcec3f22ec74569b537541e55ff15a653c/content/renderer/input/widget_input_handler_manager.cc [modify] https://crrev.com/7bea5cdcec3f22ec74569b537541e55ff15a653c/content/renderer/input/widget_input_handler_manager.h
,
Feb 27 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by boliu@chromium.org
, Feb 26 2018Labels: OS-Android
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)
these are crashes in code that are unrelated to the test. Do not disable the test. Seems to be a null pointer dereference. This is the stack: FILE:LINE 00000000054f3318 content::SynchronousCompositorProxy::~SynchronousCompositorProxy() ??:0:0 00000000054f5de8 content::SynchronousCompositorProxyMojo::~SynchronousCompositorProxyMojo() ??:0:0 0000000005546adc content::SynchronousCompositorProxyRegistry::~SynchronousCompositorProxyRegistry() ??:0:0 0000000005546b24 content::SynchronousCompositorProxyRegistry::~SynchronousCompositorProxyRegistry() ??:0:0 0000000001c5a158 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ??:0:0 0000000003fae350 blink::scheduler::internal::ThreadControllerImpl::DoWork(blink::scheduler::internal::Sequence::WorkType) ??:0:0 0000000001c5a158 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ??:0:0 0000000001c7bb44 base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) ??:0:0 0000000001c7f2cc base::MessageLoop::RunTask(base::PendingTask*) ??:0:0 0000000001c7f614 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) ??:0:0 0000000001c7f840 base::MessageLoop::DoWork() ??:0:0 0000000001c814d0 base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ??:0:0 0000000001c7ec08 base::MessageLoop::Run(bool) ??:0:0 0000000001ca0970 base::RunLoop::Run() ??:0:0 0000000001cd4f88 base::Thread::Run(base::RunLoop*) ??:0:0 0000000001cd5574 base::Thread::ThreadMain() ??:0:0 0000000001cd241c base::(anonymous namespace)::ThreadFunc(void*) ??:0:0 I'm gonna revert the CL that enables mojo..