interactive_ui_tests on forms/passwords are failing with UserActivationV2 |
||
Issue descriptionThe V2 specific failures are not regressions. I hoped they will go away with our form-tracker fix but they didn't: AutofillInteractiveTest.AutofillAfterReload AutofillInteractiveTest.AutofillAfterTranslate AutofillInteractiveTest.AutofillEvents AutofillInteractiveTest.AutofillFormWithNonAutofillableField AutofillInteractiveTest.AutofillFormWithRepeatedField AutofillInteractiveTest.AutofillFormsDistinguishedById AutofillInteractiveTest.BasicFormFill AutofillInteractiveTest.DisableAutocompleteWhileFilling AutofillInteractiveTest.DynamicFormFill AutofillInteractiveTest.InputFiresBeforeChange AutofillInteractiveTest.OnChangeAfterAutofill AutofillInteractiveTest.OnDeleteValueAfterAutofill AutofillInteractiveTest.OnInputAfterAutofill PasswordManagerBrowserTestForManualSaving.ManualFallbackForSaving PasswordManagerBrowserTestForManualSaving.ManualFallbackForSaving_GoToManagedState PasswordManagerBrowserTestForManualSaving.ManualFallbackForSaving_HideAfterTimeout PasswordManagerBrowserTestForManualSaving.ManualFallbackForSaving_HideIcon SitePerProcessAutofillTest.PasswordAutofillPopupPositionInsideOOPIF
,
Feb 26 2018
Looks like a missing frame pointer problem: chromium-review.googlesource.com/937659
,
Feb 26 2018
Would be nice to see the logs.
,
Feb 27 2018
I have confirmed that my CL above fixes these tests with UserActivationV2 enabled.
vasilii@: here is a failure log, which has other failures too :( Jump to Step 151 ("interactive_ui_tests") for the tests I mentioned above.
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/30718
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6b03c4dbcefe420139d662a1898b5051d53a807 commit f6b03c4dbcefe420139d662a1898b5051d53a807 Author: Mustaq Ahmed <mustaq@google.com> Date: Thu Mar 01 18:00:03 2018 Fix a null Frame* in form_tracker. The nullptr was added in a past refactoring before UserActivationV2 was ready. Test failures with v2 enabled exposed the problem. Bug: 816527 Change-Id: Ia94fb85831c9ca312d45695e10cb0701c836153a Reviewed-on: https://chromium-review.googlesource.com/937659 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#540205} [modify] https://crrev.com/f6b03c4dbcefe420139d662a1898b5051d53a807/components/autofill/content/renderer/form_tracker.cc
,
Mar 1 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mustaq@chromium.org
, Feb 26 2018