New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816478 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

DevTools support for Generic Sensors API

Project Member Reported by reillyg@chromium.org, Feb 26 2018

Issue description

DevTools currently supports setting mock sensor data that is exposed to the web through a 'deviceorientation' event. Mock data sent this way should also be exposed by the Generic Sensors-based sensor objects.

As a follow-up, the value of adding support for setting mock sensor data other than device orientation should be investigated.
 
Cc: alexande...@intel.com mikhail....@intel.com
Status: Available (was: Untriaged)
Description: Show this description
Owner: mikhail....@intel.com
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62b316994f61a37a0da79a14b3d9129b5049dc9d

commit 62b316994f61a37a0da79a14b3d9129b5049dc9d
Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Date: Mon Apr 30 09:30:04 2018

DevTools support for Generic Sensors API

DevTools currently supports setting mock sensor data
that is exposed to the web through a 'deviceorientation'
event. Mock data sent this way should also be exposed by
the Generic Sensors-based sensor objects.

This CL is re-using the existing DevTools infra and UI and
thus it brings a dependency from the 'deviceorientation' module
to the 'sensor' module in Blink.

In the future there should be Generic Sensor-specific extension
to the browser protocol and a more sophisticated UI.

Note: Unlike 'deviceorientation' events, page reload is required,
to bring the overriden device orientation data into action
for the `OrientationSensor`-based classes. A dedicated console
message is shown to notify the user.

Bug:  816478 
Change-Id: If6f7371ab20790e30a41cee52636cd0a92715065
Reviewed-on: https://chromium-review.googlesource.com/1024172
Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554713}
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/WebKit/LayoutTests/http/tests/devtools/device-orientation-success-expected.txt
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/WebKit/LayoutTests/http/tests/devtools/device-orientation-success.js
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/device_orientation/DEPS
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/device_orientation/device_orientation_inspector_agent.cc
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/device_orientation/device_orientation_inspector_agent.h
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/BUILD.gn
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor.cc
[add] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor_inspector_agent.cc
[add] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor_inspector_agent.h
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor_provider_proxy.cc
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor_provider_proxy.h
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor_proxy.cc
[modify] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor_proxy.h
[add] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor_proxy_impl.cc
[add] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor_proxy_impl.h
[add] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor_proxy_inspector_impl.cc
[add] https://crrev.com/62b316994f61a37a0da79a14b3d9129b5049dc9d/third_party/blink/renderer/modules/sensor/sensor_proxy_inspector_impl.h

Cc: -mikhail....@intel.com -alexande...@intel.com
Owner: alexande...@intel.com
Status: Fixed (was: Started)

Sign in to add a comment