This issue tracks the work necessary to upstream the existing Generic Sensors API LayoutTests into the Web Platform Tests repository. As with other device APIs like Web Bluetooth and WebUSB these tests require an interface for injecting mock data. This is currently done using a Javascript mock of the Mojo SensorProvider interface. If this is moved to a Chromium-specific support file then the rest of the tests can be moved to the Web Platform Tests repository. As a bonus this will also allow for upstreaming of the tests in LayoutTests/device_orientation once issue 774183 is resolved. Examples: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/webusb-test.js
Just filed https://github.com/w3c/web-platform-tests/issues/9686 about this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/303956b6ed95cd655ac1d11f18d8d8730cffeed1 commit 303956b6ed95cd655ac1d11f18d8d8730cffeed1 Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Date: Fri Apr 13 11:09:20 2018 Enable WPT tests for the Generic Sensor classes This patch introduces mock implementations of the Sensor and SensorProvider mojo interfaces to the WPT tests for Chromium. The ongoing WPT issue for the Generic Sensor tests automation: https://github.com/w3c/web-platform-tests/issues/9686 Bug: 816462 Change-Id: I8e4880ee5269b07f0bf68a2752038e128d166c55 Reviewed-on: https://chromium-review.googlesource.com/980886 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#550586} [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/content/shell/browser/layout_test/layout_test_message_filter.cc [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/services/device/public/mojom/BUILD.gn [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer-disabled-by-feature-policy.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer-disabled-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer-enabled-by-feature-policy-attribute-redirect-on-load.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer-enabled-by-feature-policy-attribute-redirect-on-load.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer-enabled-by-feature-policy-attribute.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer-enabled-by-feature-policy-attribute.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer-enabled-by-feature-policy.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer-enabled-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer-enabled-on-self-origin-by-feature-policy.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer-enabled-on-self-origin-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer_onerror-manual.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/accelerometer/Accelerometer_onerror-manual.https.html [add] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/generic-sensor/README.md [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/generic-sensor/generic-sensor-feature-policy-test.sub.js [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/generic-sensor/generic-sensor-tests.js [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/gyroscope/Gyroscope-disabled-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/gyroscope/Gyroscope-enabled-by-feature-policy-attribute-redirect-on-load.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/gyroscope/Gyroscope-enabled-by-feature-policy-attribute.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/gyroscope/Gyroscope-enabled-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/gyroscope/Gyroscope-enabled-on-self-origin-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/gyroscope/Gyroscope.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/gyroscope/Gyroscope.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/gyroscope/Gyroscope_onerror-manual.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/lint.whitelist [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer-disabled-by-feature-policy.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer-disabled-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer-enabled-by-feature-policy-attribute-redirect-on-load.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer-enabled-by-feature-policy-attribute-redirect-on-load.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer-enabled-by-feature-policy-attribute.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer-enabled-by-feature-policy-attribute.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer-enabled-by-feature-policy.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer-enabled-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer-enabled-on-self-origin-by-feature-policy.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer-enabled-on-self-origin-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer_onerror-manual.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/magnetometer/Magnetometer_onerror-manual.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/AbsoluteOrientationSensor-disabled-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/AbsoluteOrientationSensor-enabled-by-feature-policy-attribute-redirect-on-load.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/AbsoluteOrientationSensor-enabled-by-feature-policy-attribute.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/AbsoluteOrientationSensor-enabled-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/AbsoluteOrientationSensor-enabled-on-self-origin-by-feature-policy.https.html [add] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/AbsoluteOrientationSensor.https-expected.txt [add] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/AbsoluteOrientationSensor.https.html [delete] https://crrev.com/f8fb043b44a12f145b5bcce52d59f9b450923d63/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/OrientationSensor.https-expected.txt [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/OrientationSensor_onerror-manual.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/RelativeOrientationSensor-disabled-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/RelativeOrientationSensor-enabled-by-feature-policy-attribute-redirect-on-load.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/RelativeOrientationSensor-enabled-by-feature-policy-attribute.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/RelativeOrientationSensor-enabled-by-feature-policy.https.html [modify] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/RelativeOrientationSensor-enabled-on-self-origin-by-feature-policy.https.html [add] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/RelativeOrientationSensor.https-expected.txt [add] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/RelativeOrientationSensor.https.html [rename] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/orientation-sensor/orientation-sensor-tests.js [add] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/generic_sensor_mocks.js [add] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/generic_sensor_mocks.js.headers [add] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/sensor.mojom.js [add] https://crrev.com/303956b6ed95cd655ac1d11f18d8d8730cffeed1/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/sensor_provider.mojom.js
The assigned owner "mikhail.pozdnyakov@intel.com" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Comment 1 by mikhail....@intel.com
, Feb 26 2018Status: Assigned (was: Available)