New issue
Advanced search Search tips

Issue 816454 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Expose wasDiscarded on Document

Project Member Reported by panicker@chromium.org, Feb 26 2018

Issue description

Per Lifecycle API, expose wasDiscarded on Document after discarding.
For details see: 
https://github.com/WICG/web-lifecycle/blob/master/README.md
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953

commit ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953
Author: Shubhie Panicker <panicker@chromium.org>
Date: Tue Mar 06 00:09:06 2018

Attempt #2: Expose wasDiscarded after tab discard.

This is needed for Lifecycle API, see:
https://github.com/WICG/web-lifecycle
WasDiscarded is set on RequestNavigationParams on browser side and
passed into to WebURLRequest on renderer side. And later
set on the Document in DocumentLoader::CommitNavigation.

For detailed discussion, see (internal) thread:
https://groups.google.com/a/google.com/d/msg/chrome-lifecycle-apis/e0vsRLUISBE/t_BKYGcwAQAJ

Change-Id: I160628db6ba0a01f7b5281c78d7c2df40a28611f

BUG:  chromium:816454 
Change-Id: I160628db6ba0a01f7b5281c78d7c2df40a28611f
Reviewed-on: https://chromium-review.googlesource.com/912488
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540997}
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/chrome/browser/resource_coordinator/tab_manager_browsertest.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/frame_tree.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/frame_tree.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/frame_tree_node.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/frame_tree_node_blame_context_unittest.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/frame_tree_unittest.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/common/frame_messages.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/common/navigation_params.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/public/browser/web_contents.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/third_party/WebKit/Source/core/dom/Document.idl
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h
[modify] https://crrev.com/ddf2a4e4ae9966ceaaf7854226b8fcd007bfe953/third_party/WebKit/public/platform/WebURLRequest.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/866f56d1fe24d3a1be24684a17ae331ed1dd2e3f

commit 866f56d1fe24d3a1be24684a17ae331ed1dd2e3f
Author: Shubhie Panicker <panicker@chromium.org>
Date: Fri Mar 16 00:11:25 2018

Add tests for Document.wasDiscarded for sub-frames and OOPIF.

Bug:  816454 
Change-Id: Ic1199c44b6e30d0118c9f3843364359bf63a42f5
Reviewed-on: https://chromium-review.googlesource.com/953244
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543566}
[modify] https://crrev.com/866f56d1fe24d3a1be24684a17ae331ed1dd2e3f/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/866f56d1fe24d3a1be24684a17ae331ed1dd2e3f/chrome/browser/resource_coordinator/tab_manager_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/194f1d61ffa4b7ff92d93e762deea582a65fa52c

commit 194f1d61ffa4b7ff92d93e762deea582a65fa52c
Author: Alex Moshchuk <alexmos@chromium.org>
Date: Wed Mar 21 01:21:26 2018

Set RenderFrameHostImpl::was_discarded_ only for successful commits.

This is a quick followup to r540997 to move initialization of
RenderFrameHostImpl's discarded state a bit later in the commit
process, once we know that the commit will be successful.  This will
prevent updating wasDiscarded if the commit fails, for example due to
failing ValidateDidCommitParams or a couple of other cases in
RenderFrameHostImpl::DidCommitProvisionalLoad().

Bug:  816454 
Change-Id: Ib1a1a9ef562c8ea74f001d08eeb26220a0a791bf
Reviewed-on: https://chromium-review.googlesource.com/952572
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544609}
[modify] https://crrev.com/194f1d61ffa4b7ff92d93e762deea582a65fa52c/content/browser/frame_host/render_frame_host_impl.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c821cebffa4c796872e2d509585b32611e515689

commit c821cebffa4c796872e2d509585b32611e515689
Author: Shubhie Panicker <panicker@chromium.org>
Date: Tue Mar 27 21:05:36 2018

Fix up some test followups.

Bug:  816454 
Change-Id: Ic5845f9183b3be6edd1be6ffbb322c43e4b0a11a
Reviewed-on: https://chromium-review.googlesource.com/967516
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546256}
[modify] https://crrev.com/c821cebffa4c796872e2d509585b32611e515689/chrome/browser/resource_coordinator/tab_manager_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment