New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 816443 link

Starred by 1 user
Status: Fixed
Owner:
charliea@chromium.org
Closed: Mar 2018
Cc:
█ nednguyen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

BattOr binary dependencies not prefetched when running Telemetry unit tests

Project Member Reported by charliea@chromium.org, Feb 26 2018 
Telemetry prefetches all of its binary dependencies from cloud storage when running unit tests. This should include the battor agent and any new BattOr firmware.

However, problematically, the BattOr firmware and battor agent *aren't* prefetched, and Telemetry unit tests fail because of this. The reason for this is that the platform strings differ slightly between most binary dependency JSON files and the BattOr binary dependency JSON files. This needs to be fixed before rolling the BattOr agent and firmware.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/766143cf63df0d9c5a346f055037d071ca7059ba

commit 766143cf63df0d9c5a346f055037d071ca7059ba
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon Feb 26 16:09:43 2018

Use normal platform/arch strings in BattOr binary dependencies

This solves a long-standing issue where the BattOr binary dependency
strings looked different than the normal Telemetry ones (e.g.
"linux2_x86_64" vs. "linux_x86_64"). To fix this, I moved over to
py_utils to generate the platform/arch strings. The BattOr strings
still behave _slightly_ differently: when we're running an Android test
and the Android device is attached to a non-Android host, the platform
string will be that of the host rather than that of the Android device.
However, for the purposes of BattOr, this is correct anyhow because the
software that we need to download is running on the host machine, not
the device under test.

This should solve the problem where fetch_telemetry_binary_dependencies
wasn't downloading battor_agent and avrdude.

Bug:  chromium:816443 
Change-Id: I3fd142cd5021ccadab0e8802075d3107f019c5a0
Reviewed-on: https://chromium-review.googlesource.com/937643
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>

[modify] https://crrev.com/766143cf63df0d9c5a346f055037d071ca7059ba/common/battor/battor/battor_binary_dependencies.json
[modify] https://crrev.com/766143cf63df0d9c5a346f055037d071ca7059ba/common/battor/battor/battor_wrapper.py
[modify] https://crrev.com/766143cf63df0d9c5a346f055037d071ca7059ba/common/battor/battor/battor_wrapper_devicetest.py
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/d38652e6b15bc5510d3469acccd20c361e406cbe

commit d38652e6b15bc5510d3469acccd20c361e406cbe
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue Feb 27 02:47:07 2018

Fix remaining reference to bad host/arch strings in BattOr wrapper

These should have been fixed in https://crrev.com/c/937643, but I missed
them.

TBR=perezju@chromium.org
Bug:  chromium:816443 
Change-Id: Ia5e232872d8a8583faf597d413ca5306e0a4c193
Reviewed-on: https://chromium-review.googlesource.com/938953
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>

[modify] https://crrev.com/d38652e6b15bc5510d3469acccd20c361e406cbe/common/battor/battor/battor_wrapper.py

Comment 3 by charliea@chromium.org, Mar 29 2018

Status: Fixed (was: Assigned)

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 5 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
►

Sign in to add a comment