New issue
Advanced search Search tips

Issue 816441 link

Starred by 2 users
Status: Assigned
Owner:
hidehiko@chromium.org
Cc:
dominickn@chromium.org
khmel@chromium.org
yusukes@chromium.org
nigeltao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Extract backend part form ArcAppListPrefs into components/arc/app.

Project Member Reported by hidehiko@chromium.org, Feb 26 2018 
ArcAppListPrefs become gigantic class, and that class is being depended by classes outside from chrome.

It looks time to simplify the structure. My proposal is;
- Split the class into at least two.
  - Backend part (Mojo service part, and managing android apps caching)
  - Frontend part (Using the backend class, implement app_list behavior).

As for Backend part, I also propose to move it into components/arc/app.

Comment 1 by khmel@chromium.org, Feb 26 2018 

Thank you for proposal.
Besides this it is beneficial to split  Observer to
AppObserver
TaskObserver
PackagesObserver.

This would also reduce the complexity.

Comment 2 by dominickn@chromium.org, Jun 14 2018

Cc: dominickn@chromium.org
We have a proposal to create an App Service, and one element of that would be to abstract over the app-platform code for maintaining app state. Splitting up ArcAppListPrefs would be helpful for us since we'd like to potentially move the "frontend" component to within the App Service, and refactor the app list / other consumers to talk to the App Service instead of to ArcAppListPrefs directly. The backend component living in components/arc seems very sensible too.

Our design doc (Google-internal for now) is https://docs.google.com/document/d/1oc2BPABvnkctf0EP_9kyuH4h3eZTfDXkpGD8jczH6sE/edit?ts=5b03bc2b#heading=h.y7amr11fn0tb

Comment 3 by weifangsun@chromium.org, Jun 15 2018

Components: Platform>Apps>ARC

Comment 4 by dominickn@chromium.org, Jun 18 2018

Components: Platform>Apps>Foundation

Comment 5 by dominickn@chromium.org, Jun 28 2018

Cc: nigeltao@chromium.org
+cc nigeltao.

Our team in SYD can look at taking this bug on in roughly 1-2 months as part of our App Service work. Would it be useful to meet to work out some of the details as we get towards implementation?

Comment 6 by benhenry@chromium.org, Aug 2

Status: Assigned (was: Available)

Comment 7 by lhchavez@chromium.org, Jan 7

Cc: -lhchavez@chromium.org
►

Sign in to add a comment