New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816440 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Remove third_party/mt19937ar

Project Member Reported by asvitk...@chromium.org, Feb 26 2018

Issue description

Remove third_party/mt19937ar now that Chrome can just use std::mt19937.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7251664af05f4e1651959c717d4f52720cf1c433

commit 7251664af05f4e1651959c717d4f52720cf1c433
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Wed Feb 28 03:08:52 2018

Remove third_party/mt19937ar.

Replace with std::mt19937 from C++11, which is now available
for all builds.

No functional changes, which is verified by existing variations
unit tests.

Bug:  816440 
Change-Id: I03437494948283f26b7f2f2b089f3f89440601ba
Reviewed-on: https://chromium-review.googlesource.com/937381
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539685}
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/components/variations/BUILD.gn
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/components/variations/DEPS
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/components/variations/entropy_provider.cc
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/components/variations/entropy_provider.h
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/media/cast/BUILD.gn
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/media/cast/DEPS
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/media/cast/test/utility/udp_proxy.cc
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/media/cast/test/utility/udp_proxy.h
[delete] https://crrev.com/f7e7f4fa0e58f902ff462fe08310291967e4e77d/third_party/mt19937ar/BUILD.gn
[delete] https://crrev.com/f7e7f4fa0e58f902ff462fe08310291967e4e77d/third_party/mt19937ar/DEPS
[delete] https://crrev.com/f7e7f4fa0e58f902ff462fe08310291967e4e77d/third_party/mt19937ar/LICENSE
[delete] https://crrev.com/f7e7f4fa0e58f902ff462fe08310291967e4e77d/third_party/mt19937ar/OWNERS
[delete] https://crrev.com/f7e7f4fa0e58f902ff462fe08310291967e4e77d/third_party/mt19937ar/README.chromium
[delete] https://crrev.com/f7e7f4fa0e58f902ff462fe08310291967e4e77d/third_party/mt19937ar/mt19937ar.cc
[delete] https://crrev.com/f7e7f4fa0e58f902ff462fe08310291967e4e77d/third_party/mt19937ar/mt19937ar.h
[delete] https://crrev.com/f7e7f4fa0e58f902ff462fe08310291967e4e77d/third_party/mt19937ar/readme-mt.txt
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/tools/ipc_fuzzer/fuzzer/DEPS
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/tools/ipc_fuzzer/fuzzer/rand_util.cc
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/tools/ipc_fuzzer/fuzzer/rand_util.h
[modify] https://crrev.com/7251664af05f4e1651959c717d4f52720cf1c433/tools/ipc_fuzzer/message_lib/BUILD.gn

Status: Verified (was: Started)

Sign in to add a comment