New issue
Advanced search Search tips

Issue 816435 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 816326

Blocking:
issue 495204



Sign in to add a comment

Make run-swarmed.py work for Windows builds

Project Member Reported by thakis@chromium.org, Feb 26 2018

Issue description

https://chromium.googlesource.com/chromium/src/+/master/docs/win_cross.md#running-tests-on-swarming has a lengthy invocation for running linux-built windows binaries on swarming. I finally got bored of copy-pasting that in every time I need it, so I put it into a python script: https://chromium-review.googlesource.com/c/chromium/src/+/936667/1/tools/win/run_swarmed.py

Then I looked again at the existing Fuchsia variant, and that looked similar enough that figured I'd modify that instead: https://chromium-review.googlesource.com/c/chromium/src/+/936588

Alas, the Fuchsia script uses --dump-json which apparently doesn't work on Windows ( issue 816326 ).


Options:
- land separate run-swarmed.py script for Windows
- wait for swarming folks to fix  issue 816326 

The latter seems better, but who knows if it's going to happen. So I guess let's wait a month and see where we are then.
 

Comment 1 by thakis@chromium.org, Feb 26 2018

Blocking: 495204
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b161b5635f0996461ce4eac61eecd69f7bc4a4bc

commit b161b5635f0996461ce4eac61eecd69f7bc4a4bc
Author: Nico Weber <thakis@chromium.org>
Date: Tue Feb 27 14:31:44 2018

Make tools/fuchsia/run-swarmed.py work for win/cross binaries too and move it to tools/

Bug:  816435 
Change-Id: Iae8fd393c8fae53387ecf02d5e5779a44dee3030
Reviewed-on: https://chromium-review.googlesource.com/936588
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539425}
[rename] https://crrev.com/b161b5635f0996461ce4eac61eecd69f7bc4a4bc/tools/run-swarmed.py

Comment 3 by thakis@chromium.org, Mar 29 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment