New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816414 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Screen rotation Notification is still seen at 'Notifications' even after clicking on it

Project Member Reported by mmanchala@chromium.org, Feb 26 2018

Issue description

Chrome Version:  64.0.3282.190/10176.76.0 Stable-channel  Kip,Reks and Daisy
OS: Chrome

What steps will reproduce the problem?
(1))Sign into user -> Now rotate screen to 0 degrees on pressing 'Ctrl+Shift+Reload' buttons
(2)Now  observe 'Internal Display was rotated to 0' is seen at Notifications -> Now click on Notifications Icon -> Again Notification is seen and click on it
(3)Navigates to 'Displays' section in chrome://settings/ -> observe Screen rotation Notification is still seen at 'Notifications' even on clicking it
(Please refer Video)

Note: 
1.Save any Image(or Download any video or Save any Page) -> click on Notifications Icon -> Notification is seen and expand it -> Click on Image  and FilesApp gets opened -> observe Notification is not seen at 'Notifications' after clicking on it (Please refer 'Expected_NotificationBehavior' for Video)
2. Issue is seen on M-65 and on latest M-66 also

Expected:  Screen rotation Notification should not be seen at 'Notifications' after clicking on it
Actual: Instead  Screen rotation Notification is still seen at 'Notifications' even on clicking it

This is Non-Regression issue seen from M-62

@yoshiki : Please confirm the Issue
 
Actual_Notification.webm
704 KB View Download
Expected_NotificationBehavior.webm
5.8 MB View Download
Cc: yoshiki@chromium.org
Owner: megumihattori@google.com
yoshiki@ mentioned offline that he can hand over this issue to me.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d6228100c5921249cb449dd08bf2c2b8951e49a

commit 1d6228100c5921249cb449dd08bf2c2b8951e49a
Author: Megumi Hattori <megumihattori@google.com>
Date: Fri Mar 02 05:21:02 2018

Close screen layout notification after clicked.

Previously, when the screen layout notification was clicked, settings
was opened, but the notification is still seen.

However, the notification should be closed just after clicked.

BUG= 816414 
TEST=ash_unittests

Change-Id: I853515e6131d7377f94d5d4cbf120f0fd95d0c3c
Reviewed-on: https://chromium-review.googlesource.com/938804
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Cr-Commit-Position: refs/heads/master@{#540452}
[modify] https://crrev.com/1d6228100c5921249cb449dd08bf2c2b8951e49a/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/1d6228100c5921249cb449dd08bf2c2b8951e49a/ash/system/screen_layout_observer_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment