The current Typed OM code will do its best to support any CSS property. This works most of the time, but can sometimes get the computed value wrong (as computed style code may return the used value instead).
We should be more disciplined and explicitly whitelist properties that we support.
if we were add check logic for whitelist,
when unsupported property was passed in StyleValueFactory::CreateStyleValueWithProperty, what we do?
do we should just return CreateStyleValue(nullptr) like present implement,
or do we have to throw NotSupportError?
is whitelist should have same list with the list in spec[1] eventually?
[1]https://drafts.css-houdini.org/css-typed-om-1/#reify-property-style-value
We should return an CSSUnsupportedStyleValue, so that it can be upgraded to a full fledged CSSStyleValue subclass when we do support it.
Eventually yeah, the whitelist should be the same as the spec. It'll be a large effort to achieve parity with the spec, so we should just properly ship what we can and no more.
@shend
i am working do process to add whitelist. and i have a question.
some properties like "transition-duration" was missed in "the-stylepropertymap/properties/"
but "transition-duration" was used to make test in wpt("stylevalue-objects/parseAll.html")
also it is included in spec's list
(https://drafts.css-houdini.org/css-typed-om-1/#reify-property-style-value)
so that properties should be included in whitelist?
and also do we have to add test for missed properties in "the-stylepropertymap/properties/"
Hi Hwanseung, I was looking to this, and it seems like this is more difficult than I thought because a few properties that we didn't plan to ship are being used for tests outside of typed om :(
Do you mind if I took over this bug?
@shend
sure.
when i saw result of layout tests after make patch,
i also worried about some properties which used for test in css-paint-api and css-layout-api.
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)
For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Comment 1 by shend@chromium.org
, Feb 26 2018