Issue metadata
Sign in to add a comment
|
Regression : Unable to drag a tab out from original window using tap/touch on Windows 10 touch device
Reported by
vineetha...@etouch.net,
Feb 26 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 66.0.3355.0 (Official Build) 31d0bb0369f909177f2ce90b439f296bcf9c90cb-refs/heads/master@{#539001}(32/64 bit) OS: Windows 10(Touch device) What steps will reproduce the problem? (1) Launch Chrome, open a new tab. (2) Try to drag the tab out from original window using tap/touch and observe. Actual Result: Unable to drag a tab out from original window using tap/touch. Expected Result: Should be able to drag a tab out from original window using tap/touch. This is regression issue broken in ‘M-66’ and below is manual bisect info, Good build: 66.0.3345.0 (Revision:536027) Bad build: 66.0.3346.0 (Revision:536238) Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/9acf995e9af77804c7367e7cb2587962250e8654..76e19961dc5ff8f27812cef9de0e4b85621f2e7c (Unable to narrow down the range using per-revision bisect since chrome builds crashes after launch) Suspecting: r536136 ? from Narrow bisect @dtapuska: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: This is a Windows 10 touch device specific issue and is not reproducible on Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS) OS. Thank You!
,
Feb 26 2018
marking as RBS, please change if required
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6ab5e3931c5dea36ed7608ae24ac72420ca90bc commit f6ab5e3931c5dea36ed7608ae24ac72420ca90bc Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Feb 28 03:49:31 2018 Fix tab dragging outside of window with touch events. Fix a regression in dragging a tab outside of the window. The hit test that was added to check that we were inside the HT_CLIENT bounds worked correctly for the profile, min/max buttons but not for items in the tab strip. The WM_MOUSE compatiblity events need to be dispatched to make this drag of the tab work. The hit test was actually added because it solved a problem with the profile avatar button and the window getting dismissed. The WM_TOUCH path solves it in a slightly different way incrementing touch_down_contexts and returns MA_NOACTIVATE if there are any touch down contexts active. Use this same way with WM_POINTER for touch. BUG= 812508 , 816391 Change-Id: Iacc874ab164866567e8c0cde14c2a1803f2081e2 Reviewed-on: https://chromium-review.googlesource.com/938221 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#539696} [modify] https://crrev.com/f6ab5e3931c5dea36ed7608ae24ac72420ca90bc/ui/views/mus/BUILD.gn [modify] https://crrev.com/f6ab5e3931c5dea36ed7608ae24ac72420ca90bc/ui/views/widget/widget_interactive_uitest.cc [modify] https://crrev.com/f6ab5e3931c5dea36ed7608ae24ac72420ca90bc/ui/views/win/hwnd_message_handler.cc
,
Feb 28 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vineetha...@etouch.net
, Feb 26 2018