New issue
Advanced search Search tips

Issue 816382 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Compat

Blocking:
issue 771643



Sign in to add a comment

transformed element is not repainted when its absolute position is changed

Reported by babata...@gmail.com, Feb 26 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3355.2 Safari/537.36

Example URL:
https://jsfiddle.net/pnhLkd25/6/

Steps to reproduce the problem:
1. Open https://jsfiddle.net/pnhLkd25/6/

What is the expected behavior?
"hello, world" should be moving to the right.

What went wrong?
The text is visually not moved, while the dimension confirmed with the inspector is moved.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes 65.0.3325.88 (beta)

Does this work in other browsers? Yes

Chrome version: 66.0.3355.2  Channel: canary
OS Version: 10.0
Flash Version: 

- The text is repainted when the "noop" button is hovered.
- Also selecting the text causes a repaint.
 
screenshot.png
67.9 KB View Download

Comment 1 by babata...@gmail.com, Feb 26 2018

I've found that the issue does not occur on 66.0.3350.0

Comment 2 by woxxom@gmail.com, Feb 26 2018

Bisect info: 537453 (good) - 537469 (bad)
https://chromium.googlesource.com/chromium/src/+log/e282ebc6..3dfc0ccd?pretty=fuller
Suspecting r537454 = 0a9a5c311a1d3a298f952e495510bd6fe3faa2f6 = https://crrev.com/c/923572 by wangxianzhu@chromium.org
"[SPv175] Enable SlimmingPaintV175 by default"
Landed in 66.0.3351.0

Confirmed by disabling SlimmingPaintV175 and observing the bug is gone:
chrome --disable-blink-features=SlimmingPaintV175
Components: Blink>Paint
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Components: -Blink>Paint Blink>Paint>Invalidation
Blocking: 771643
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/854a2f3135e02597cee6b211c25b9402976dd727

commit 854a2f3135e02597cee6b211c25b9402976dd727
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Feb 28 02:26:11 2018

[SPv175+] GraphicsLayer::SetNeedsCheckRasterInvalidation()

The flag for an GraphicsLayer is set when an object under the
GraphicsLayer
- has changed any paint property;
- may change paint properties relative to the GraphicsLayer (see
  https://chromium-review.googlesource.com/920658 which called
  SetNeedsRepaint for the non-composited fix-position case).
when the object's layer doesn't need repaint.

Bug:  816382 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I16bd6f0f3a8c2bc80005afe5de1cf67d83a28fb9
Reviewed-on: https://chromium-review.googlesource.com/939081
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539664}
[add] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/LayoutTests/paint/invalidation/absolute-with-transform-move-expected.html
[add] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/LayoutTests/paint/invalidation/absolute-with-transform-move.html
[modify] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
[modify] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
[modify] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
[modify] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/854a2f3135e02597cee6b211c25b9402976dd727/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h

Status: Fixed (was: Assigned)

Sign in to add a comment